From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C172C43381 for ; Mon, 18 Mar 2019 19:36:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BBA620828 for ; Mon, 18 Mar 2019 19:36:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="TgHSbjwb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727437AbfCRTgj (ORCPT ); Mon, 18 Mar 2019 15:36:39 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:40660 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726677AbfCRTgj (ORCPT ); Mon, 18 Mar 2019 15:36:39 -0400 Received: by mail-qt1-f194.google.com with SMTP id x12so3272757qts.7 for ; Mon, 18 Mar 2019 12:36:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=qhDrtYwSINZbVFcILqtFOhjFPIbJEavmTPeVDyN1S74=; b=TgHSbjwbUD/QHnqIQQGtXgA2NZvBy0Og1Z7sSilyjvxcLEIU4WlA7Qx8AORwvZbGdo xxoP0+LGGPuIeMBd+Pgly3bvXcnI4B+SdchOq2qk73Wfsvu+G5ePzCyffpxq7hnlk8mv Xbdi9O2ZdNXxhLKH3vP+by/7vgHV7JGlr55g4oHngOgMNgS49CrhdEBLUJq4Xx/v6dTt lt8wVi/FpbSkA6xDeCXn+BsG9792Wo55y/JS2g5zwWoq+VluCiI4UFj6ouwLUb1SiggB gkAAwHBjB+oMV8rvO7Y1tqt32ywZwZwBZPjf0Ns0Id+HgpZrOPd+klYoy2NxAdIt1d2M xM6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=qhDrtYwSINZbVFcILqtFOhjFPIbJEavmTPeVDyN1S74=; b=DLopCZpjok7i/3jK74/lpOLnDhvnj7OTl4gsj7yGNhfwI5I6F2i84uAvTipJrGbacL Bz2vX/hmUUM+xG8mgqEuJC5UpZarrU3NWgyEOSl/RFKKPGSr8Ir6/ogSkGkX4EF7fT15 R2tiQkxCTWMswdxiN8omys7Tm7lH5VnNusOFlfY6xtshCkrNSjRFGDB8PHVb8kTwIaR4 Bzy4vK4kK1pXdssQ7OgMkPfItfo7FMz0DdbcOHqOawiIJUkxli6e3uxrzleC+6sSPwYn +wdEJ5npr/L3VpUbBTYuECtVjEC0dVLjkM1zFP/2J/HuXTRXB4/4uDMCL2k5jngfK6ft AMMQ== X-Gm-Message-State: APjAAAV0BqGHcLRxbe7JdI3wJziWIo21SUghoF8Wun4njg6hfR2l4CMD D+C4NoHwl5jxufdaHWnKyJhtRA== X-Google-Smtp-Source: APXvYqyXCZ/3L9eE4P9ZiiN796NvRJHbypM6te1HRH2AvbDf+RrbpRQa0i9KgVkTDjIv8TJiYGRiKg== X-Received: by 2002:a0c:b05c:: with SMTP id l28mr6286511qvc.95.1552937798559; Mon, 18 Mar 2019 12:36:38 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id p127sm5837315qke.97.2019.03.18.12.36.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Mar 2019 12:36:38 -0700 (PDT) Date: Mon, 18 Mar 2019 12:36:34 -0700 From: Jakub Kicinski To: Parav Pandit Cc: Jiri Pirko , "Samudrala, Sridhar" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "oss-drivers@netronome.com" Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Message-ID: <20190318123634.6e90c043@cakuba.netronome.com> In-Reply-To: References: <20190314150945.031d1b08@cakuba.netronome.com> <20190314163915.24fd2481@cakuba.netronome.com> <4436da3d-4b99-f792-8e77-695d5958794d@intel.com> <20190315200814.GD2305@nanopsycho> <20190318122105.GH2270@nanopsycho> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 18 Mar 2019 16:22:33 +0000, Parav Pandit wrote: >>>>>>2. flavour should not be vf/pf, flavour should be hostport, switchport. >>> >Because switch is flat and agnostic of pf/vf/mdev. >>>>> >>>>> Not sure. It's good to have this kind of visibility. >>>>> >>>> port can have label/attribute indicating that this belong to VF-1 or >>>> mdev as long as you are agreeing to have mdev attribute on host port. >>>> (and not ask for abstracting it, because mdev is well defined kernel object). >>> >>> Why mdev cannot be another flavour? >>> >> >> hostport is of type pf/vf/mdev connected to some switchport. >> >> So proposal is to have, >> port flavour = hostport/switchport >> port type/label = pf/vf/mdev >> > Instead of having two attributes per port, how about having, > port flavour= physical/cpu/dsa/pf/vf/mdev/switchport. > > physical and pf has some overlapping definitions. What "overlapping definitions" do physical and PF have? Sounds like you're referring to limitations of Mellanox HW.