From: Kangjie Lu <kjlu@umn.edu>
To: kjlu@umn.edu
Cc: pakki001@umn.edu, MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Hans de Goede <hdegoede@redhat.com>, Chen-Yu Tsai <wens@csie.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] extcon: fix a missing check of regmap_read
Date: Mon, 18 Mar 2019 11:41:21 -0500 [thread overview]
Message-ID: <20190318164121.13838-1-kjlu@umn.edu> (raw)
When regmap_read fails, it doesn't make sense to use the read
value "val" because it can be uninitialized.
The fix returns if regmap_read fails.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
---
drivers/extcon/extcon-axp288.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
index a983708b77a6..b2ba5f073aa7 100644
--- a/drivers/extcon/extcon-axp288.c
+++ b/drivers/extcon/extcon-axp288.c
@@ -143,6 +143,10 @@ static void axp288_extcon_log_rsi(struct axp288_extcon_info *info)
int ret;
ret = regmap_read(info->regmap, AXP288_PS_BOOT_REASON_REG, &val);
+ if (ret) {
+ dev_dbg(info->dev, "regmap_read error %d\n", ret);
+ return;
+ }
for (i = 0, rsi = axp288_pwr_up_down_info; *rsi; rsi++, i++) {
if (val & BIT(i)) {
dev_dbg(info->dev, "%s\n", *rsi);
--
2.17.1
next reply other threads:[~2019-03-18 16:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190318164133epcas5p1a539488d8614011bdf4e734d76da4cc3@epcas5p1.samsung.com>
2019-03-18 16:41 ` Kangjie Lu [this message]
2019-03-18 17:30 ` [PATCH] extcon: fix a missing check of regmap_read Hans de Goede
2019-03-19 0:39 ` Chanwoo Choi
2019-03-20 7:35 ` Kangjie Lu
2019-03-20 8:00 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190318164121.13838-1-kjlu@umn.edu \
--to=kjlu@umn.edu \
--cc=cw00.choi@samsung.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=pakki001@umn.edu \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.