From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 942C6C43381 for ; Mon, 18 Mar 2019 17:25:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BB0420854 for ; Mon, 18 Mar 2019 17:25:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727235AbfCRRZE (ORCPT ); Mon, 18 Mar 2019 13:25:04 -0400 Received: from foss.arm.com ([217.140.101.70]:38514 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726704AbfCRRZD (ORCPT ); Mon, 18 Mar 2019 13:25:03 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 37CCA1650; Mon, 18 Mar 2019 10:25:03 -0700 (PDT) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 683063F614; Mon, 18 Mar 2019 10:25:00 -0700 (PDT) Date: Mon, 18 Mar 2019 17:24:57 +0000 From: Sudeep Holla To: Oleg Nesterov Cc: x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Catalin Marinas , Will Deacon , Paul Mackerras , Michael Ellerman , Thomas Gleixner , Ingo Molnar , Richard Weinberger , jdike@addtoit.com, Steve Capper , Haibo Xu , Bin Lu , Andy Lutomirski Subject: Re: [PATCH v2 4/6] powerpc: use common ptrace_syscall_enter hook to handle _TIF_SYSCALL_EMU Message-ID: <20190318172457.GD18196@e107155-lin> References: <20190318104925.16600-1-sudeep.holla@arm.com> <20190318104925.16600-5-sudeep.holla@arm.com> <20190318172024.GB23521@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190318172024.GB23521@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 18, 2019 at 06:20:24PM +0100, Oleg Nesterov wrote: > On 03/18, Sudeep Holla wrote: > > > > --- a/arch/powerpc/kernel/ptrace.c > > +++ b/arch/powerpc/kernel/ptrace.c > > @@ -3278,35 +3278,29 @@ long do_syscall_trace_enter(struct pt_regs *regs) > > > > user_exit(); > > > > - flags = READ_ONCE(current_thread_info()->flags) & > > - (_TIF_SYSCALL_EMU | _TIF_SYSCALL_TRACE); > > - > > - if (flags) { > > - int rc = tracehook_report_syscall_entry(regs); > > + if (unlikely(ptrace_syscall_enter(regs))) { > > + /* > > + * A nonzero return code from tracehook_report_syscall_entry() > > + * tells us to prevent the syscall execution, but we are not > > + * going to execute it anyway. > > + * > > + * Returning -1 will skip the syscall execution. We want to > > + * avoid clobbering any registers, so we don't goto the skip > > + * label below. > > + */ > > + return -1; > > + } > > > > - if (unlikely(flags & _TIF_SYSCALL_EMU)) { > > - /* > > - * A nonzero return code from > > - * tracehook_report_syscall_entry() tells us to prevent > > - * the syscall execution, but we are not going to > > - * execute it anyway. > > - * > > - * Returning -1 will skip the syscall execution. We want > > - * to avoid clobbering any registers, so we don't goto > > - * the skip label below. > > - */ > > - return -1; > > - } > > + flags = READ_ONCE(current_thread_info()->flags) & _TIF_SYSCALL_TRACE; > > Why do we need READ_ONCE() with this change? > > And now that we change a single bit "flags" doesn't look like a good name. > > Again, to me this patch just makes the code look worse. Honestly, I don't > think that the new (badly named) ptrace_syscall_enter() hook makes any sense. > Worse because we end up reading current_thread_info->flags twice ? -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFACDC43381 for ; Mon, 18 Mar 2019 17:26:50 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C64420854 for ; Mon, 18 Mar 2019 17:26:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C64420854 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44NNQc29chzDqL2 for ; Tue, 19 Mar 2019 04:26:48 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=arm.com (client-ip=217.140.101.70; helo=foss.arm.com; envelope-from=sudeep.holla@arm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=arm.com Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by lists.ozlabs.org (Postfix) with ESMTP id 44NNNg3DKSzDqK5 for ; Tue, 19 Mar 2019 04:25:06 +1100 (AEDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 37CCA1650; Mon, 18 Mar 2019 10:25:03 -0700 (PDT) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 683063F614; Mon, 18 Mar 2019 10:25:00 -0700 (PDT) Date: Mon, 18 Mar 2019 17:24:57 +0000 From: Sudeep Holla To: Oleg Nesterov Subject: Re: [PATCH v2 4/6] powerpc: use common ptrace_syscall_enter hook to handle _TIF_SYSCALL_EMU Message-ID: <20190318172457.GD18196@e107155-lin> References: <20190318104925.16600-1-sudeep.holla@arm.com> <20190318104925.16600-5-sudeep.holla@arm.com> <20190318172024.GB23521@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190318172024.GB23521@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Haibo Xu , Steve Capper , Catalin Marinas , jdike@addtoit.com, x86@kernel.org, Will Deacon , linux-kernel@vger.kernel.org, Bin Lu , Richard Weinberger , Ingo Molnar , Paul Mackerras , Andy Lutomirski , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Mar 18, 2019 at 06:20:24PM +0100, Oleg Nesterov wrote: > On 03/18, Sudeep Holla wrote: > > > > --- a/arch/powerpc/kernel/ptrace.c > > +++ b/arch/powerpc/kernel/ptrace.c > > @@ -3278,35 +3278,29 @@ long do_syscall_trace_enter(struct pt_regs *regs) > > > > user_exit(); > > > > - flags = READ_ONCE(current_thread_info()->flags) & > > - (_TIF_SYSCALL_EMU | _TIF_SYSCALL_TRACE); > > - > > - if (flags) { > > - int rc = tracehook_report_syscall_entry(regs); > > + if (unlikely(ptrace_syscall_enter(regs))) { > > + /* > > + * A nonzero return code from tracehook_report_syscall_entry() > > + * tells us to prevent the syscall execution, but we are not > > + * going to execute it anyway. > > + * > > + * Returning -1 will skip the syscall execution. We want to > > + * avoid clobbering any registers, so we don't goto the skip > > + * label below. > > + */ > > + return -1; > > + } > > > > - if (unlikely(flags & _TIF_SYSCALL_EMU)) { > > - /* > > - * A nonzero return code from > > - * tracehook_report_syscall_entry() tells us to prevent > > - * the syscall execution, but we are not going to > > - * execute it anyway. > > - * > > - * Returning -1 will skip the syscall execution. We want > > - * to avoid clobbering any registers, so we don't goto > > - * the skip label below. > > - */ > > - return -1; > > - } > > + flags = READ_ONCE(current_thread_info()->flags) & _TIF_SYSCALL_TRACE; > > Why do we need READ_ONCE() with this change? > > And now that we change a single bit "flags" doesn't look like a good name. > > Again, to me this patch just makes the code look worse. Honestly, I don't > think that the new (badly named) ptrace_syscall_enter() hook makes any sense. > Worse because we end up reading current_thread_info->flags twice ? -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57030C43381 for ; Mon, 18 Mar 2019 17:25:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A34A20854 for ; Mon, 18 Mar 2019 17:25:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oI09ZGq/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A34A20854 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Jw2UE4tsxo4WognVi2mz1sqftPHLSBc+Dp+TFZS+eaM=; b=oI09ZGq/Wl9VhK 8FkwvMNouPPooHXoAeFx8zYh9pKlAgsmPEtdJBU4so3PiJTBt1juJ/tDIt5gD9mWv9h6v8yUljTbb /mh4S/Z4kWY5CJbM8cXvYfNtddNB77kAVBzW0ROBsTLh7iFcWyZMqP7nXDpQQ2XeQ4FW1LF3Jnk+a dYAS/XggJVZmPKIYLeEeeBmcKbEn1c5tXsw1DvMDv5CZ1pJQnl+5aioqC+RWh0Oo24N2kIAqSE5WC /ucWHFylAEaXlL0eDmMNLtmhtl/KcrNKGs7UgtNqzl4bB2bWYbZuChp5SXO2O7usCmAO/ekNXAo2V EVdh0OgbOncVMwKWwD9g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5w0Z-0001Ar-9T; Mon, 18 Mar 2019 17:25:07 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5w0W-0000XR-2w for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2019 17:25:05 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 37CCA1650; Mon, 18 Mar 2019 10:25:03 -0700 (PDT) Received: from e107155-lin (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 683063F614; Mon, 18 Mar 2019 10:25:00 -0700 (PDT) Date: Mon, 18 Mar 2019 17:24:57 +0000 From: Sudeep Holla To: Oleg Nesterov Subject: Re: [PATCH v2 4/6] powerpc: use common ptrace_syscall_enter hook to handle _TIF_SYSCALL_EMU Message-ID: <20190318172457.GD18196@e107155-lin> References: <20190318104925.16600-1-sudeep.holla@arm.com> <20190318104925.16600-5-sudeep.holla@arm.com> <20190318172024.GB23521@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190318172024.GB23521@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190318_102504_141235_31F77ED0 X-CRM114-Status: GOOD ( 22.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Haibo Xu , Steve Capper , Catalin Marinas , jdike@addtoit.com, x86@kernel.org, Will Deacon , linux-kernel@vger.kernel.org, Bin Lu , Richard Weinberger , Ingo Molnar , Paul Mackerras , Andy Lutomirski , Michael Ellerman , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 18, 2019 at 06:20:24PM +0100, Oleg Nesterov wrote: > On 03/18, Sudeep Holla wrote: > > > > --- a/arch/powerpc/kernel/ptrace.c > > +++ b/arch/powerpc/kernel/ptrace.c > > @@ -3278,35 +3278,29 @@ long do_syscall_trace_enter(struct pt_regs *regs) > > > > user_exit(); > > > > - flags = READ_ONCE(current_thread_info()->flags) & > > - (_TIF_SYSCALL_EMU | _TIF_SYSCALL_TRACE); > > - > > - if (flags) { > > - int rc = tracehook_report_syscall_entry(regs); > > + if (unlikely(ptrace_syscall_enter(regs))) { > > + /* > > + * A nonzero return code from tracehook_report_syscall_entry() > > + * tells us to prevent the syscall execution, but we are not > > + * going to execute it anyway. > > + * > > + * Returning -1 will skip the syscall execution. We want to > > + * avoid clobbering any registers, so we don't goto the skip > > + * label below. > > + */ > > + return -1; > > + } > > > > - if (unlikely(flags & _TIF_SYSCALL_EMU)) { > > - /* > > - * A nonzero return code from > > - * tracehook_report_syscall_entry() tells us to prevent > > - * the syscall execution, but we are not going to > > - * execute it anyway. > > - * > > - * Returning -1 will skip the syscall execution. We want > > - * to avoid clobbering any registers, so we don't goto > > - * the skip label below. > > - */ > > - return -1; > > - } > > + flags = READ_ONCE(current_thread_info()->flags) & _TIF_SYSCALL_TRACE; > > Why do we need READ_ONCE() with this change? > > And now that we change a single bit "flags" doesn't look like a good name. > > Again, to me this patch just makes the code look worse. Honestly, I don't > think that the new (badly named) ptrace_syscall_enter() hook makes any sense. > Worse because we end up reading current_thread_info->flags twice ? -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel