From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bruce Richardson Subject: Re: [PATCH v6 2/4] meson: add infra to support machine specific flags Date: Tue, 19 Mar 2019 09:40:43 +0000 Message-ID: <20190319094043.GA318652@bricha3-MOBL.ger.corp.intel.com> References: <20190224181041.27127-1-jerinj@marvell.com> <20190318164949.2357-1-jerinj@marvell.com> <20190318164949.2357-2-jerinj@marvell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Thomas Monjalon , "dev@dpdk.org" , "gavin.hu@arm.com" , Pavan Nikhilesh Bhagavatula To: Jerin Jacob Kollanukkaran Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C9F0111A4 for ; Tue, 19 Mar 2019 10:40:49 +0100 (CET) Content-Disposition: inline In-Reply-To: <20190318164949.2357-2-jerinj@marvell.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Mar 18, 2019 at 04:50:16PM +0000, Jerin Jacob Kollanukkaran wrote: > From: Pavan Nikhilesh > > Currently, RTE_* flags are set based on the implementer ID but there might > be some micro arch specific differences from the same vendor > eg. CACHE_LINESIZE. Add support to set micro arch specific flags. > > Signed-off-by: Pavan Nikhilesh > Signed-off-by: Jerin Jacob > --- > config/arm/meson.build | 37 ++++++++++++++++++++++++++++++++----- > 1 file changed, 32 insertions(+), 5 deletions(-) > This looks ok to me, but I think review and ack from another Arm vendor would be good to have. /Bruce