From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34546C43381 for ; Tue, 19 Mar 2019 12:18:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F18F213F2 for ; Tue, 19 Mar 2019 12:18:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727727AbfCSMSP (ORCPT ); Tue, 19 Mar 2019 08:18:15 -0400 Received: from foss.arm.com ([217.140.101.70]:50612 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726743AbfCSMSP (ORCPT ); Tue, 19 Mar 2019 08:18:15 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 69DF71596; Tue, 19 Mar 2019 05:18:14 -0700 (PDT) Received: from why.wild-wind.fr.eu.org (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1BF373F59C; Tue, 19 Mar 2019 05:18:12 -0700 (PDT) Date: Tue, 19 Mar 2019 12:18:07 +0000 From: Marc Zyngier To: Heikki Krogerus Cc: Greg Kroah-Hartman , Guenter Roeck , , Subject: Re: [PATCH v2] usb: typec: fusb302: Fix debugfs mutex initialisation Message-ID: <20190319121807.68c858f7@why.wild-wind.fr.eu.org> In-Reply-To: <20190319114511.GS7752@kuha.fi.intel.com> References: <20190318174906.10429-1-marc.zyngier@arm.com> <20190319114511.GS7752@kuha.fi.intel.com> Organization: ARM Ltd X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Mar 2019 13:45:11 +0200 Heikki Krogerus wrote: > On Mon, Mar 18, 2019 at 05:49:06PM +0000, Marc Zyngier wrote: > > Running a kernel with the fusb302 driver and lockdep enabled > > leads to an unpleasant warning: > > > > [ 4.617477] INFO: trying to register non-static key. > > [ 4.617930] the code is fine but needs lockdep annotation. > > [ 4.618418] turning off the locking correctness validator. > > [ 4.618913] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.1.0-rc1-00007-g3542533f3fc9 #13 > > [ 4.619620] Hardware name: rockchip evb_rk3399/evb_rk3399, BIOS 2019.04-rc3-00124-g2feec69fb1 03/15/2019 > > [ 4.620454] Call trace: > > [ 4.620693] dump_backtrace+0x0/0x138 > > [ 4.621028] show_stack+0x24/0x30 > > [ 4.621336] dump_stack+0xbc/0x104 > > [ 4.621649] register_lock_class+0x594/0x598 > > [ 4.622036] __lock_acquire+0x80/0x11b8 > > [ 4.622384] lock_acquire+0xdc/0x260 > > [ 4.622711] __mutex_lock+0x90/0x8a0 > > [ 4.623037] mutex_lock_nested+0x3c/0x50 > > [ 4.623394] _fusb302_log+0x88/0x1f0 > > [ 4.623721] fusb302_log+0x7c/0xa0 > > [ 4.624033] tcpm_init+0x5c/0x190 > > [ 4.624336] tcpm_init+0x3c/0x130 > > [ 4.624640] tcpm_register_port+0x574/0x878 > > [ 4.625019] fusb302_probe+0x2c8/0x590 > > > > Despite what the message says, the code isn't fine, as it tries to > > make use of the fusb302_log facility pretty early. This requires the > > logbuffer_lock mutex to be initialised, but that only happens much > > later. Boo. > > > > Hoist the fusb302_debugfs_init call before tcpm_register_port so that > > we can enjoy a working mutex. At Guenter's request, also add teardown > > of the debugfs facility on the error path. > > > > Signed-off-by: Marc Zyngier > > After applying this there was no more "fusb302" debugfs directory, and > attempt to unload the fusb302 module dead locked. Also, attempt to > reboot caused this to happen on my GDPWin board after applying the > patch: > > BUG: Dentry 0000000012f2a05d{i=149,n=i2c-fusb302} still in use (1) [unmount of sysfs sysfs] > WARNING: CPU: 3 PID: 1639 at fs/dcache.c:1529 umount_check.cold.55+0x2e/0x3a > Modules linked in: intel_xhci_usb_role_switch roles pi3usb30532 typec i915 intel_gtt intel_cht_int33fe [last unloaded: tcpm] > CPU: 3 PID: 1639 Comm: umount Not tainted 5.1.0-rc1-heikki+ #916 > Hardware name: Default string Default string/Default string, BIOS 5.11 05/25/2017 > RIP: 0010:umount_check.cold.55+0x2e/0x3a > ... OK, that's interesting. On my system, I do have the debugfs file: root@city-of-tiny-lites:~# cat /sys/kernel/debug/fusb302/4-0022 [ 4.517682] sw reset [ 4.520379] fusb302 device ID: 0x81 [ 4.523544] pd := off [ 4.523593] vbus is already Off [ 4.523603] charge is already Off [ 4.523615] vconn is already Off [ 4.524274] pd header := Sink, Device [ 4.525948] cc1=Open, cc2=Open [ 4.530345] pd := off [ 4.530378] vbus is already Off [ 4.530388] charge is already Off [ 4.530405] vconn is already Off [ 4.530931] pd header := Sink, Device [ 4.533773] cc := Open [ 4.642347] start drp toggling I don't use any module though, so maybe there is something there. I'll investigate. > Note. Your patch has also a conflict with patches from Hans, I > think with this one: https://patchwork.kernel.org/patch/10847275/ > I can take care of that, but you can also rebase the next version on > top of my typec-next branch to solve that problem: > https://github.com/krohei/linux/commits/typec-next > > I think I need to add that to the MAINTAINERS file. Fair enough. I'll come back once I know what happens here... Thanks, M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] usb: typec: fusb302: Fix debugfs mutex initialisation From: Marc Zyngier Message-Id: <20190319121807.68c858f7@why.wild-wind.fr.eu.org> Date: Tue, 19 Mar 2019 12:18:07 +0000 To: Heikki Krogerus Cc: Greg Kroah-Hartman , Guenter Roeck , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gVHVlLCAxOSBNYXIgMjAxOSAxMzo0NToxMSArMDIwMApIZWlra2kgS3JvZ2VydXMgPGhlaWtr aS5rcm9nZXJ1c0BsaW51eC5pbnRlbC5jb20+IHdyb3RlOgoKPiBPbiBNb24sIE1hciAxOCwgMjAx OSBhdCAwNTo0OTowNlBNICswMDAwLCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4gPiBSdW5uaW5nIGEg a2VybmVsIHdpdGggdGhlIGZ1c2IzMDIgZHJpdmVyIGFuZCBsb2NrZGVwIGVuYWJsZWQKPiA+IGxl YWRzIHRvIGFuIHVucGxlYXNhbnQgd2FybmluZzoKPiA+IAo+ID4gWyAgICA0LjYxNzQ3N10gSU5G TzogdHJ5aW5nIHRvIHJlZ2lzdGVyIG5vbi1zdGF0aWMga2V5Lgo+ID4gWyAgICA0LjYxNzkzMF0g dGhlIGNvZGUgaXMgZmluZSBidXQgbmVlZHMgbG9ja2RlcCBhbm5vdGF0aW9uLgo+ID4gWyAgICA0 LjYxODQxOF0gdHVybmluZyBvZmYgdGhlIGxvY2tpbmcgY29ycmVjdG5lc3MgdmFsaWRhdG9yLgo+ ID4gWyAgICA0LjYxODkxM10gQ1BVOiAwIFBJRDogMSBDb21tOiBzd2FwcGVyLzAgTm90IHRhaW50 ZWQgNS4xLjAtcmMxLTAwMDA3LWczNTQyNTMzZjNmYzkgIzEzCj4gPiBbICAgIDQuNjE5NjIwXSBI YXJkd2FyZSBuYW1lOiByb2NrY2hpcCBldmJfcmszMzk5L2V2Yl9yazMzOTksIEJJT1MgMjAxOS4w NC1yYzMtMDAxMjQtZzJmZWVjNjlmYjEgMDMvMTUvMjAxOQo+ID4gWyAgICA0LjYyMDQ1NF0gQ2Fs bCB0cmFjZToKPiA+IFsgICAgNC42MjA2OTNdICBkdW1wX2JhY2t0cmFjZSsweDAvMHgxMzgKPiA+ IFsgICAgNC42MjEwMjhdICBzaG93X3N0YWNrKzB4MjQvMHgzMAo+ID4gWyAgICA0LjYyMTMzNl0g IGR1bXBfc3RhY2srMHhiYy8weDEwNAo+ID4gWyAgICA0LjYyMTY0OV0gIHJlZ2lzdGVyX2xvY2tf Y2xhc3MrMHg1OTQvMHg1OTgKPiA+IFsgICAgNC42MjIwMzZdICBfX2xvY2tfYWNxdWlyZSsweDgw LzB4MTFiOAo+ID4gWyAgICA0LjYyMjM4NF0gIGxvY2tfYWNxdWlyZSsweGRjLzB4MjYwCj4gPiBb ICAgIDQuNjIyNzExXSAgX19tdXRleF9sb2NrKzB4OTAvMHg4YTAKPiA+IFsgICAgNC42MjMwMzdd ICBtdXRleF9sb2NrX25lc3RlZCsweDNjLzB4NTAKPiA+IFsgICAgNC42MjMzOTRdICBfZnVzYjMw Ml9sb2crMHg4OC8weDFmMAo+ID4gWyAgICA0LjYyMzcyMV0gIGZ1c2IzMDJfbG9nKzB4N2MvMHhh MAo+ID4gWyAgICA0LjYyNDAzM10gIHRjcG1faW5pdCsweDVjLzB4MTkwCj4gPiBbICAgIDQuNjI0 MzM2XSAgdGNwbV9pbml0KzB4M2MvMHgxMzAKPiA+IFsgICAgNC42MjQ2NDBdICB0Y3BtX3JlZ2lz dGVyX3BvcnQrMHg1NzQvMHg4NzgKPiA+IFsgICAgNC42MjUwMTldICBmdXNiMzAyX3Byb2JlKzB4 MmM4LzB4NTkwCj4gPiAKPiA+IERlc3BpdGUgd2hhdCB0aGUgbWVzc2FnZSBzYXlzLCB0aGUgY29k ZSBpc24ndCBmaW5lLCBhcyBpdCB0cmllcyB0bwo+ID4gbWFrZSB1c2Ugb2YgdGhlIGZ1c2IzMDJf bG9nIGZhY2lsaXR5IHByZXR0eSBlYXJseS4gVGhpcyByZXF1aXJlcyB0aGUKPiA+IGxvZ2J1ZmZl cl9sb2NrIG11dGV4IHRvIGJlIGluaXRpYWxpc2VkLCBidXQgdGhhdCBvbmx5IGhhcHBlbnMgbXVj aAo+ID4gbGF0ZXIuIEJvby4KPiA+IAo+ID4gSG9pc3QgdGhlIGZ1c2IzMDJfZGVidWdmc19pbml0 IGNhbGwgYmVmb3JlIHRjcG1fcmVnaXN0ZXJfcG9ydCBzbyB0aGF0Cj4gPiB3ZSBjYW4gZW5qb3kg YSB3b3JraW5nIG11dGV4LiBBdCBHdWVudGVyJ3MgcmVxdWVzdCwgYWxzbyBhZGQgdGVhcmRvd24K PiA+IG9mIHRoZSBkZWJ1Z2ZzIGZhY2lsaXR5IG9uIHRoZSBlcnJvciBwYXRoLgo+ID4gCj4gPiBT aWduZWQtb2ZmLWJ5OiBNYXJjIFp5bmdpZXIgPG1hcmMuenluZ2llckBhcm0uY29tPiAgCj4gCj4g QWZ0ZXIgYXBwbHlpbmcgdGhpcyB0aGVyZSB3YXMgbm8gbW9yZSAiZnVzYjMwMiIgZGVidWdmcyBk aXJlY3RvcnksIGFuZAo+IGF0dGVtcHQgdG8gdW5sb2FkIHRoZSBmdXNiMzAyIG1vZHVsZSBkZWFk IGxvY2tlZC4gQWxzbywgYXR0ZW1wdCB0bwo+IHJlYm9vdCBjYXVzZWQgdGhpcyB0byBoYXBwZW4g b24gbXkgR0RQV2luIGJvYXJkIGFmdGVyIGFwcGx5aW5nIHRoZQo+IHBhdGNoOgo+IAo+ICAgICAg ICAgQlVHOiBEZW50cnkgMDAwMDAwMDAxMmYyYTA1ZHtpPTE0OSxuPWkyYy1mdXNiMzAyfSAgc3Rp bGwgaW4gdXNlICgxKSBbdW5tb3VudCBvZiBzeXNmcyBzeXNmc10KPiAgICAgICAgIFdBUk5JTkc6 IENQVTogMyBQSUQ6IDE2MzkgYXQgZnMvZGNhY2hlLmM6MTUyOSB1bW91bnRfY2hlY2suY29sZC41 NSsweDJlLzB4M2EKPiAgICAgICAgIE1vZHVsZXMgbGlua2VkIGluOiBpbnRlbF94aGNpX3VzYl9y b2xlX3N3aXRjaCByb2xlcyBwaTN1c2IzMDUzMiB0eXBlYyBpOTE1IGludGVsX2d0dCBpbnRlbF9j aHRfaW50MzNmZSBbbGFzdCB1bmxvYWRlZDogdGNwbV0KPiAgICAgICAgIENQVTogMyBQSUQ6IDE2 MzkgQ29tbTogdW1vdW50IE5vdCB0YWludGVkIDUuMS4wLXJjMS1oZWlra2krICM5MTYKPiAgICAg ICAgIEhhcmR3YXJlIG5hbWU6IERlZmF1bHQgc3RyaW5nIERlZmF1bHQgc3RyaW5nL0RlZmF1bHQg c3RyaW5nLCBCSU9TIDUuMTEgMDUvMjUvMjAxNwo+ICAgICAgICAgUklQOiAwMDEwOnVtb3VudF9j aGVjay5jb2xkLjU1KzB4MmUvMHgzYQo+ICAgICAgICAgLi4uCgpPSywgdGhhdCdzIGludGVyZXN0 aW5nLiBPbiBteSBzeXN0ZW0sIEkgZG8gaGF2ZSB0aGUgZGVidWdmcyBmaWxlOgoKcm9vdEBjaXR5 LW9mLXRpbnktbGl0ZXM6fiMgY2F0IC9zeXMva2VybmVsL2RlYnVnL2Z1c2IzMDIvNC0wMDIyIApb ICAgIDQuNTE3NjgyXSBzdyByZXNldApbICAgIDQuNTIwMzc5XSBmdXNiMzAyIGRldmljZSBJRDog MHg4MQpbICAgIDQuNTIzNTQ0XSBwZCA6PSBvZmYKWyAgICA0LjUyMzU5M10gdmJ1cyBpcyBhbHJl YWR5IE9mZgpbICAgIDQuNTIzNjAzXSBjaGFyZ2UgaXMgYWxyZWFkeSBPZmYKWyAgICA0LjUyMzYx NV0gdmNvbm4gaXMgYWxyZWFkeSBPZmYKWyAgICA0LjUyNDI3NF0gcGQgaGVhZGVyIDo9IFNpbmss IERldmljZQpbICAgIDQuNTI1OTQ4XSBjYzE9T3BlbiwgY2MyPU9wZW4KWyAgICA0LjUzMDM0NV0g cGQgOj0gb2ZmClsgICAgNC41MzAzNzhdIHZidXMgaXMgYWxyZWFkeSBPZmYKWyAgICA0LjUzMDM4 OF0gY2hhcmdlIGlzIGFscmVhZHkgT2ZmClsgICAgNC41MzA0MDVdIHZjb25uIGlzIGFscmVhZHkg T2ZmClsgICAgNC41MzA5MzFdIHBkIGhlYWRlciA6PSBTaW5rLCBEZXZpY2UKWyAgICA0LjUzMzc3 M10gY2MgOj0gT3BlbgpbICAgIDQuNjQyMzQ3XSBzdGFydCBkcnAgdG9nZ2xpbmcKCkkgZG9uJ3Qg dXNlIGFueSBtb2R1bGUgdGhvdWdoLCBzbyBtYXliZSB0aGVyZSBpcyBzb21ldGhpbmcgdGhlcmUu IEknbGwKaW52ZXN0aWdhdGUuCiAKPiBOb3RlLiBZb3VyIHBhdGNoIGhhcyBhbHNvIGEgY29uZmxp Y3Qgd2l0aCBwYXRjaGVzIGZyb20gSGFucywgSQo+IHRoaW5rIHdpdGggdGhpcyBvbmU6IGh0dHBz Oi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcGF0Y2gvMTA4NDcyNzUvCj4gSSBjYW4gdGFrZSBjYXJl IG9mIHRoYXQsIGJ1dCB5b3UgY2FuIGFsc28gcmViYXNlIHRoZSBuZXh0IHZlcnNpb24gb24KPiB0 b3Agb2YgbXkgdHlwZWMtbmV4dCBicmFuY2ggdG8gc29sdmUgdGhhdCBwcm9ibGVtOgo+IGh0dHBz Oi8vZ2l0aHViLmNvbS9rcm9oZWkvbGludXgvY29tbWl0cy90eXBlYy1uZXh0Cj4gCj4gSSB0aGlu ayBJIG5lZWQgdG8gYWRkIHRoYXQgdG8gdGhlIE1BSU5UQUlORVJTIGZpbGUuCgpGYWlyIGVub3Vn aC4gSSdsbCBjb21lIGJhY2sgb25jZSBJIGtub3cgd2hhdCBoYXBwZW5zIGhlcmUuLi4KClRoYW5r cywKCglNLgo=