From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0246C4360F for ; Tue, 19 Mar 2019 15:43:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B19BF2083D for ; Tue, 19 Mar 2019 15:43:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727270AbfCSPna (ORCPT ); Tue, 19 Mar 2019 11:43:30 -0400 Received: from foss.arm.com ([217.140.101.70]:54112 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726466AbfCSPna (ORCPT ); Tue, 19 Mar 2019 11:43:30 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 871CA1650; Tue, 19 Mar 2019 08:43:29 -0700 (PDT) Received: from e107981-ln.cambridge.arm.com (e107981-ln.cambridge.arm.com [10.1.197.40]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9A5A03F614; Tue, 19 Mar 2019 08:43:28 -0700 (PDT) Date: Tue, 19 Mar 2019 15:43:22 +0000 From: Lorenzo Pieralisi To: Jean-Jacques Hiblot , kishon@ti.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools: PCI: exit with error code when test fails Message-ID: <20190319154322.GA12647@e107981-ln.cambridge.arm.com> References: <1537455773-13470-1-git-send-email-jjhiblot@ti.com> <20181004111144.GC5233@e107981-ln.cambridge.arm.com> <20181116120113.GB3228@e107981-ln.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181116120113.GB3228@e107981-ln.cambridge.arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 16, 2018 at 12:01:13PM +0000, Lorenzo Pieralisi wrote: > On Thu, Oct 04, 2018 at 12:11:44PM +0100, Lorenzo Pieralisi wrote: > > On Thu, Sep 20, 2018 at 05:02:53PM +0200, Jean-Jacques Hiblot wrote: > > > This makes it easier to use pcitest in automated setups. > > > > > > Signed-off-by: Jean-Jacques Hiblot > > > --- > > > tools/pci/pcitest.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c > > > index af146bb..5adc8cd 100644 > > > --- a/tools/pci/pcitest.c > > > +++ b/tools/pci/pcitest.c > > > @@ -143,6 +143,7 @@ static int run_test(struct pci_test *test) > > > } > > > > > > fflush(stdout); > > > + return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */ > > > } > > > > > > int main(int argc, char **argv) > > > @@ -231,6 +232,5 @@ int main(int argc, char **argv) > > > return -EINVAL; > > > } > > > > > > - run_test(test); > > > - return 0; > > > + return run_test(test); > > > } > > > -- > > > 2.7.4 > > > > > > > Hi Kishon, > > > > are you OK with this patch ? Please let me know. > > Please let me know, I need your ACK on this to queue it. Hi Kishon, I will merge this patch unless you have something against it, please let me know. Thanks, Lorenzo