All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] v2 Check for SKBTX_HW_TSTAMP in macb driver
@ 2019-03-19 17:04 Paul Thomas
  2019-03-19 17:41 ` Paul Thomas
                   ` (2 more replies)
  0 siblings, 3 replies; 8+ messages in thread
From: Paul Thomas @ 2019-03-19 17:04 UTC (permalink / raw)
  To: netdev; +Cc: Paul Thomas

Make sure SKBTX_HW_TSTAMP (i.e. SOF_TIMESTAMPING_TX_HARDWARE) has been
enabled for this skb It does fix the issue where normal socks that
aren't expecting a timestamp will not wake up on select. And when a
user does want a SOF_TIMESTAMPING_TX_HARDWARE this does work.

Signed-off-by: Paul Thomas <pthomas8589@gmail.com>
---
 drivers/net/ethernet/cadence/macb_main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index ad099fd01b45..48fc45ab514f 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -898,7 +898,8 @@ static void macb_tx_interrupt(struct macb_queue *queue)
 
 			/* First, update TX stats if needed */
 			if (skb) {
-				if (gem_ptp_do_txstamp(queue, skb, desc) == 0) {
+				if (unlikely(skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP) &&
+					gem_ptp_do_txstamp(queue, skb, desc) == 0) {
 					/* skb now belongs to timestamp buffer
 					 * and will be removed later
 					 */
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2019-04-04 13:52 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 17:04 [PATCH] v2 Check for SKBTX_HW_TSTAMP in macb driver Paul Thomas
2019-03-19 17:41 ` Paul Thomas
2019-03-20  6:15   ` Harini Katakam
2019-03-20 17:48 ` David Miller
2019-04-04 13:03 ` Paul Thomas
2019-04-04 13:16   ` Harini Katakam
2019-04-04 13:23     ` Paul Thomas
2019-04-04 13:52       ` Paul Thomas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.