From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v7 3/4] drm/i915: Remove redundant store of logical CDCLK state
Date: Tue, 19 Mar 2019 20:47:57 +0200 [thread overview]
Message-ID: <20190319184757.GH3888@intel.com> (raw)
In-Reply-To: <20190319183618.22162-4-imre.deak@intel.com>
On Tue, Mar 19, 2019 at 08:36:17PM +0200, Imre Deak wrote:
> We copied the original state into the atomic state already earlier in
> the function, so no need to do it a second time.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
The rest looks ok to me as well.
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 9c4ad124302c..f7b44773e1e7 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13031,8 +13031,6 @@ static int intel_modeset_checks(struct drm_atomic_state *state)
> DRM_DEBUG_KMS("New voltage level calculated to be logical %u, actual %u\n",
> intel_state->cdclk.logical.voltage_level,
> intel_state->cdclk.actual.voltage_level);
> - } else {
> - to_intel_atomic_state(state)->cdclk.logical = dev_priv->cdclk.logical;
> }
>
> intel_modeset_clear_plls(state);
> --
> 2.13.2
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-19 18:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 18:36 [PATCH v7 0/4] drm/i915: Ensure minimum CDCLK requirement for audio Imre Deak
2019-03-19 18:36 ` [PATCH v7 1/4] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled Imre Deak
2019-03-19 18:36 ` [PATCH v7 2/4] drm/i915: Save the old CDCLK atomic state Imre Deak
2019-03-19 18:51 ` Ville Syrjälä
2019-03-19 19:16 ` Imre Deak
2019-03-20 9:18 ` [PATCH v8 " Imre Deak
2019-03-19 18:36 ` [PATCH v7 3/4] drm/i915: Remove redundant store of logical CDCLK state Imre Deak
2019-03-19 18:47 ` Ville Syrjälä [this message]
2019-03-19 18:36 ` [PATCH v7 4/4] drm/i915: Skip modeset for cdclk changes if possible Imre Deak
2019-03-20 9:18 ` [PATCH v8 " Imre Deak
2019-03-20 10:12 ` [PATCH v7 " kbuild test robot
2019-03-19 19:20 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Ensure minimum CDCLK requirement for audio (rev2) Patchwork
2019-03-19 19:42 ` ✓ Fi.CI.BAT: success " Patchwork
2019-03-20 6:56 ` ✓ Fi.CI.IGT: " Patchwork
2019-03-20 13:26 ` ✗ Fi.CI.BAT: failure for drm/i915: Ensure minimum CDCLK requirement for audio (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319184757.GH3888@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.