From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, URIBL_SBL,URIBL_SBL_A,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 910E1C10F03 for ; Tue, 19 Mar 2019 22:15:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6634B2175B for ; Tue, 19 Mar 2019 22:15:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727210AbfCSWPG (ORCPT ); Tue, 19 Mar 2019 18:15:06 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:41392 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726908AbfCSWPG (ORCPT ); Tue, 19 Mar 2019 18:15:06 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 7E49580328; Tue, 19 Mar 2019 23:14:54 +0100 (CET) Date: Tue, 19 Mar 2019 23:15:01 +0100 From: Pavel Machek To: Matthew Garrett Cc: jmorris@namei.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, dhowells@redhat.com Subject: Re: [PATCH 09/27] hibernate: Disable when the kernel is locked down Message-ID: <20190319221501.GA31551@amd> References: <20190228231203.212359-1-matthewgarrett@google.com> <20190228231203.212359-9-matthewgarrett@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="k1lZvvs/B4yU6o8G" Content-Disposition: inline In-Reply-To: <20190228231203.212359-9-matthewgarrett@google.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --k1lZvvs/B4yU6o8G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu 2019-02-28 15:11:45, Matthew Garrett wrote: > From: Josh Boyer >=20 > There is currently no way to verify the resume image when returning > from hibernate. This might compromise the signed modules trust model, > so until we can work with signed hibernate images we disable it when the > kernel is locked down. >=20 > Signed-off-by: Josh Boyer > Signed-off-by: David Howells > Reviewed-by: "Lee, Chun-Yi" > cc: linux-pm@vger.kernel.org It would be good to cc hibernation maintainers here. > --- > kernel/power/hibernate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c > index abef759de7c8..802795becb88 100644 > --- a/kernel/power/hibernate.c > +++ b/kernel/power/hibernate.c > @@ -70,7 +70,7 @@ static const struct platform_hibernation_ops *hibernati= on_ops; > =20 > bool hibernation_available(void) > { > - return (nohibernate =3D=3D 0); > + return nohibernate =3D=3D 0 && !kernel_is_locked_down("Hibernation"); > } > =20 > /** --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --k1lZvvs/B4yU6o8G Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlyRaeUACgkQMOfwapXb+vIrUgCePR4ZNP1PZ7BgmovegoMQ5dqX iY0An36y/i6DyGJVSq+OnY+TW+3rjpmC =0rTS -----END PGP SIGNATURE----- --k1lZvvs/B4yU6o8G--