From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E550C43381 for ; Wed, 20 Mar 2019 23:29:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 17535218B0 for ; Wed, 20 Mar 2019 23:29:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727573AbfCTX3H (ORCPT ); Wed, 20 Mar 2019 19:29:07 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:41338 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726487AbfCTX3H (ORCPT ); Wed, 20 Mar 2019 19:29:07 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D8582108F87A5; Wed, 20 Mar 2019 16:29:06 -0700 (PDT) Date: Wed, 20 Mar 2019 16:29:03 -0700 (PDT) Message-Id: <20190320.162903.998898758592076249.davem@davemloft.net> To: ruxandra.radulescu@nxp.com Cc: netdev@vger.kernel.org, ioana.ciornei@nxp.com, brouer@redhat.com Subject: Re: [PATCH net] dpaa2-eth: Fix possible access beyond end of array From: David Miller In-Reply-To: <1553091059-15991-1-git-send-email-ruxandra.radulescu@nxp.com> References: <1553091059-15991-1-git-send-email-ruxandra.radulescu@nxp.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 20 Mar 2019 16:29:07 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ioana Ciocoi Radulescu Date: Wed, 20 Mar 2019 14:11:04 +0000 > Make sure we don't try to enqueue XDP_REDIRECT frames to an > inexistent FQ. > > While it is guaranteed not to have more than one queue per core, > having fewer queues than CPUs on an interface is a valid > configuration. > > Fixes: d678be1dc1ec ("dpaa2-eth: add XDP_REDIRECT support") > Reported-by: Jesper Dangaard Brouer > Signed-off-by: Ioana Radulescu Applied, thanks. I hope the modulus operation doesn't start showing up on profiles.