From: Daniel Thompson <daniel.thompson@linaro.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Jason Wessel <jason.wessel@windriver.com>,
kgdb-bugreport@lists.sourceforge.net,
Brian Norris <briannorris@chromium.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/3] tracing: kdb: Allow ftdump to skip all but the last few entries
Date: Wed, 20 Mar 2019 10:50:28 +0000 [thread overview]
Message-ID: <20190320105028.6t6urpf344mljb2g@holly.lan> (raw)
In-Reply-To: <20190319171206.97107-3-dianders@chromium.org>
On Tue, Mar 19, 2019 at 10:12:06AM -0700, Douglas Anderson wrote:
> The 'ftdump' command in kdb is currently a bit of a last resort, at
> least if you have lots of traces turned on. It's going to print a
> whole boatload of data out your serial port which is probably running
> at 115200. This could easily take many, many minutes.
>
> Usually you're most interested in what's at the _end_ of the ftrace
> buffer, AKA what happened most recently. That means you've got to
> wait the full time for the dump. The 'ftdump' command does attempt to
> help you a little bit by allowing you to skip a fixed number of
> entries. Unfortunately it provides no way for you to know how many
> entries you should skip.
>
> Let's do similar to python and allow you to use a negative number to
> indicate that you want to skip all entries except the last few. This
> allows you to quickly see what you want.
>
> Note that we also change the printout in ftdump to print the
> (positive) number of entries actually skipped since that could be
> helpful to know when you've specified a negative skip count.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> Changes in v6:
> - Keep tracing disabled between counting and dumping.
> - Remove Daniel Thompson Ack due to changes between v5 and v6.
... and I'm very happy to replace it:
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
next prev parent reply other threads:[~2019-03-20 10:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 17:12 [PATCH v6 1/3] tracing: kdb: The skip_lines parameter should have been skip_entries Douglas Anderson
2019-03-19 17:12 ` [PATCH v6 2/3] tracing: Add trace_total_entries() / trace_total_entries_cpu() Douglas Anderson
2019-03-19 17:12 ` [PATCH v6 3/3] tracing: kdb: Allow ftdump to skip all but the last few entries Douglas Anderson
2019-03-20 10:50 ` Daniel Thompson [this message]
2019-04-26 22:26 ` [PATCH v6 1/3] tracing: kdb: The skip_lines parameter should have been skip_entries Doug Anderson
2019-04-27 1:32 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320105028.6t6urpf344mljb2g@holly.lan \
--to=daniel.thompson@linaro.org \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=jason.wessel@windriver.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.