From: Steve Twiss <stwiss.opensource@diasemi.com> To: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com> Cc: DEVICETREE <devicetree@vger.kernel.org>, LINUX-ARM-KERNEL <linux-arm-kernel@lists.infradead.org>, LKML <linux-kernel@vger.kernel.org>, Dialog Opensource Support <support.opensource@diasemi.com> Subject: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id Date: Wed, 20 Mar 2019 11:03:50 +0000 [thread overview] Message-ID: <20190320120604.7D99B3FBE9@swsrvapps-01.diasemi.com> (raw) The PHY used on the Freescale i.MX6Q/DL SABRE boards is qualified as 'rgmii' instead of 'rgmii-id'. Meaning the RX and TX delays that were previously added by the MAC when required, but are now provided internally by the PHY (and the MAC should no longer add the RX or TX delays in this case). This patch fixes the network problems seen on the Freescale i.MX6Q/DL SABRE boards and makes a difference when correctly loading the NFS rootfs on startup. Link: https://lkml.kernel.org/r/1397569821-5530-4-git-send-email-thomas.petazzoni@free-electrons.com Tested-by: Steve Twiss <stwiss.opensource@diasemi.com> Tested-by: Adam Thomson <Adam.Thomson@diasemi.com> Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com> --- arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi index a070506..185fb17 100644 --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi @@ -202,7 +202,7 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; status = "okay"; }; -- 1.9.3
WARNING: multiple messages have this Message-ID (diff)
From: Steve Twiss <stwiss.opensource@diasemi.com> To: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com> Cc: DEVICETREE <devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, LINUX-ARM-KERNEL <linux-arm-kernel@lists.infradead.org>, Dialog Opensource Support <support.opensource@diasemi.com> Subject: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id Date: Wed, 20 Mar 2019 11:03:50 +0000 [thread overview] Message-ID: <20190320120604.7D99B3FBE9@swsrvapps-01.diasemi.com> (raw) The PHY used on the Freescale i.MX6Q/DL SABRE boards is qualified as 'rgmii' instead of 'rgmii-id'. Meaning the RX and TX delays that were previously added by the MAC when required, but are now provided internally by the PHY (and the MAC should no longer add the RX or TX delays in this case). This patch fixes the network problems seen on the Freescale i.MX6Q/DL SABRE boards and makes a difference when correctly loading the NFS rootfs on startup. Link: https://lkml.kernel.org/r/1397569821-5530-4-git-send-email-thomas.petazzoni@free-electrons.com Tested-by: Steve Twiss <stwiss.opensource@diasemi.com> Tested-by: Adam Thomson <Adam.Thomson@diasemi.com> Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com> --- arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi index a070506..185fb17 100644 --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi @@ -202,7 +202,7 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>; status = "okay"; }; -- 1.9.3 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-03-20 12:06 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-20 11:03 Steve Twiss [this message] 2019-03-20 11:03 ` [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id Steve Twiss 2019-03-20 12:16 ` Fabio Estevam 2019-03-20 12:16 ` Fabio Estevam 2019-03-20 16:03 ` Steve Twiss 2019-03-20 16:03 ` Steve Twiss 2019-03-20 17:04 ` Fabio Estevam 2019-03-20 17:04 ` Fabio Estevam 2019-03-21 8:42 ` Abel Vesa 2019-03-21 8:42 ` Abel Vesa 2019-03-21 11:17 ` Fabio Estevam 2019-03-21 11:17 ` Fabio Estevam 2019-03-21 11:32 ` Steve Twiss 2019-03-21 11:32 ` Steve Twiss 2019-03-21 11:50 ` Andrew Lunn 2019-03-21 11:50 ` Andrew Lunn 2019-03-21 11:45 ` Andrew Lunn 2019-03-21 11:45 ` Andrew Lunn 2019-03-21 12:43 ` Lucas Stach 2019-03-21 12:43 ` Lucas Stach 2019-03-22 1:11 ` Shawn Guo 2019-03-22 1:11 ` Shawn Guo 2019-03-22 2:00 ` Fabio Estevam 2019-03-22 2:00 ` Fabio Estevam 2019-03-22 2:15 ` Shawn Guo 2019-03-22 2:15 ` Shawn Guo 2019-03-22 2:24 ` Fabio Estevam 2019-03-22 2:24 ` Fabio Estevam 2019-03-22 10:20 ` Michal Vokáč 2019-03-22 10:20 ` Michal Vokáč 2019-03-22 10:50 ` Steve Twiss 2019-03-22 10:50 ` Steve Twiss 2019-03-22 10:50 ` Steve Twiss 2019-03-22 10:59 ` Andrew Lunn 2019-03-22 10:59 ` Andrew Lunn
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190320120604.7D99B3FBE9@swsrvapps-01.diasemi.com \ --to=stwiss.opensource@diasemi.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=support.opensource@diasemi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.