All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [PATCH] public/io/blkif.h: make the comments on "sectors" self-consistent
Date: Wed, 20 Mar 2019 09:53:25 -0400	[thread overview]
Message-ID: <20190320135325.GA6302@char.us.oracle.com> (raw)
In-Reply-To: <20190320125228.36440-1-paul.durrant@citrix.com>

On Wed, Mar 20, 2019 at 12:52:28PM +0000, Paul Durrant wrote:
> Currently the comment at line #267 claims that the value should be
> expressed in number logical sectors, whereas the comment at line #613
> states that the value should be expressed strictly in units of 512 bytes.
> 
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> ---
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> Looking at xen-blkfront in Linux, I'm also not convinced that it would
> function correctly is sector-size != 512 anyway so I wonder whether this
> patch should go further and define that sector-size is strictly 512.

I thought it actually did work with a CD-ROM backed ISO using blkfront?

> ---
>  xen/include/public/io/blkif.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h
> index 15a71e3fea..d7c904d9dc 100644
> --- a/xen/include/public/io/blkif.h
> +++ b/xen/include/public/io/blkif.h
> @@ -264,8 +264,7 @@
>   * sectors
>   *      Values:         <uint64_t>
>   *
> - *      The size of the backend device, expressed in units of its logical
> - *      sector size ("sector-size").
> + *      The size of the backend device, expressed in units of 512 bytes.
>   *
>   *****************************************************************************
>   *                            Frontend XenBus Nodes
> -- 
> 2.20.1.2.gb21ebb671
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-03-20 13:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20 12:52 [PATCH] public/io/blkif.h: make the comments on "sectors" self-consistent Paul Durrant
2019-03-20 13:53 ` Konrad Rzeszutek Wilk [this message]
2019-03-20 13:59   ` Paul Durrant
2019-03-20 14:05     ` Paul Durrant
2019-03-20 14:28       ` Konrad Rzeszutek Wilk
2019-03-20 14:38         ` Paul Durrant
2019-03-21 12:22 ` Anthony PERARD
2019-03-21 12:30   ` Paul Durrant
2019-03-21 15:23     ` Anthony PERARD
2019-03-21 15:39       ` Paul Durrant
2019-03-21 17:23         ` Anthony PERARD
2019-03-21 18:01           ` Paul Durrant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190320135325.GA6302@char.us.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=paul.durrant@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.