From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 01/10] drm/i915: Extract check_luts() Date: Wed, 20 Mar 2019 16:46:11 +0200 Message-ID: <20190320144611.GN3888@intel.com> References: <20190318161317.30918-1-ville.syrjala@linux.intel.com> <20190318161317.30918-2-ville.syrjala@linux.intel.com> <87ftrig7cg.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0548589791 for ; Wed, 20 Mar 2019 14:46:14 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87ftrig7cg.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXIgMTksIDIwMTkgYXQgMDY6MjQ6NDdQTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gTW9uLCAxOCBNYXIgMjAxOSwgVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+Cj4gPiBJbiBwcmVwYXJ0aW9uIGZvciBwZXItcGxh dGZvcm0gY29sb3JfY2hlY2soKSBmdW5jdGlvbnMgZXh0cmFjdCB0aGUKPiA+IGNvbW1vbiBjb2Rl IGludG8gYSBzZXBhcmF0ZSBmdW5jdGlvbi4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBT eXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29sb3IuYyB8IDY4ICsrKysrKysrKysrKysrKysrKy0t LS0tLS0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA0MCBpbnNlcnRpb25zKCspLCAyOCBkZWxl dGlvbnMoLSkKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf Y29sb3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMKPiA+IGluZGV4IDQ2 N2ZkMWExNjMwYy4uYjZhOTkyYTViMTRmIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfY29sb3IuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf Y29sb3IuYwo+ID4gQEAgLTc3MSw2ICs3NzEsMzggQEAgc3RhdGljIGludCBjaGVja19sdXRfc2l6 ZShjb25zdCBzdHJ1Y3QgZHJtX3Byb3BlcnR5X2Jsb2IgKmx1dCwgaW50IGV4cGVjdGVkKQo+ID4g IAlyZXR1cm4gMDsKPiA+ICB9Cj4gPiAgCj4gPiArc3RhdGljIGludCBjaGVja19sdXRzKGNvbnN0 IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+IAo+IGx1dHNfY2hlY2soKSB0 byBiZSBtb3JlIGluIGxpbmUgd2l0aCBvdGhlciBfY29tbWl0IGFuZCBfY2hlY2sgZnVuY3Rpb25z PwoKU2hydWcuIEZvciBzb21lIHJlYXNvbiBjaGVja19sdXRzKCkgZmVlbHMgbW9yZSBuYXR1cmFs IHRvIG1lLgoKPiAKPiBCUiwKPiBKYW5pLgo+IAo+ID4gK3sKPiA+ICsJc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShjcnRjX3N0YXRlLT5iYXNlLmNydGMtPmRldik7 Cj4gPiArCWNvbnN0IHN0cnVjdCBkcm1fcHJvcGVydHlfYmxvYiAqZ2FtbWFfbHV0ID0gY3J0Y19z dGF0ZS0+YmFzZS5nYW1tYV9sdXQ7Cj4gPiArCWNvbnN0IHN0cnVjdCBkcm1fcHJvcGVydHlfYmxv YiAqZGVnYW1tYV9sdXQgPSBjcnRjX3N0YXRlLT5iYXNlLmRlZ2FtbWFfbHV0Owo+ID4gKwlpbnQg Z2FtbWFfbGVuZ3RoLCBkZWdhbW1hX2xlbmd0aDsKPiA+ICsJdTMyIGdhbW1hX3Rlc3RzLCBkZWdh bW1hX3Rlc3RzOwo+ID4gKwo+ID4gKwkvKiBBbHdheXMgYWxsb3cgbGVnYWN5IGdhbW1hIExVVCB3 aXRoIG5vIGZ1cnRoZXIgY2hlY2tpbmcuICovCj4gPiArCWlmIChjcnRjX3N0YXRlX2lzX2xlZ2Fj eV9nYW1tYShjcnRjX3N0YXRlKSkKPiA+ICsJCXJldHVybiAwOwo+ID4gKwo+ID4gKwkvKiBDOCBu ZWVkcyB0aGUgbGVnYWN5IExVVCBhbGwgdG8gaXRzZWxmICovCj4gPiArCWlmIChjcnRjX3N0YXRl LT5jOF9wbGFuZXMpCj4gPiArCQlyZXR1cm4gLUVJTlZBTDsKPiA+ICsKPiA+ICsJZGVnYW1tYV9s ZW5ndGggPSBJTlRFTF9JTkZPKGRldl9wcml2KS0+Y29sb3IuZGVnYW1tYV9sdXRfc2l6ZTsKPiA+ ICsJZ2FtbWFfbGVuZ3RoID0gSU5URUxfSU5GTyhkZXZfcHJpdiktPmNvbG9yLmdhbW1hX2x1dF9z aXplOwo+ID4gKwlkZWdhbW1hX3Rlc3RzID0gSU5URUxfSU5GTyhkZXZfcHJpdiktPmNvbG9yLmRl Z2FtbWFfbHV0X3Rlc3RzOwo+ID4gKwlnYW1tYV90ZXN0cyA9IElOVEVMX0lORk8oZGV2X3ByaXYp LT5jb2xvci5nYW1tYV9sdXRfdGVzdHM7Cj4gPiArCj4gPiArCWlmIChjaGVja19sdXRfc2l6ZShk ZWdhbW1hX2x1dCwgZGVnYW1tYV9sZW5ndGgpIHx8Cj4gPiArCSAgICBjaGVja19sdXRfc2l6ZShn YW1tYV9sdXQsIGdhbW1hX2xlbmd0aCkpCj4gPiArCQlyZXR1cm4gLUVJTlZBTDsKPiA+ICsKPiA+ ICsJaWYgKGRybV9jb2xvcl9sdXRfY2hlY2soZGVnYW1tYV9sdXQsIGRlZ2FtbWFfdGVzdHMpIHx8 Cj4gPiArCSAgICBkcm1fY29sb3JfbHV0X2NoZWNrKGdhbW1hX2x1dCwgZ2FtbWFfdGVzdHMpKQo+ ID4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gPiArCj4gPiArCXJldHVybiAwOwo+ID4gK30KPiA+ICsK PiA+ICBzdGF0aWMgdTMyIGNodl9jZ21fbW9kZShjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0 ZSAqY3J0Y19zdGF0ZSkKPiA+ICB7Cj4gPiAgCXUzMiBjZ21fbW9kZSA9IDA7Cj4gPiBAQCAtNzk0 LDE5ICs4MjYsMTEgQEAgaW50IGludGVsX2NvbG9yX2NoZWNrKHN0cnVjdCBpbnRlbF9jcnRjX3N0 YXRlICpjcnRjX3N0YXRlKQo+ID4gIAljb25zdCBzdHJ1Y3QgZHJtX3Byb3BlcnR5X2Jsb2IgKmdh bW1hX2x1dCA9IGNydGNfc3RhdGUtPmJhc2UuZ2FtbWFfbHV0Owo+ID4gIAljb25zdCBzdHJ1Y3Qg ZHJtX3Byb3BlcnR5X2Jsb2IgKmRlZ2FtbWFfbHV0ID0gY3J0Y19zdGF0ZS0+YmFzZS5kZWdhbW1h X2x1dDsKPiA+ICAJYm9vbCBsaW1pdGVkX2NvbG9yX3JhbmdlID0gZmFsc2U7Cj4gPiAtCWludCBn YW1tYV9sZW5ndGgsIGRlZ2FtbWFfbGVuZ3RoOwo+ID4gLQl1MzIgZ2FtbWFfdGVzdHMsIGRlZ2Ft bWFfdGVzdHM7Cj4gPiAgCWludCByZXQ7Cj4gPiAgCj4gPiAtCWRlZ2FtbWFfbGVuZ3RoID0gSU5U RUxfSU5GTyhkZXZfcHJpdiktPmNvbG9yLmRlZ2FtbWFfbHV0X3NpemU7Cj4gPiAtCWdhbW1hX2xl bmd0aCA9IElOVEVMX0lORk8oZGV2X3ByaXYpLT5jb2xvci5nYW1tYV9sdXRfc2l6ZTsKPiA+IC0J ZGVnYW1tYV90ZXN0cyA9IElOVEVMX0lORk8oZGV2X3ByaXYpLT5jb2xvci5kZWdhbW1hX2x1dF90 ZXN0czsKPiA+IC0JZ2FtbWFfdGVzdHMgPSBJTlRFTF9JTkZPKGRldl9wcml2KS0+Y29sb3IuZ2Ft bWFfbHV0X3Rlc3RzOwo+ID4gLQo+ID4gLQkvKiBDOCBuZWVkcyB0aGUgbGVnYWN5IExVVCBhbGwg dG8gaXRzZWxmICovCj4gPiAtCWlmIChjcnRjX3N0YXRlLT5jOF9wbGFuZXMgJiYKPiA+IC0JICAg ICFjcnRjX3N0YXRlX2lzX2xlZ2FjeV9nYW1tYShjcnRjX3N0YXRlKSkKPiA+IC0JCXJldHVybiAt RUlOVkFMOwo+ID4gKwlyZXQgPSBjaGVja19sdXRzKGNydGNfc3RhdGUpOwo+ID4gKwlpZiAocmV0 KQo+ID4gKwkJcmV0dXJuIHJldDsKPiA+ICAKPiA+ICAJY3J0Y19zdGF0ZS0+Z2FtbWFfZW5hYmxl ID0gKGdhbW1hX2x1dCB8fCBkZWdhbW1hX2x1dCkgJiYKPiA+ICAJCSFjcnRjX3N0YXRlLT5jOF9w bGFuZXM7Cj4gPiBAQCAtODI4LDI1ICs4NTIsMTAgQEAgaW50IGludGVsX2NvbG9yX2NoZWNrKHN0 cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ID4gIAlpZiAoSVNfQ0hFUlJZVklF VyhkZXZfcHJpdikpCj4gPiAgCQljcnRjX3N0YXRlLT5jZ21fbW9kZSA9IGNodl9jZ21fbW9kZShj cnRjX3N0YXRlKTsKPiA+ICAKPiA+IC0JLyogQWx3YXlzIGFsbG93IGxlZ2FjeSBnYW1tYSBMVVQg d2l0aCBubyBmdXJ0aGVyIGNoZWNraW5nLiAqLwo+ID4gIAlpZiAoIWNydGNfc3RhdGUtPmdhbW1h X2VuYWJsZSB8fAo+ID4gLQkgICAgY3J0Y19zdGF0ZV9pc19sZWdhY3lfZ2FtbWEoY3J0Y19zdGF0 ZSkpIHsKPiA+ICsJICAgIGNydGNfc3RhdGVfaXNfbGVnYWN5X2dhbW1hKGNydGNfc3RhdGUpKQo+ ID4gIAkJY3J0Y19zdGF0ZS0+Z2FtbWFfbW9kZSA9IEdBTU1BX01PREVfTU9ERV84QklUOwo+ID4g LQkJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTEgJiYKPiA+IC0JCSAgICBjcnRjX3N0YXRl LT5nYW1tYV9lbmFibGUpCj4gPiAtCQkJY3J0Y19zdGF0ZS0+Z2FtbWFfbW9kZSB8PSBQT1NUX0NT Q19HQU1NQV9FTkFCTEU7Cj4gPiAtCQlyZXR1cm4gMDsKPiA+IC0JfQo+ID4gLQo+ID4gLQlpZiAo Y2hlY2tfbHV0X3NpemUoZGVnYW1tYV9sdXQsIGRlZ2FtbWFfbGVuZ3RoKSB8fAo+ID4gLQkgICAg Y2hlY2tfbHV0X3NpemUoZ2FtbWFfbHV0LCBnYW1tYV9sZW5ndGgpKQo+ID4gLQkJcmV0dXJuIC1F SU5WQUw7Cj4gPiAtCj4gPiAtCWlmIChkcm1fY29sb3JfbHV0X2NoZWNrKGRlZ2FtbWFfbHV0LCBk ZWdhbW1hX3Rlc3RzKSB8fAo+ID4gLQkgICAgZHJtX2NvbG9yX2x1dF9jaGVjayhnYW1tYV9sdXQs IGdhbW1hX3Rlc3RzKSkKPiA+IC0JCXJldHVybiAtRUlOVkFMOwo+ID4gLQo+ID4gLQlpZiAoSU5U RUxfR0VOKGRldl9wcml2KSA+PSAxMSkKPiA+ICsJZWxzZSBpZiAoSU5URUxfR0VOKGRldl9wcml2 KSA+PSAxMSkKPiA+ICAJCWNydGNfc3RhdGUtPmdhbW1hX21vZGUgPSBHQU1NQV9NT0RFX01PREVf MTBCSVQgfAo+ID4gIAkJCQkJIFBSRV9DU0NfR0FNTUFfRU5BQkxFIHwKPiA+ICAJCQkJCSBQT1NU X0NTQ19HQU1NQV9FTkFCTEU7Cj4gPiBAQCAtODU4LDYgKzg2Nyw5IEBAIGludCBpbnRlbF9jb2xv cl9jaGVjayhzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiA+ICAJCWNydGNf c3RhdGUtPmdhbW1hX21vZGUgPSBHQU1NQV9NT0RFX01PREVfOEJJVDsKPiA+ICAKPiA+ICAJaWYg KElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTEpIHsKPiA+ICsJCWlmIChjcnRjX3N0YXRlLT5nYW1t YV9lbmFibGUpCj4gPiArCQkJY3J0Y19zdGF0ZS0+Z2FtbWFfbW9kZSB8PSBQT1NUX0NTQ19HQU1N QV9FTkFCTEU7Cj4gPiArCj4gPiAgCQlpZiAoY3J0Y19zdGF0ZS0+b3V0cHV0X2Zvcm1hdCAhPSBJ TlRFTF9PVVRQVVRfRk9STUFUX1JHQiB8fAo+ID4gIAkJICAgIGNydGNfc3RhdGUtPmxpbWl0ZWRf Y29sb3JfcmFuZ2UpCj4gPiAgCQkJY3J0Y19zdGF0ZS0+Y3NjX21vZGUgfD0gSUNMX09VVFBVVF9D U0NfRU5BQkxFOwo+IAo+IC0tIAo+IEphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFw aGljcyBDZW50ZXIKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4