Re: [RFC v1.1 1/8] v4l2-async: Use endpoint node, not device node, for fwnode match

From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com
Subject: Re: [RFC v1.1 1/8] v4l2-async: Use endpoint node, not device node, for fwnode match
Date: Wed, 20 Mar 2019 16:23:02 +0100	[thread overview]
Message-ID: <20190320152302.GL26015@bigcity.dyn.berto.se> (raw)
In-Reply-To: <20190319130200.1709-1-sakari.ailus@linux.intel.com>

Hi Sakari,

Thanks for your work.

On 2019-03-19 15:02:00 +0200, Sakari Ailus wrote:
[snip]
> diff --git a/drivers/media/platform/rcar_drif.c 
> b/drivers/media/platform/rcar_drif.c
> index c417ff8f6fe5..39da118f882a 100644
> --- a/drivers/media/platform/rcar_drif.c
> +++ b/drivers/media/platform/rcar_drif.c
> @@ -1222,7 +1222,8 @@ static int rcar_drif_parse_subdevs(struct rcar_drif_sdr *sdr)
>  	if (!ep)
>  		return 0;
>  
> -	fwnode = fwnode_graph_get_remote_port_parent(ep);
> +	notifier->subdevs[notifier->num_subdevs] = &sdr->ep.asd;
> +	fwnode = fwnode_graph_get_remote_endpoint(ep);
>  	if (!fwnode) {
>  		dev_warn(sdr->dev, "bad remote port parent\n");
>  		fwnode_handle_put(ep);

I tried the branch you referred to in your cover letter but this driver 
fails to compile for me. Looking at struct v4l2_async_notifier it has 
neither a 'subdevs' nor 'num_subdevs' members so I might be missing a 
dependency. However looking at the change it seems different from what 
you do for other drivers, is this a typo?

-- 
Regards,
Niklas Söderlund