All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rohit Ashiwal <rohit.ashiwal265@gmail.com>
To: gitster@pobox.com
Cc: git@vger.kernel.org, sunshine@sunshineco.com
Subject: Re: What's cooking in git.git (Mar 2019, #04; Wed, 20)
Date: Thu, 21 Mar 2019 03:35:09 +0530	[thread overview]
Message-ID: <20190320220509.7180-1-rohit.ashiwal265@gmail.com> (raw)
In-Reply-To: <xmqqa7hqw844.fsf@gitster-ct.c.googlers.com>

Hey Junio!

On Wed, 20 Mar 2019 12:13:47 +0900 Junio C Hamano <gitster@pobox.com> wrote:
> * ra/t3600-test-path-funcs (2019-03-08) 3 commits
>  - t3600: use helpers to replace test -d/f/e/s <path>
>  - t3600: modernize style
>  - test functions: add function `test_file_not_empty`
>
>  A GSoC micro.
>
>  Will merge to 'next'.
>  cf. <20190304120801.28763-1-rohit.ashiwal265@gmail.com> (v3)

If we are going to merge these in next revision, I say there are some
minor changes that Eric suggested, basically there were some extra spaces
in commit messages and a small change in commit message of [PATCH v3 3/3].
There will *not* be any change in code. Should I attend to them or we are
merging anyway?

Feeling ecstatic
Rohit


  parent reply	other threads:[~2019-03-20 22:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20  3:13 What's cooking in git.git (Mar 2019, #04; Wed, 20) Junio C Hamano
2019-03-20  4:56 ` Junio C Hamano
2019-03-20 11:23 ` Thomas Gummerer
2019-03-20 22:05 ` Rohit Ashiwal [this message]
2019-03-20 22:56   ` Thomas Gummerer
2019-03-20 23:07     ` Rohit Ashiwal
2019-03-21  0:31     ` Junio C Hamano
2019-03-20 22:42 ` Ævar Arnfjörð Bjarmason
2019-03-21  0:46   ` Junio C Hamano
2019-03-21  5:19     ` Junio C Hamano
2019-03-21  9:13       ` Ævar Arnfjörð Bjarmason
2019-03-21  9:46         ` Junio C Hamano
2019-03-21 10:37           ` Ævar Arnfjörð Bjarmason
2019-03-21 11:14             ` Duy Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190320220509.7180-1-rohit.ashiwal265@gmail.com \
    --to=rohit.ashiwal265@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.