From: Matt Roper <matthew.d.roper@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 09/10] drm/i915: Drop the pointless linear legacy LUT load on CHV
Date: Wed, 20 Mar 2019 15:50:05 -0700 [thread overview]
Message-ID: <20190320225005.GB4773@mdroper-desk.amr.corp.intel.com> (raw)
In-Reply-To: <20190318161317.30918-10-ville.syrjala@linux.intel.com>
On Mon, Mar 18, 2019 at 06:13:16PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We now bypass the legacy LUT when it's not needed, so
> no point in filling it up with a linear LUT.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/intel_color.c | 17 +----------------
> 1 file changed, 1 insertion(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c
> index 8c5c66f5d100..b84a2a3f5844 100644
> --- a/drivers/gpu/drm/i915/intel_color.c
> +++ b/drivers/gpu/drm/i915/intel_color.c
> @@ -376,15 +376,6 @@ static void i9xx_load_luts_internal(const struct intel_crtc_state *crtc_state,
> (drm_color_lut_extract(lut[i].green, 8) << 8) |
> drm_color_lut_extract(lut[i].blue, 8);
>
> - if (HAS_GMCH(dev_priv))
> - I915_WRITE(PALETTE(pipe, i), word);
> - else
> - I915_WRITE(LGC_PALETTE(pipe, i), word);
> - }
> - } else {
> - for (i = 0; i < 256; i++) {
> - u32 word = (i << 16) | (i << 8) | i;
> -
> if (HAS_GMCH(dev_priv))
> I915_WRITE(PALETTE(pipe, i), word);
> else
> @@ -643,7 +634,7 @@ static void cherryview_load_luts(const struct intel_crtc_state *crtc_state)
> cherryview_load_csc_matrix(crtc_state);
>
> if (crtc_state_is_legacy_gamma(crtc_state)) {
> - i9xx_load_luts_internal(crtc_state, gamma_lut);
> + i9xx_load_luts(crtc_state);
> return;
> }
>
> @@ -682,12 +673,6 @@ static void cherryview_load_luts(const struct intel_crtc_state *crtc_state)
> I915_WRITE(CGM_PIPE_GAMMA(pipe, i, 1), word1);
> }
> }
> -
> - /*
> - * Also program a linear LUT in the legacy block (behind the
> - * CGM block).
> - */
> - i9xx_load_luts_internal(crtc_state, NULL);
> }
>
> void intel_color_load_luts(const struct intel_crtc_state *crtc_state)
> --
> 2.19.2
>
--
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-20 22:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 16:13 [PATCH 00/10] drm/i915: Clean up intel_color_check() Ville Syrjala
2019-03-18 16:13 ` [PATCH 01/10] drm/i915: Extract check_luts() Ville Syrjala
2019-03-19 16:24 ` Jani Nikula
2019-03-20 14:46 ` Ville Syrjälä
2019-03-19 21:59 ` Matt Roper
2019-03-20 14:41 ` Ville Syrjälä
2019-03-20 15:14 ` Matt Roper
2019-03-20 15:31 ` Ville Syrjälä
2019-03-20 22:48 ` Matt Roper
2019-03-18 16:13 ` [PATCH 02/10] drm/i915: Turn intel_color_check() into a vfunc Ville Syrjala
2019-03-19 21:59 ` Matt Roper
2019-03-18 16:13 ` [PATCH 03/10] drm/i915: Extract i9xx_color_check() Ville Syrjala
2019-03-19 22:00 ` Matt Roper
2019-03-18 16:13 ` [PATCH 04/10] drm/i915: Extract chv_color_check() Ville Syrjala
2019-03-19 22:00 ` Matt Roper
2019-03-20 14:43 ` Ville Syrjälä
2019-03-18 16:13 ` [PATCH 05/10] drm/i915: Extract icl_color_check() Ville Syrjala
2019-03-18 16:13 ` [PATCH 06/10] drm/i915: Extract glk_color_check() Ville Syrjala
2019-03-18 16:13 ` [PATCH 07/10] drm/i915: Extract bdw_color_check() Ville Syrjala
2019-03-20 22:49 ` Matt Roper
2019-03-18 16:13 ` [PATCH 08/10] drm/i915: Extract ilk_color_check() Ville Syrjala
2019-03-20 22:49 ` Matt Roper
2019-03-21 10:05 ` Ville Syrjälä
2019-03-18 16:13 ` [PATCH 09/10] drm/i915: Drop the pointless linear legacy LUT load on CHV Ville Syrjala
2019-03-20 22:50 ` Matt Roper [this message]
2019-03-18 16:13 ` [PATCH 10/10] drm/i915: Skip the linear degamma LUT load on ICL+ Ville Syrjala
2019-03-20 22:50 ` Matt Roper
2019-03-18 20:15 ` ✗ Fi.CI.SPARSE: warning for drm/i915: Clean up intel_color_check() Patchwork
2019-03-18 20:41 ` ✓ Fi.CI.BAT: success " Patchwork
2019-03-19 9:01 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-03-19 16:26 ` [PATCH 00/10] " Jani Nikula
2019-03-19 16:31 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320225005.GB4773@mdroper-desk.amr.corp.intel.com \
--to=matthew.d.roper@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.