From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [PATCH 10/10] drm/i915: Skip the linear degamma LUT load on ICL+ Date: Wed, 20 Mar 2019 15:50:11 -0700 Message-ID: <20190320225011.GC4773@mdroper-desk.amr.corp.intel.com> References: <20190318161317.30918-1-ville.syrjala@linux.intel.com> <20190318161317.30918-11-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9EE1389D64 for ; Wed, 20 Mar 2019 22:50:14 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190318161317.30918-11-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBNYXIgMTgsIDIwMTkgYXQgMDY6MTM6MTdQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IERvbid0IGxvYWQgdGhlIGxpbmVhciBkZWdhbW1hIExVVCBvbiBJQ0wuIFRoZSBo YXJkd2FyZSBubyBsb25nZXIKPiBoYXMgYW55IHNpbGx5IGxpbmthZ2VzIGJldHdlZW4gdGhlIENT QyBlbmFibGUgYW5kIGRlZ2FtbWEgTFVUCj4gZW5hYmxlIHNvIHRoZSBkZWdhbW1hIExVVCBpcyBv bmx5IG5lZWRlZCB3aGVuIGl0J3MgYWN0dWFsbHkKPiBlbmFibGVkLgo+IAo+IEFsc28gYWRkIGNv bW1lbnRzIHRvIGV4cGxhaW4gdGhlIHNpdHVhdGlvbiBvbiBHTEsuCj4gCj4gU2lnbmVkLW9mZi1i eTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KClJldmll d2VkLWJ5OiBNYXR0IFJvcGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwuY29tPgoKPiAtLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29sb3IuYyB8IDg5ICsrKysrKysrKysrKysrKysr KysrKy0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNjMgaW5zZXJ0aW9ucygrKSwgMjYgZGVs ZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Nv bG9yLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jCj4gaW5kZXggYjg0YTJh M2Y1ODQ0Li45NWU0NGY4MGJkOGEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfY29sb3IuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMK PiBAQCAtMjczLDYgKzI3MywxNCBAQCBzdGF0aWMgdm9pZCBpbGtfbG9hZF9jc2NfbWF0cml4KGNv bnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICAJCQkJICAgIGlsa19j c2NfY29lZmZfbGltaXRlZF9yYW5nZSwKPiAgCQkJCSAgICBpbGtfY3NjX3Bvc3RvZmZfbGltaXRl ZF9yYW5nZSk7Cj4gIAl9IGVsc2UgaWYgKGNydGNfc3RhdGUtPmNzY19lbmFibGUpIHsKPiArCQkv Kgo+ICsJCSAqIE9uIEdMSysgYm90aCBwaXBlIENTQyBhbmQgZGVnYW1tYSBMVVQgYXJlIGNvbnRy b2xsZWQKPiArCQkgKiBieSBjc2NfZW5hYmxlLiBIZW5jZSBmb3IgdGhlIGNhc2VzIHdoZXJlIHRo ZSBkZWdhbWEKPiArCQkgKiBMVVQgaXMgbmVlZGVkIGJ1dCBDU0MgaXMgbm90IHdlIG5lZWQgdG8g bG9hZCBhbgo+ICsJCSAqIGlkZW50aXR5IG1hdHJpeC4KPiArCQkgKi8KPiArCQlXQVJOX09OKCFJ U19DQU5OT05MQUtFKGRldl9wcml2KSAmJiAhSVNfR0VNSU5JTEFLRShkZXZfcHJpdikpOwo+ICsK PiAgCQlpbGtfdXBkYXRlX3BpcGVfY3NjKGNydGMsIGlsa19jc2Nfb2ZmX3plcm8sCj4gIAkJCQkg ICAgaWxrX2NzY19jb2VmZl9pZGVudGl0eSwKPiAgCQkJCSAgICBpbGtfY3NjX29mZl96ZXJvKTsK PiBAQCAtNTU5LDYgKzU2Nyw3IEBAIHN0YXRpYyB2b2lkIGdsa19sb2FkX2RlZ2FtbWFfbHV0KGNv bnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICAJc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShjcnRjLT5iYXNlLmRldik7Cj4gIAllbnVt IHBpcGUgcGlwZSA9IGNydGMtPnBpcGU7Cj4gIAljb25zdCB1MzIgbHV0X3NpemUgPSBJTlRFTF9J TkZPKGRldl9wcml2KS0+Y29sb3IuZGVnYW1tYV9sdXRfc2l6ZTsKPiArCXN0cnVjdCBkcm1fY29s b3JfbHV0ICpsdXQgPSBjcnRjX3N0YXRlLT5iYXNlLmRlZ2FtbWFfbHV0LT5kYXRhOwo+ICAJdTMy IGk7Cj4gIAo+ICAJLyoKPiBAQCAtNTY5LDMyICs1NzgsNDggQEAgc3RhdGljIHZvaWQgZ2xrX2xv YWRfZGVnYW1tYV9sdXQoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUp Cj4gIAlJOTE1X1dSSVRFKFBSRV9DU0NfR0FNQ19JTkRFWChwaXBlKSwgMCk7Cj4gIAlJOTE1X1dS SVRFKFBSRV9DU0NfR0FNQ19JTkRFWChwaXBlKSwgUFJFX0NTQ19HQU1DX0FVVE9fSU5DUkVNRU5U KTsKPiAgCj4gLQlpZiAoY3J0Y19zdGF0ZS0+YmFzZS5kZWdhbW1hX2x1dCkgewo+IC0JCXN0cnVj dCBkcm1fY29sb3JfbHV0ICpsdXQgPSBjcnRjX3N0YXRlLT5iYXNlLmRlZ2FtbWFfbHV0LT5kYXRh Owo+ICsJZm9yIChpID0gMDsgaSA8IGx1dF9zaXplOyBpKyspIHsKPiArCQkvKgo+ICsJCSAqIEZp cnN0IDMzIGVudHJpZXMgcmVwcmVzZW50IHJhbmdlIGZyb20gMCB0byAxLjAKPiArCQkgKiAzNHRo IGFuZCAzNXRoIGVudHJ5IHdpbGwgcmVwcmVzZW50IGV4dGVuZGVkIHJhbmdlCj4gKwkJICogaW5w dXRzIDMuMCBhbmQgNy4wIHJlc3BlY3RpdmVseSwgY3VycmVudGx5IGNsYW1wZWQKPiArCQkgKiBh dCAxLjAuIFNpbmNlIHRoZSBwcmVjaXNpb24gaXMgMTZiaXQsIHRoZSB1c2VyCj4gKwkJICogdmFs dWUgY2FuIGJlIGRpcmVjdGx5IGZpbGxlZCB0byByZWdpc3Rlci4KPiArCQkgKiBUaGUgcGlwZSBk ZWdhbW1hIHRhYmxlIGluIEdMSysgb253YXJkcyBkb2Vzbid0Cj4gKwkJICogc3VwcG9ydCBkaWZm ZXJlbnQgdmFsdWVzIHBlciBjaGFubmVsLCBzbyB0aGlzIGp1c3QKPiArCQkgKiBwcm9ncmFtcyBn cmVlbiB2YWx1ZSB3aGljaCB3aWxsIGJlIGVxdWFsIHRvIFJlZCBhbmQKPiArCQkgKiBCbHVlIGlu dG8gdGhlIGx1dCByZWdpc3RlcnMuCj4gKwkJICogVG9EbzogRXh0ZW5kIHRvIG1heCA3LjAuIEVu YWJsZSAzMiBiaXQgaW5wdXQgdmFsdWUKPiArCQkgKiBhcyBjb21wYXJlZCB0byBqdXN0IDE2IHRv IGFjaGlldmUgdGhpcy4KPiArCQkgKi8KPiArCQlJOTE1X1dSSVRFKFBSRV9DU0NfR0FNQ19EQVRB KHBpcGUpLCBsdXRbaV0uZ3JlZW4pOwo+ICsJfQo+ICAKPiAtCQlmb3IgKGkgPSAwOyBpIDwgbHV0 X3NpemU7IGkrKykgewo+IC0JCQkvKgo+IC0JCQkgKiBGaXJzdCAzMyBlbnRyaWVzIHJlcHJlc2Vu dCByYW5nZSBmcm9tIDAgdG8gMS4wCj4gLQkJCSAqIDM0dGggYW5kIDM1dGggZW50cnkgd2lsbCBy ZXByZXNlbnQgZXh0ZW5kZWQgcmFuZ2UKPiAtCQkJICogaW5wdXRzIDMuMCBhbmQgNy4wIHJlc3Bl Y3RpdmVseSwgY3VycmVudGx5IGNsYW1wZWQKPiAtCQkJICogYXQgMS4wLiBTaW5jZSB0aGUgcHJl Y2lzaW9uIGlzIDE2Yml0LCB0aGUgdXNlcgo+IC0JCQkgKiB2YWx1ZSBjYW4gYmUgZGlyZWN0bHkg ZmlsbGVkIHRvIHJlZ2lzdGVyLgo+IC0JCQkgKiBUaGUgcGlwZSBkZWdhbW1hIHRhYmxlIGluIEdM Sysgb253YXJkcyBkb2Vzbid0Cj4gLQkJCSAqIHN1cHBvcnQgZGlmZmVyZW50IHZhbHVlcyBwZXIg Y2hhbm5lbCwgc28gdGhpcyBqdXN0Cj4gLQkJCSAqIHByb2dyYW1zIGdyZWVuIHZhbHVlIHdoaWNo IHdpbGwgYmUgZXF1YWwgdG8gUmVkIGFuZAo+IC0JCQkgKiBCbHVlIGludG8gdGhlIGx1dCByZWdp c3RlcnMuCj4gLQkJCSAqIFRvRG86IEV4dGVuZCB0byBtYXggNy4wLiBFbmFibGUgMzIgYml0IGlu cHV0IHZhbHVlCj4gLQkJCSAqIGFzIGNvbXBhcmVkIHRvIGp1c3QgMTYgdG8gYWNoaWV2ZSB0aGlz Lgo+IC0JCQkgKi8KPiAtCQkJSTkxNV9XUklURShQUkVfQ1NDX0dBTUNfREFUQShwaXBlKSwgbHV0 W2ldLmdyZWVuKTsKPiAtCQl9Cj4gLQl9IGVsc2Ugewo+IC0JCS8qIGxvYWQgYSBsaW5lYXIgdGFi bGUuICovCj4gLQkJZm9yIChpID0gMDsgaSA8IGx1dF9zaXplOyBpKyspIHsKPiAtCQkJdTMyIHYg PSAoaSAqICgxIDw8IDE2KSkgLyAobHV0X3NpemUgLSAxKTsKPiArCS8qIENsYW1wIHZhbHVlcyA+ IDEuMC4gKi8KPiArCXdoaWxlIChpKysgPCAzNSkKPiArCQlJOTE1X1dSSVRFKFBSRV9DU0NfR0FN Q19EQVRBKHBpcGUpLCAoMSA8PCAxNikpOwo+ICt9Cj4gIAo+IC0JCQlJOTE1X1dSSVRFKFBSRV9D U0NfR0FNQ19EQVRBKHBpcGUpLCB2KTsKPiAtCQl9Cj4gK3N0YXRpYyB2b2lkIGdsa19sb2FkX2Rl Z2FtbWFfbHV0X2xpbmVhcihjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0 ZSkKPiArewo+ICsJc3RydWN0IGludGVsX2NydGMgKmNydGMgPSB0b19pbnRlbF9jcnRjKGNydGNf c3RhdGUtPmJhc2UuY3J0Yyk7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYg PSB0b19pOTE1KGNydGMtPmJhc2UuZGV2KTsKPiArCWVudW0gcGlwZSBwaXBlID0gY3J0Yy0+cGlw ZTsKPiArCWNvbnN0IHUzMiBsdXRfc2l6ZSA9IElOVEVMX0lORk8oZGV2X3ByaXYpLT5jb2xvci5k ZWdhbW1hX2x1dF9zaXplOwo+ICsJdTMyIGk7Cj4gKwo+ICsJLyoKPiArCSAqIFdoZW4gc2V0dGlu ZyB0aGUgYXV0by1pbmNyZW1lbnQgYml0LCB0aGUgaGFyZHdhcmUgc2VlbXMgdG8KPiArCSAqIGln bm9yZSB0aGUgaW5kZXggYml0cywgc28gd2UgbmVlZCB0byByZXNldCBpdCB0byBpbmRleCAwCj4g KwkgKiBzZXBhcmF0ZWx5Lgo+ICsJICovCj4gKwlJOTE1X1dSSVRFKFBSRV9DU0NfR0FNQ19JTkRF WChwaXBlKSwgMCk7Cj4gKwlJOTE1X1dSSVRFKFBSRV9DU0NfR0FNQ19JTkRFWChwaXBlKSwgUFJF X0NTQ19HQU1DX0FVVE9fSU5DUkVNRU5UKTsKPiArCj4gKwlmb3IgKGkgPSAwOyBpIDwgbHV0X3Np emU7IGkrKykgewo+ICsJCXUzMiB2ID0gKGkgIDw8IDE2KSAvIChsdXRfc2l6ZSAtIDEpOwo+ICsK PiArCQlJOTE1X1dSSVRFKFBSRV9DU0NfR0FNQ19EQVRBKHBpcGUpLCB2KTsKPiAgCX0KPiAgCj4g IAkvKiBDbGFtcCB2YWx1ZXMgPiAxLjAuICovCj4gQEAgLTYwNCw3ICs2MjksMTggQEAgc3RhdGlj IHZvaWQgZ2xrX2xvYWRfZGVnYW1tYV9sdXQoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUg KmNydGNfc3RhdGUpCj4gIAo+ICBzdGF0aWMgdm9pZCBnbGtfbG9hZF9sdXRzKGNvbnN0IHN0cnVj dCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICB7Cj4gLQlnbGtfbG9hZF9kZWdhbW1h X2x1dChjcnRjX3N0YXRlKTsKPiArCS8qCj4gKwkgKiBPbiBHTEsrIGJvdGggcGlwZSBDU0MgYW5k IGRlZ2FtbWEgTFVUIGFyZSBjb250cm9sbGVkCj4gKwkgKiBieSBjc2NfZW5hYmxlLiBIZW5jZSBm b3IgdGhlIGNhc2VzIHdoZXJlIHRoZSBDU0MgaXMKPiArCSAqIG5lZWRlZCBidXQgZGVnYW1tYSBM VVQgaXMgbm90IHdlIG5lZWQgdG8gbG9hZCBhCj4gKwkgKiBsaW5lYXIgZGVnYW1tYSBMVVQuIElu IGZhY3Qgd2UnbGwganVzdCBhbHdheXMgbG9hZAo+ICsJICogdGhlIGRlZ2FtYSBMVVQgc28gdGhh dCB3ZSBkb24ndCBoYXZlIHRvIHJlbG9hZAo+ICsJICogaXQgZXZlcnkgdGltZSB0aGUgcGlwZSBD U0MgaXMgYmVpbmcgZW5hYmxlZC4KPiArCSAqLwo+ICsJaWYgKGNydGNfc3RhdGUtPmJhc2UuZGVn YW1tYV9sdXQpCj4gKwkJZ2xrX2xvYWRfZGVnYW1tYV9sdXQoY3J0Y19zdGF0ZSk7Cj4gKwllbHNl Cj4gKwkJZ2xrX2xvYWRfZGVnYW1tYV9sdXRfbGluZWFyKGNydGNfc3RhdGUpOwo+ICAKPiAgCWlm IChjcnRjX3N0YXRlX2lzX2xlZ2FjeV9nYW1tYShjcnRjX3N0YXRlKSkKPiAgCQlpOXh4X2xvYWRf bHV0cyhjcnRjX3N0YXRlKTsKPiBAQCAtNjE0LDcgKzY1MCw4IEBAIHN0YXRpYyB2b2lkIGdsa19s b2FkX2x1dHMoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gIAo+ ICBzdGF0aWMgdm9pZCBpY2xfbG9hZF9sdXRzKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRl ICpjcnRjX3N0YXRlKQo+ICB7Cj4gLQlnbGtfbG9hZF9kZWdhbW1hX2x1dChjcnRjX3N0YXRlKTsK PiArCWlmIChjcnRjX3N0YXRlLT5iYXNlLmRlZ2FtbWFfbHV0KQo+ICsJCWdsa19sb2FkX2RlZ2Ft bWFfbHV0KGNydGNfc3RhdGUpOwo+ICAKPiAgCWlmIChjcnRjX3N0YXRlX2lzX2xlZ2FjeV9nYW1t YShjcnRjX3N0YXRlKSkKPiAgCQlpOXh4X2xvYWRfbHV0cyhjcnRjX3N0YXRlKTsKPiAtLSAKPiAy LjE5LjIKPiAKCi0tIApNYXR0IFJvcGVyCkdyYXBoaWNzIFNvZnR3YXJlIEVuZ2luZWVyCklvVEcg UGxhdGZvcm0gRW5hYmxpbmcgJiBEZXZlbG9wbWVudApJbnRlbCBDb3Jwb3JhdGlvbgooOTE2KSAz NTYtMjc5NQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=