From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 330CBC43381 for ; Thu, 21 Mar 2019 16:10:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E1F712175B for ; Thu, 21 Mar 2019 16:10:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728057AbfCUQKE (ORCPT ); Thu, 21 Mar 2019 12:10:04 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:49674 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727829AbfCUQKE (ORCPT ); Thu, 21 Mar 2019 12:10:04 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 71DF0133E9753; Thu, 21 Mar 2019 09:10:03 -0700 (PDT) Date: Thu, 21 Mar 2019 09:10:00 -0700 (PDT) Message-Id: <20190321.091000.1735440574480245798.davem@davemloft.net> To: jon.maloy@ericsson.com Cc: netdev@vger.kernel.org, gordan.mihaljevic@dektech.com.au, tung.q.nguyen@dektech.com.au, hoang.h.le@dektech.com.au, canh.d.luu@dektech.com.au, ying.xue@windriver.com, tipc-discussion@lists.sourceforge.net Subject: Re: [net v2 1/1] tipc: fix cancellation of topology subscriptions From: David Miller In-Reply-To: <1553155919-20258-1-git-send-email-jon.maloy@ericsson.com> References: <1553155919-20258-1-git-send-email-jon.maloy@ericsson.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 21 Mar 2019 09:10:03 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jon Maloy Date: Thu, 21 Mar 2019 09:11:59 +0100 > From: Erik Hugne > > When cancelling a subscription, we have to clear the cancel bit in the > request before iterating over any established subscriptions with memcmp. > Otherwise no subscription will ever be found, and it will not be > possible to explicitly unsubscribe individual subscriptions. > > Fixes: 8985ecc7c1e0 ("tipc: simplify endianness handling in topology subscriber") > Signed-off-by: Erik Hugne > Signed-off-by: Jon Maloy > > --- > v2: clear bit in a more sensible way.. (comment from davem) Applied and queued up for -stable. Thanks for following up.