From: Greg KH <gregkh@linuxfoundation.org>
To: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] [Outreachy kernel] staging: emxx_udc: replace 0 with false
Date: Thu, 21 Mar 2019 08:19:49 +0100 [thread overview]
Message-ID: <20190321071949.GE28171@kroah.com> (raw)
In-Reply-To: <1553141487-3582-1-git-send-email-payal.s.kshirsagar.98@gmail.com>
On Thu, Mar 21, 2019 at 09:41:27AM +0530, Payal Kshirsagar wrote:
> replace 0 with FALSE in file rivers/staging/emxx_udc/emxx_udc.h
Why?
>
> Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> ---
> drivers/staging/emxx_udc/emxx_udc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
> index b8c3dee..540e4ca 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.h
> +++ b/drivers/staging/emxx_udc/emxx_udc.h
> @@ -10,7 +10,7 @@
>
> /*---------------------------------------------------------------------------*/
> /*----------------- Default undef */
> -#if 0
> +#if FALSE
Are you sure this is ok? Why is this change needed at all?
thanks,
greg k-h
next prev parent reply other threads:[~2019-03-21 7:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 4:11 [PATCH] [Outreachy kernel] staging: emxx_udc: replace 0 with false Payal Kshirsagar
2019-03-21 7:19 ` Greg KH [this message]
2019-03-21 8:15 ` Payal Kshirsagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321071949.GE28171@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=payal.s.kshirsagar.98@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.