* [PATCH] [Outreachy kernel] staging: emxx_udc: replace 0 with false
@ 2019-03-21 4:11 Payal Kshirsagar
2019-03-21 7:19 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Payal Kshirsagar @ 2019-03-21 4:11 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Payal Kshirsagar
replace 0 with FALSE in file rivers/staging/emxx_udc/emxx_udc.h
Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
---
drivers/staging/emxx_udc/emxx_udc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
index b8c3dee..540e4ca 100644
--- a/drivers/staging/emxx_udc/emxx_udc.h
+++ b/drivers/staging/emxx_udc/emxx_udc.h
@@ -10,7 +10,7 @@
/*---------------------------------------------------------------------------*/
/*----------------- Default undef */
-#if 0
+#if FALSE
#define DEBUG
#define UDC_DEBUG_DUMP
#endif
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [Outreachy kernel] staging: emxx_udc: replace 0 with false
2019-03-21 4:11 [PATCH] [Outreachy kernel] staging: emxx_udc: replace 0 with false Payal Kshirsagar
@ 2019-03-21 7:19 ` Greg KH
2019-03-21 8:15 ` Payal Kshirsagar
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2019-03-21 7:19 UTC (permalink / raw)
To: Payal Kshirsagar; +Cc: outreachy-kernel
On Thu, Mar 21, 2019 at 09:41:27AM +0530, Payal Kshirsagar wrote:
> replace 0 with FALSE in file rivers/staging/emxx_udc/emxx_udc.h
Why?
>
> Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> ---
> drivers/staging/emxx_udc/emxx_udc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
> index b8c3dee..540e4ca 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.h
> +++ b/drivers/staging/emxx_udc/emxx_udc.h
> @@ -10,7 +10,7 @@
>
> /*---------------------------------------------------------------------------*/
> /*----------------- Default undef */
> -#if 0
> +#if FALSE
Are you sure this is ok? Why is this change needed at all?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [Outreachy kernel] staging: emxx_udc: replace 0 with false
2019-03-21 7:19 ` Greg KH
@ 2019-03-21 8:15 ` Payal Kshirsagar
0 siblings, 0 replies; 3+ messages in thread
From: Payal Kshirsagar @ 2019-03-21 8:15 UTC (permalink / raw)
To: Greg KH; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 948 bytes --]
On Thu, 21 Mar 2019 at 12:49, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, Mar 21, 2019 at 09:41:27AM +0530, Payal Kshirsagar wrote:
> > replace 0 with FALSE in file rivers/staging/emxx_udc/emxx_udc.h
>
> Why?
>
> >
> > Signed-off-by: Payal Kshirsagar <payal.s.kshirsagar.98@gmail.com>
> > ---
> > drivers/staging/emxx_udc/emxx_udc.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/emxx_udc/emxx_udc.h
> b/drivers/staging/emxx_udc/emxx_udc.h
> > index b8c3dee..540e4ca 100644
> > --- a/drivers/staging/emxx_udc/emxx_udc.h
> > +++ b/drivers/staging/emxx_udc/emxx_udc.h
> > @@ -10,7 +10,7 @@
> >
> >
> /*---------------------------------------------------------------------------*/
> > /*----------------- Default undef */
> > -#if 0
> > +#if FALSE
>
> Are you sure this is ok? Why is this change needed at all?
>
> ohh I am sorry. This change if of no use.
payal
> thanks,
>
> greg k-h
>
[-- Attachment #2: Type: text/html, Size: 1638 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-21 8:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-21 4:11 [PATCH] [Outreachy kernel] staging: emxx_udc: replace 0 with false Payal Kshirsagar
2019-03-21 7:19 ` Greg KH
2019-03-21 8:15 ` Payal Kshirsagar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.