From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F08FC43381 for ; Thu, 21 Mar 2019 09:20:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4AB0D218A2 for ; Thu, 21 Mar 2019 09:20:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="rZ8Diyz5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727914AbfCUJUH (ORCPT ); Thu, 21 Mar 2019 05:20:07 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:50885 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727878AbfCUJUH (ORCPT ); Thu, 21 Mar 2019 05:20:07 -0400 Received: by mail-wm1-f66.google.com with SMTP id z11so1942721wmi.0 for ; Thu, 21 Mar 2019 02:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=e9pAojetyqOuLMU7IUIv7b5Na809OHKatpoag09L3+w=; b=rZ8Diyz5Nc3dVcx/HKGSP49ICaOjBVzRwTI9zfpXKqseKe718q3a96tNJPW6CvOYo0 BGGvLjFzoVjRISk4gNFtzXr2lul/Wt0Uel92BMdTPgT+D82qqMJkZVhr/kfStfvZqA1k pblgY8TgeNktYyT4gCTQGJZb+bSXdCrBWS3/vahP2+3LjhbEBMeL814VCnpBgQYluZEl rpnuh4Qn/nH4awJYbgUjWPnoqWhtLlEIMHRYTq7BTADrZvTZ4D1ush/xx/KnTacBLww3 eShyOJ6W9QQZsllR4AF86MujOBH7JirRqZ0SqGGnPCkqIFY+rbKvYErE3mkx8wFZC152 PJqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=e9pAojetyqOuLMU7IUIv7b5Na809OHKatpoag09L3+w=; b=W6Cb+8DlZJlSh4BPSqe3E7PamAF7zsr8XkSVFg5ED6CgS5g+o3gowWj+9Z4bgPf1+y MlpFq/wXO2tf4RdP2Xi5VmIfYnrivFW6Rrcz6z0ea5n2pMUnBeh+VToyzqYvT1XqySuD cNDOy1v7qehoqEn8KbZWHtQ/BEz89jm2V8rRZZbHjJmBD3eQ1gZP2lAU5ly1BLwUTQxb wu8T8QSML27eGT+hnzehPqlf1GMmbjI0hZIz/jTOa3AYmdzrw3DY8WMn/7wafPk06oEy Y1zL5otyUnGJPzM4XreLhP9qUF4oaZR7FhqQXTCx+/cWHhI2An8BCncq80NZnC7UPLVn hoHA== X-Gm-Message-State: APjAAAWzpGMIoKU8+t6KKFD62jrszbEnqmPcqI3iF+zABxqi/c8vluB6 jDkRHVmsQ7Y0i8EiXZFxaTVHzw== X-Google-Smtp-Source: APXvYqw2n8HfViqysdDzx5UDY3nYrB/v+BPtvhjSjxHWV3iXd7SKofn+XC9wlpbdQ+VXGLB1a5hsRA== X-Received: by 2002:a1c:be03:: with SMTP id o3mr1635047wmf.123.1553160006022; Thu, 21 Mar 2019 02:20:06 -0700 (PDT) Received: from localhost ([195.39.71.253]) by smtp.gmail.com with ESMTPSA id b3sm5241009wrx.57.2019.03.21.02.20.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2019 02:20:05 -0700 (PDT) Date: Thu, 21 Mar 2019 10:09:25 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: Parav Pandit , "Samudrala, Sridhar" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "oss-drivers@netronome.com" Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Message-ID: <20190321090925.GC2087@nanopsycho> References: <20190314163915.24fd2481@cakuba.netronome.com> <4436da3d-4b99-f792-8e77-695d5958794d@intel.com> <20190315200814.GD2305@nanopsycho> <20190318122105.GH2270@nanopsycho> <20190318121900.4412fabb@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190318121900.4412fabb@cakuba.netronome.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Mar 18, 2019 at 08:19:00PM CET, jakub.kicinski@netronome.com wrote: >On Mon, 18 Mar 2019 13:21:05 +0100, Jiri Pirko wrote: >> >First two entries shows the link between hostport and switchport. >> >$ devlink port show >> >pci/0000:05:00.0/10002 eth netdev flavour switchport switch_id 00154d130d2f peer pci/0000:05:00.0/1 >> > >> >pci/0000:05:00.0/1 eth netdev flavour hostport switch_id 00154d130d2f peer pci/0000:05:00.0/10002 >> >> Hostport should not have switch_id. > >Isn't a concept of a port of a switch without a switch ID a red flag? If we want to have hostports as devlink ports, they should not have switch id. They are not switch ports but rather counterparts of the switch ports.