From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C6BEC43381 for ; Thu, 21 Mar 2019 11:45:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69C22218FD for ; Thu, 21 Mar 2019 11:45:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="iWEPTvkY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728154AbfCULpx (ORCPT ); Thu, 21 Mar 2019 07:45:53 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:33166 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727923AbfCULpw (ORCPT ); Thu, 21 Mar 2019 07:45:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nXwxvZcGtcjuDQ8IJpMKqrLzV5vePZUyKAJAsBh9ArU=; b=iWEPTvkYko0ZkPy+wN5Me9qK/4 duBtldgq54stHiIN1NAK+qlr8IonmsGla2W5RmYbBNUjbVAU6+RMkeNxFIoYng57pDIID6lnxWXEJ zPmEjNGy6vzIVLNl2cWJI8HKeyud7doUAmx+jczUuBcsQx0CFNMLNxcGWLXbqF4E1NGU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1h6w8m-0003We-21; Thu, 21 Mar 2019 12:45:44 +0100 Date: Thu, 21 Mar 2019 12:45:44 +0100 From: Andrew Lunn To: Fabio Estevam Cc: Abel Vesa , Steve Twiss , Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , dl-linux-imx , DEVICETREE , LINUX-ARM-KERNEL , LKML , Support Opensource Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id Message-ID: <20190321114544.GG2900@lunn.ch> References: <20190320120604.7D99B3FBE9@swsrvapps-01.diasemi.com> <20190321084240.fveqkhfrbtg7qr4q@fsr-ub1664-175> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 21, 2019 at 08:17:01AM -0300, Fabio Estevam wrote: > Hi Abel, > > On Thu, Mar 21, 2019 at 5:42 AM Abel Vesa wrote: > > > > It seems we have other boards that need to be fixed and we can not > > > have an old dtb with functional Ethernet with a new kernel. > > > > > > Does anyone know if this issue is AR8031 specific? > > > > I can confirm the same fix is works on imx6sx too. > > imx6sx-sabresd also uses an AR8031 Ethernet PHY. > > I also tested that changing the phy-mode to "rgmii-id" fixes Ethernet > on pico-imx7d with AR8035. > > So yes, we currently have lots of broken dtb's in mainline and I am > wondering what is the proper fix here. > > Does anyone know what was the kernel commit that introduced such regressions? Hi Fabio The problem here is, all the DTs were broken since day 0. However, because the PHY driver was also broken, nobody noticed and it worked. Now that the PHY driver has been fixed, all the bugs in the DTs now become an issue. There is also a need to fix the PHY driver, because there is at least one board which needs it fixed in order to work. When we discussed fixing the PHY driver, we had no idea how many boards would break. So we said, lets try it, and fix up whatever breaks. We can however discuss this again. We can declare both the PHY driver and the DTs terminally broken, and add a vendor proprietary property for the phy-mode, which takes preference over the standard phy-mode if present, and that does the correct thing. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AAF8C43381 for ; Thu, 21 Mar 2019 11:46:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEEDA218FD for ; Thu, 21 Mar 2019 11:46:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="d8EfZ3bP"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="iWEPTvkY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEEDA218FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CYq3klivkIlfwKnPxLYtJeAP8PqbfEqIBoTed0fdN50=; b=d8EfZ3bPlgLXm4 aGY5bhCzQ5PkMXBefC4PwocPsFOsMvZBPGxcImB0vzbN69J/KiwLwduWi57Oi+F33jLVXsYXOvvzW ZV/tJlx44VhsrXzQwfOf+BkVsDUiPR7COR6AigeABoggnKrlnOv/3igjxnQ0u2kYPpHI+fNJbA5Ch YvgkmjH5cVVmrMQCCD7myXYTKiqS/Wn0mj2yI2/1+zwl6OzcJiPEnvQmGfg3SlnTmOrtN4BE2qbOI LqI77hnp2n393qcz1+/lD4Ch4paU2UMbn8yKjkj/hBtSj7oQEQ3HMKtid4eUUi/Uz8OMzQJFCXBeh iUMcm7+IM3fmdGZAZFww==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6w90-00041i-I6; Thu, 21 Mar 2019 11:45:58 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6w8w-0003rg-C4 for linux-arm-kernel@lists.infradead.org; Thu, 21 Mar 2019 11:45:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nXwxvZcGtcjuDQ8IJpMKqrLzV5vePZUyKAJAsBh9ArU=; b=iWEPTvkYko0ZkPy+wN5Me9qK/4 duBtldgq54stHiIN1NAK+qlr8IonmsGla2W5RmYbBNUjbVAU6+RMkeNxFIoYng57pDIID6lnxWXEJ zPmEjNGy6vzIVLNl2cWJI8HKeyud7doUAmx+jczUuBcsQx0CFNMLNxcGWLXbqF4E1NGU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1h6w8m-0003We-21; Thu, 21 Mar 2019 12:45:44 +0100 Date: Thu, 21 Mar 2019 12:45:44 +0100 From: Andrew Lunn To: Fabio Estevam Subject: Re: [PATCH] ARM: dts: imx6qdl-sabresd: change phy-mode to use rgmii-id Message-ID: <20190321114544.GG2900@lunn.ch> References: <20190320120604.7D99B3FBE9@swsrvapps-01.diasemi.com> <20190321084240.fveqkhfrbtg7qr4q@fsr-ub1664-175> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190321_044554_571557_7C61EF22 X-CRM114-Status: GOOD ( 18.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , DEVICETREE , Abel Vesa , Sascha Hauer , LKML , Rob Herring , Steve Twiss , dl-linux-imx , Pengutronix Kernel Team , Shawn Guo , LINUX-ARM-KERNEL , Support Opensource Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 21, 2019 at 08:17:01AM -0300, Fabio Estevam wrote: > Hi Abel, > > On Thu, Mar 21, 2019 at 5:42 AM Abel Vesa wrote: > > > > It seems we have other boards that need to be fixed and we can not > > > have an old dtb with functional Ethernet with a new kernel. > > > > > > Does anyone know if this issue is AR8031 specific? > > > > I can confirm the same fix is works on imx6sx too. > > imx6sx-sabresd also uses an AR8031 Ethernet PHY. > > I also tested that changing the phy-mode to "rgmii-id" fixes Ethernet > on pico-imx7d with AR8035. > > So yes, we currently have lots of broken dtb's in mainline and I am > wondering what is the proper fix here. > > Does anyone know what was the kernel commit that introduced such regressions? Hi Fabio The problem here is, all the DTs were broken since day 0. However, because the PHY driver was also broken, nobody noticed and it worked. Now that the PHY driver has been fixed, all the bugs in the DTs now become an issue. There is also a need to fix the PHY driver, because there is at least one board which needs it fixed in order to work. When we discussed fixing the PHY driver, we had no idea how many boards would break. So we said, lets try it, and fix up whatever breaks. We can however discuss this again. We can declare both the PHY driver and the DTs terminally broken, and add a vendor proprietary property for the phy-mode, which takes preference over the standard phy-mode if present, and that does the correct thing. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel