From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F82AC43381 for ; Thu, 21 Mar 2019 13:20:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D47521874 for ; Thu, 21 Mar 2019 13:20:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="nSK7moFN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728484AbfCUNUq (ORCPT ); Thu, 21 Mar 2019 09:20:46 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:40164 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728410AbfCUNUd (ORCPT ); Thu, 21 Mar 2019 09:20:33 -0400 Received: by mail-wm1-f68.google.com with SMTP id u10so2666351wmj.5 for ; Thu, 21 Mar 2019 06:20:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=P7PijDAyYWVOUnASVOq5OlrtnenIzUv+8QkVaBxoLHo=; b=nSK7moFNYD4Awc4J7woLBsFSzu7w40tobNaYAbfjpZG8RtlSJgeaMKv3uR2nEm5Cek qvBEErMbhFttBweSpvAhBnp+zmwi+/wAtzp65bsz3eGYbf5XlRPCtmtVMh4ngIa3vuUT GunGLO2LoKzQFG5tsSSrCyjPMSf9DE3K+hCrr1G8JuOlXp7ASy1N9Gw8lc2O8pVIS22r xfPBVCKIuatEozYVvU7oN3Sd7LNNaSvRy826deoDSYnxf1TOk09JeOsxo0ONXn8CjChF oSWsryaPEKbWnHV8kJIyVZZLvXsnsbVxhBTmOViT/oY1L8weGdyxikFJbOolJg/fxunK Z84g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=P7PijDAyYWVOUnASVOq5OlrtnenIzUv+8QkVaBxoLHo=; b=H137FSxBGjWfHX4oX62tI6rcv0ZL9nxObluWW/KnjITdRZacaoeDGteBCnJIQ7FFP4 doRA/Rek/FiQF4zVvUWljPR9RPL9HpyKpa6R7ujXrTGWzq4H+nTHNwKhao39GB1Cvzi4 UF+wQMa4rO+w0jNs0TJ9YcZqrUdwfL5HDJicOekQip+5kE6lju3tDZAxRjyLJbL1npP+ jOOLeEe8hBxFJK279/pkI3m+iK72SwvzAfi41MGHDwtrUkq5AeSPJNIOniYJ7/kWDWUP Uar0rjmjqaSZm4aetAthnCzBsD+m33w+Zjgy1kZ4h/NyHqZAUOMlq5EHq6Gc+FcWmdAx YoZA== X-Gm-Message-State: APjAAAX84ZcrzoVOLh6G9fpsQyts5QFUe/+DJWF6Im6F/dio8+d4R8Rr nsiTycZFgbGNbaUQwgsSBTn2Gv9ZWxs= X-Google-Smtp-Source: APXvYqwAQCK7O1Ikv6W83l1yvpKPGUGQ9QxE5ZgnU820SwMJFndxoq+heU1xGnKNA5sCvzg/DtrLfQ== X-Received: by 2002:a1c:c647:: with SMTP id w68mr2615145wmf.8.1553174431140; Thu, 21 Mar 2019 06:20:31 -0700 (PDT) Received: from localhost ([195.39.71.253]) by smtp.gmail.com with ESMTPSA id 204sm8625583wmc.1.2019.03.21.06.20.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2019 06:20:30 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: [patch net-next 07/11] net: devlink: don't pass return value of __devlink_port_type_set() Date: Thu, 21 Mar 2019 14:20:15 +0100 Message-Id: <20190321132019.1426-8-jiri@resnulli.us> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190321132019.1426-1-jiri@resnulli.us> References: <20190321132019.1426-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko __devlink_port_type_set() returns void, it makes no sense to pass it on, so don't do that. Signed-off-by: Jiri Pirko --- net/core/devlink.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index 1e125c3b890c..98ca788ffd97 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -5379,8 +5379,7 @@ static void __devlink_port_type_set(struct devlink_port *devlink_port, void devlink_port_type_eth_set(struct devlink_port *devlink_port, struct net_device *netdev) { - return __devlink_port_type_set(devlink_port, - DEVLINK_PORT_TYPE_ETH, netdev); + __devlink_port_type_set(devlink_port, DEVLINK_PORT_TYPE_ETH, netdev); } EXPORT_SYMBOL_GPL(devlink_port_type_eth_set); @@ -5393,8 +5392,7 @@ EXPORT_SYMBOL_GPL(devlink_port_type_eth_set); void devlink_port_type_ib_set(struct devlink_port *devlink_port, struct ib_device *ibdev) { - return __devlink_port_type_set(devlink_port, - DEVLINK_PORT_TYPE_IB, ibdev); + __devlink_port_type_set(devlink_port, DEVLINK_PORT_TYPE_IB, ibdev); } EXPORT_SYMBOL_GPL(devlink_port_type_ib_set); @@ -5405,8 +5403,7 @@ EXPORT_SYMBOL_GPL(devlink_port_type_ib_set); */ void devlink_port_type_clear(struct devlink_port *devlink_port) { - return __devlink_port_type_set(devlink_port, - DEVLINK_PORT_TYPE_NOTSET, NULL); + __devlink_port_type_set(devlink_port, DEVLINK_PORT_TYPE_NOTSET, NULL); } EXPORT_SYMBOL_GPL(devlink_port_type_clear); -- 2.17.2