From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C0CEC43381 for ; Thu, 21 Mar 2019 13:33:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 110772082F for ; Thu, 21 Mar 2019 13:33:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="CesW61Gs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728323AbfCUNdt (ORCPT ); Thu, 21 Mar 2019 09:33:49 -0400 Received: from mail.skyhub.de ([5.9.137.197]:41164 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727857AbfCUNds (ORCPT ); Thu, 21 Mar 2019 09:33:48 -0400 Received: from nazgul.tnic (prg-ext-pat.suse.com [213.151.95.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 69AC81EC02AE; Thu, 21 Mar 2019 14:33:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1553175226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=wSX/OG/9bBzQkBxrQChjO5ACCWfsqwqKYEqfl3wrWq8=; b=CesW61GsSxGgb28plWXH1wuQD8dlYzvIwYd1K98W7EV6Ag+jxwW1ASIE72bWGySGeo8fhb zDqgmZsK16o1LuMgwflw9e8BTIiB9JEX5Gay3EkKdiC8LzMl0hQvomyua+9GURLgtg2KfM VbuBy3XukMN2ATvfdhxrxUEstfdPvZU= Date: Thu, 21 Mar 2019 14:33:40 +0100 From: Borislav Petkov To: Yash Shah Cc: linux-riscv@lists.infradead.org, linux-edac@vger.kernel.org, palmer@sifive.com, paul.walmsley@sifive.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, aou@eecs.berkeley.edu, mchehab@kernel.org, devicetree@vger.kernel.org, sachin.ghadi@sifive.com Subject: Re: [PATCH 2/2] edac: sifive: Add EDAC driver for SiFive FU540-C000 chip Message-ID: <20190321133340.GB7047@nazgul.tnic> References: <1553082728-9232-1-git-send-email-yash.shah@sifive.com> <1553082728-9232-3-git-send-email-yash.shah@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1553082728-9232-3-git-send-email-yash.shah@sifive.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 20, 2019 at 05:22:08PM +0530, Yash Shah wrote: > This EDAC driver supports: > - Initial configuration reporting on bootup via debug logs > - ECC event monitoring and reporting through the EDAC framework > - ECC event injection > > This driver is partially based on pnd2_edac.c and altera_edac.c > > Initially L2 Cache controller is added as a subcomponent to > this EDAC driver. > > Signed-off-by: Yash Shah ... > diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig > index e286b5b..112d9d1 100644 > --- a/drivers/edac/Kconfig > +++ b/drivers/edac/Kconfig > @@ -440,6 +440,19 @@ config EDAC_ALTERA_SDMMC > Support for error detection and correction on the > Altera SDMMC FIFO Memory for Altera SoCs. > > +config EDAC_SIFIVE > + tristate "Sifive ECC" > + depends on RISCV > + help > + Support for error detection and correction on the SiFive SoCs. > + > +config EDAC_SIFIVE_L2 That config item is unused. Drop it. > + bool "SiFive L2 Cache ECC" > + depends on EDAC_SIFIVE=y > + help > + Support for error detection and correction of the L2 cache > + memory on SiFive SoCs. > + > config EDAC_SYNOPSYS > tristate "Synopsys DDR Memory Controller" > depends on ARCH_ZYNQ || ARCH_ZYNQMP ... > +/* > + * sifive_edac_l2_int_handler - ISR function for l2 cache controller > + * @irq: Irq Number > + * @device: Pointer to the edac device controller instance > + * > + * This routine is triggered whenever there is ECC error detected > + * > + * Return: Always returns IRQ_HANDLED > + */ > +static irqreturn_t sifive_edac_l2_int_handler(int irq, void *device) > +{ > + struct edac_device_ctl_info *dci = > + (struct edac_device_ctl_info *)device; No ugly linebreaks like that - just let it stick out even if it is > 80 cols long. > + struct sifive_edac_device_dev *drvdata = dci->pvt_info; > + u32 regval, add_h, add_l; > + > + if (irq == drvdata->irq[dir_corr]) { > + add_h = readl(drvdata->base + SIFIVE_EDAC_DIRFIX_HIGH); > + add_l = readl(drvdata->base + SIFIVE_EDAC_DIRFIX_LOW); > + dev_err(dci->dev, > + "DirError at address 0x%08X.%08X\n", add_h, add_l); Same here and below. > + regval = readl(drvdata->base + SIFIVE_EDAC_DIRFIX_COUNT); > + edac_device_handle_ce(dci, 0, 0, "DirECCFix"); > + } > + if (irq == drvdata->irq[data_corr]) { > + add_h = readl(drvdata->base + SIFIVE_EDAC_DATFIX_HIGH); > + add_l = readl(drvdata->base + SIFIVE_EDAC_DATFIX_LOW); > + dev_err(dci->dev, > + "DataError at address 0x%08X.%08X\n", add_h, add_l); > + regval = readl(drvdata->base + SIFIVE_EDAC_DATFIX_COUNT); > + edac_device_handle_ce(dci, 0, 0, "DatECCFix"); > + } > + if (irq == drvdata->irq[data_uncorr]) { > + add_h = readl(drvdata->base + SIFIVE_EDAC_DATFAIL_HIGH); > + add_l = readl(drvdata->base + SIFIVE_EDAC_DATFAIL_LOW); > + dev_err(dci->dev, > + "DataFail at address 0x%08X.%08X\n", add_h, add_l); > + regval = readl(drvdata->base + SIFIVE_EDAC_DATFAIL_COUNT); > + edac_device_handle_ue(dci, 0, 0, "DatECCFail"); > + } > + > + return IRQ_HANDLED; > +} > + > +static void sifive_edac_l2_config_read(struct edac_device_ctl_info *dci) > +{ > + struct sifive_edac_device_dev *drvdata = dci->pvt_info; > + u32 regval, val; > + > + regval = readl(drvdata->base + SIFIVE_EDAC_CONFIG); > + val = regval & 0xFF; > + dev_info(dci->dev, "No. of Banks in the cache: %d\n", val); > + val = (regval & 0xFF00) >> 8; > + dev_info(dci->dev, "No. of ways per bank: %d\n", val); > + val = (regval & 0xFF0000) >> 16; > + dev_info(dci->dev, "Sets per bank: %llu\n", (uint64_t)1 << val); > + val = (regval & 0xFF000000) >> 24; > + dev_info(dci->dev, > + "Bytes per cache block: %llu\n", (uint64_t)1 << val); > +} > + > +static const struct sifive_edac_device_prv l2ecc_data = { > + .setup = sifive_edac_l2_config_read, > + .inject_fops = &sifive_edac_l2_fops, > + .ecc_irq_handler = sifive_edac_l2_int_handler, > +}; > + > +/* > + * sifive_edac_device_probe() > + * This is a generic EDAC device driver that will support > + * various SiFive memory devices as well as the memories > + * for other peripherals. Module specific initialization is > + * done by passing the function index in the device tree. This comment doesn't have anything to do with that function but rather belongs at the top of this file. > + */ > +static int sifive_edac_device_probe(struct platform_device *pdev) > +{ > + struct edac_device_ctl_info *dci; > + struct sifive_edac_device_dev *drvdata; > + int rc, i; > + struct resource *res; > + void __iomem *baseaddr; > + struct device_node *np = pdev->dev.of_node; > + char *ecc_name = (char *)np->name; > + static int dev_instance; Please sort function local variables declaration in a reverse christmas tree order: longest_variable_name; shorter_var_name; even_shorter; i; > + > + /* Get the data from the platform device */ > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + baseaddr = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(baseaddr)) > + return PTR_ERR(baseaddr); > + > + dci = edac_device_alloc_ctl_info(sizeof(*drvdata), ecc_name, > + 1, ecc_name, 1, 1, NULL, 0, > + dev_instance++); > + if (IS_ERR(dci)) > + return PTR_ERR(dci); > + > + drvdata = dci->pvt_info; > + drvdata->base = baseaddr; > + drvdata->edac_dev_name = ecc_name; > + dci->dev = &pdev->dev; > + dci->mod_name = "Sifive ECC Manager"; > + dci->ctl_name = dev_name(&pdev->dev); > + dci->dev_name = dev_name(&pdev->dev); > + > + /* Get driver specific data for this EDAC device */ > + drvdata->data = of_match_node(sifive_edac_device_of_match, np)->data; > + > + setup_sifive_debug(dci, drvdata->data); > + > + if (drvdata->data->setup) > + drvdata->data->setup(dci); > + > + for (i = 0; i < SIFIVE_EDAC_MAX_INTR; i++) { > + drvdata->irq[i] = platform_get_irq(pdev, i); > + rc = devm_request_irq(&pdev->dev, drvdata->irq[i], > + sifive_edac_l2_int_handler, 0, > + dev_name(&pdev->dev), (void *)dci); > + if (rc) { > + dev_err(&pdev->dev, > + "Could not request IRQ %d\n", drvdata->irq[i]); > + goto del_edac_device; > + } > + } > + > + rc = edac_device_add_device(dci); > + if (rc) { > + dev_err(&pdev->dev, "failed to register with EDAC core\n"); > + goto del_edac_device; > + } Call setup_sifive_debug() in the success case here so that you don't have to teardown below. > + > + return rc; > + > +del_edac_device: > + teardown_sifive_debug(); > + edac_device_del_device(&pdev->dev); > + edac_device_free_ctl_info(dci); Those three can be replaced by a call to sifive_edac_device_remove() ? Btw, you have prefixed your static functions with "sifive_edac_" which doesn't make much sense and you have long names for no good reason. > + > + return rc; > +} > + > +static int sifive_edac_device_remove(struct platform_device *pdev) > +{ > + struct edac_device_ctl_info *dci = platform_get_drvdata(pdev); > + > + teardown_sifive_debug(); > + edac_device_del_device(&pdev->dev); > + edac_device_free_ctl_info(dci); > + > + return 0; > +} > + > +static const struct of_device_id sifive_edac_device_of_match[] = { > + { .compatible = "sifive,ccache0", .data = &l2ecc_data }, > + { /* end of table */ }, > +}; > +MODULE_DEVICE_TABLE(of, sifive_edac_device_of_match); > + > +static struct platform_driver sifive_edac_device_driver = { > + .driver = { > + .name = "sifive_edac_device", "device"? I think it is clear that it is a device and thus kinda tautological. "sifive_edac" should be enough... Last but not least, building this driver with the riscv64 cross compilers from here: http://cdn.kernel.org/pub/tools/crosstool/files/bin/ fails like below. With the riscv32 compiler it fails the same. Provided I'm not doing anything wrong, you should not be sending me half-baked stuff which doesn't even build. drivers/edac/sifive_edac.c: In function 'sifive_edac_device_probe': drivers/edac/sifive_edac.c:231:16: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] drvdata->data = of_match_node(sifive_edac_device_of_match, np)->data; ^ In file included from drivers/edac/sifive_edac.c:10: drivers/edac/sifive_edac.c: At top level: ./include/linux/module.h:130:42: error: redefinition of '__inittest' static inline initcall_t __maybe_unused __inittest(void) \ ^~~~~~~~~~ ./include/linux/device.h:1647:1: note: in expansion of macro 'module_init' module_init(__driver##_init); \ ^~~~~~~~~~~ ./include/linux/platform_device.h:233:2: note: in expansion of macro 'module_driver' module_driver(__platform_driver, platform_driver_register, \ ^~~~~~~~~~~~~ drivers/edac/sifive_edac.c:293:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(sifive_edac_device_driver); ^~~~~~~~~~~~~~~~~~~~~~ ./include/linux/module.h:130:42: note: previous definition of '__inittest' was here static inline initcall_t __maybe_unused __inittest(void) \ ^~~~~~~~~~ ./include/linux/device.h:1647:1: note: in expansion of macro 'module_init' module_init(__driver##_init); \ ^~~~~~~~~~~ ./include/linux/platform_device.h:233:2: note: in expansion of macro 'module_driver' module_driver(__platform_driver, platform_driver_register, \ ^~~~~~~~~~~~~ drivers/edac/sifive_edac.c:57:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(sifive_edac_driver); ^~~~~~~~~~~~~~~~~~~~~~ ./include/linux/module.h:132:6: error: redefinition of 'init_module' int init_module(void) __copy(initfn) __attribute__((alias(#initfn))); ^~~~~~~~~~~ ./include/linux/device.h:1647:1: note: in expansion of macro 'module_init' module_init(__driver##_init); \ ^~~~~~~~~~~ ./include/linux/platform_device.h:233:2: note: in expansion of macro 'module_driver' module_driver(__platform_driver, platform_driver_register, \ ^~~~~~~~~~~~~ drivers/edac/sifive_edac.c:293:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(sifive_edac_device_driver); ^~~~~~~~~~~~~~~~~~~~~~ ./include/linux/module.h:132:6: note: previous definition of 'init_module' was here int init_module(void) __copy(initfn) __attribute__((alias(#initfn))); ^~~~~~~~~~~ ./include/linux/device.h:1647:1: note: in expansion of macro 'module_init' module_init(__driver##_init); \ ^~~~~~~~~~~ ./include/linux/platform_device.h:233:2: note: in expansion of macro 'module_driver' module_driver(__platform_driver, platform_driver_register, \ ^~~~~~~~~~~~~ drivers/edac/sifive_edac.c:57:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(sifive_edac_driver); ^~~~~~~~~~~~~~~~~~~~~~ ./include/linux/module.h:136:42: error: redefinition of '__exittest' static inline exitcall_t __maybe_unused __exittest(void) \ ^~~~~~~~~~ ./include/linux/device.h:1652:1: note: in expansion of macro 'module_exit' module_exit(__driver##_exit); ^~~~~~~~~~~ ./include/linux/platform_device.h:233:2: note: in expansion of macro 'module_driver' module_driver(__platform_driver, platform_driver_register, \ ^~~~~~~~~~~~~ drivers/edac/sifive_edac.c:293:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(sifive_edac_device_driver); ^~~~~~~~~~~~~~~~~~~~~~ ./include/linux/module.h:136:42: note: previous definition of '__exittest' was here static inline exitcall_t __maybe_unused __exittest(void) \ ^~~~~~~~~~ ./include/linux/device.h:1652:1: note: in expansion of macro 'module_exit' module_exit(__driver##_exit); ^~~~~~~~~~~ ./include/linux/platform_device.h:233:2: note: in expansion of macro 'module_driver' module_driver(__platform_driver, platform_driver_register, \ ^~~~~~~~~~~~~ drivers/edac/sifive_edac.c:57:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(sifive_edac_driver); ^~~~~~~~~~~~~~~~~~~~~~ ./include/linux/module.h:138:7: error: redefinition of 'cleanup_module' void cleanup_module(void) __copy(exitfn) __attribute__((alias(#exitfn))); ^~~~~~~~~~~~~~ ./include/linux/device.h:1652:1: note: in expansion of macro 'module_exit' module_exit(__driver##_exit); ^~~~~~~~~~~ ./include/linux/platform_device.h:233:2: note: in expansion of macro 'module_driver' module_driver(__platform_driver, platform_driver_register, \ ^~~~~~~~~~~~~ drivers/edac/sifive_edac.c:293:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(sifive_edac_device_driver); ^~~~~~~~~~~~~~~~~~~~~~ ./include/linux/module.h:138:7: note: previous definition of 'cleanup_module' was here void cleanup_module(void) __copy(exitfn) __attribute__((alias(#exitfn))); ^~~~~~~~~~~~~~ ./include/linux/device.h:1652:1: note: in expansion of macro 'module_exit' module_exit(__driver##_exit); ^~~~~~~~~~~ ./include/linux/platform_device.h:233:2: note: in expansion of macro 'module_driver' module_driver(__platform_driver, platform_driver_register, \ ^~~~~~~~~~~~~ drivers/edac/sifive_edac.c:57:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(sifive_edac_driver); ^~~~~~~~~~~~~~~~~~~~~~ make[3]: *** [scripts/Makefile.build:285: drivers/edac/sifive_edac.o] Error 1 make[2]: *** [scripts/Makefile.build:489: drivers/edac] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/home/boris/kernel/linux-2.6/Makefile:1046: drivers] Error 2 make: *** [Makefile:170: sub-make] Error 2 -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [2/2] edac: sifive: Add EDAC driver for SiFive FU540-C000 chip From: Borislav Petkov Message-Id: <20190321133340.GB7047@nazgul.tnic> Date: Thu, 21 Mar 2019 14:33:40 +0100 To: Yash Shah Cc: linux-riscv@lists.infradead.org, linux-edac@vger.kernel.org, palmer@sifive.com, paul.walmsley@sifive.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, aou@eecs.berkeley.edu, mchehab@kernel.org, devicetree@vger.kernel.org, sachin.ghadi@sifive.com List-ID: T24gV2VkLCBNYXIgMjAsIDIwMTkgYXQgMDU6MjI6MDhQTSArMDUzMCwgWWFzaCBTaGFoIHdyb3Rl Ogo+IFRoaXMgRURBQyBkcml2ZXIgc3VwcG9ydHM6Cj4gLSBJbml0aWFsIGNvbmZpZ3VyYXRpb24g cmVwb3J0aW5nIG9uIGJvb3R1cCB2aWEgZGVidWcgbG9ncwo+IC0gRUNDIGV2ZW50IG1vbml0b3Jp bmcgYW5kIHJlcG9ydGluZyB0aHJvdWdoIHRoZSBFREFDIGZyYW1ld29yawo+IC0gRUNDIGV2ZW50 IGluamVjdGlvbgo+IAo+IFRoaXMgZHJpdmVyIGlzIHBhcnRpYWxseSBiYXNlZCBvbiBwbmQyX2Vk YWMuYyBhbmQgYWx0ZXJhX2VkYWMuYwo+IAo+IEluaXRpYWxseSBMMiBDYWNoZSBjb250cm9sbGVy IGlzIGFkZGVkIGFzIGEgc3ViY29tcG9uZW50IHRvCj4gdGhpcyBFREFDIGRyaXZlci4KPiAKPiBT aWduZWQtb2ZmLWJ5OiBZYXNoIFNoYWggPHlhc2guc2hhaEBzaWZpdmUuY29tPgoKLi4uCgo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2VkYWMvS2NvbmZpZyBiL2RyaXZlcnMvZWRhYy9LY29uZmlnCj4g aW5kZXggZTI4NmI1Yi4uMTEyZDlkMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2VkYWMvS2NvbmZp Zwo+ICsrKyBiL2RyaXZlcnMvZWRhYy9LY29uZmlnCj4gQEAgLTQ0MCw2ICs0NDAsMTkgQEAgY29u ZmlnIEVEQUNfQUxURVJBX1NETU1DCj4gIAkgIFN1cHBvcnQgZm9yIGVycm9yIGRldGVjdGlvbiBh bmQgY29ycmVjdGlvbiBvbiB0aGUKPiAgCSAgQWx0ZXJhIFNETU1DIEZJRk8gTWVtb3J5IGZvciBB bHRlcmEgU29Dcy4KPiAgCj4gK2NvbmZpZyBFREFDX1NJRklWRQo+ICsJdHJpc3RhdGUgIlNpZml2 ZSBFQ0MiCj4gKwlkZXBlbmRzIG9uIFJJU0NWCj4gKwloZWxwCj4gKwkgIFN1cHBvcnQgZm9yIGVy cm9yIGRldGVjdGlvbiBhbmQgY29ycmVjdGlvbiBvbiB0aGUgU2lGaXZlIFNvQ3MuCj4gKwo+ICtj b25maWcgRURBQ19TSUZJVkVfTDIKClRoYXQgY29uZmlnIGl0ZW0gaXMgdW51c2VkLiBEcm9wIGl0 LgoKPiArCWJvb2wgIlNpRml2ZSBMMiBDYWNoZSBFQ0MiCj4gKwlkZXBlbmRzIG9uIEVEQUNfU0lG SVZFPXkKPiArCWhlbHAKPiArCSAgU3VwcG9ydCBmb3IgZXJyb3IgZGV0ZWN0aW9uIGFuZCBjb3Jy ZWN0aW9uIG9mIHRoZSBMMiBjYWNoZQo+ICsJICBtZW1vcnkgb24gU2lGaXZlIFNvQ3MuCj4gKwo+ ICBjb25maWcgRURBQ19TWU5PUFNZUwo+ICAJdHJpc3RhdGUgIlN5bm9wc3lzIEREUiBNZW1vcnkg Q29udHJvbGxlciIKPiAgCWRlcGVuZHMgb24gQVJDSF9aWU5RIHx8IEFSQ0hfWllOUU1QCgouLi4K Cj4gKy8qCj4gKyAqIHNpZml2ZV9lZGFjX2wyX2ludF9oYW5kbGVyIC0gSVNSIGZ1bmN0aW9uIGZv ciBsMiBjYWNoZSBjb250cm9sbGVyCj4gKyAqIEBpcnE6CUlycSBOdW1iZXIKPiArICogQGRldmlj ZToJUG9pbnRlciB0byB0aGUgZWRhYyBkZXZpY2UgY29udHJvbGxlciBpbnN0YW5jZQo+ICsgKgo+ ICsgKiBUaGlzIHJvdXRpbmUgaXMgdHJpZ2dlcmVkIHdoZW5ldmVyIHRoZXJlIGlzIEVDQyBlcnJv ciBkZXRlY3RlZAo+ICsgKgo+ICsgKiBSZXR1cm46IEFsd2F5cyByZXR1cm5zIElSUV9IQU5ETEVE Cj4gKyAqLwo+ICtzdGF0aWMgaXJxcmV0dXJuX3Qgc2lmaXZlX2VkYWNfbDJfaW50X2hhbmRsZXIo aW50IGlycSwgdm9pZCAqZGV2aWNlKQo+ICt7Cj4gKwlzdHJ1Y3QgZWRhY19kZXZpY2VfY3RsX2lu Zm8gKmRjaSA9Cj4gKwkJCQkJKHN0cnVjdCBlZGFjX2RldmljZV9jdGxfaW5mbyAqKWRldmljZTsK Ck5vIHVnbHkgbGluZWJyZWFrcyBsaWtlIHRoYXQgLSBqdXN0IGxldCBpdCBzdGljayBvdXQgZXZl biBpZiBpdCBpcyA+IDgwCmNvbHMgbG9uZy4KCj4gKwlzdHJ1Y3Qgc2lmaXZlX2VkYWNfZGV2aWNl X2RldiAqZHJ2ZGF0YSA9IGRjaS0+cHZ0X2luZm87Cj4gKwl1MzIgcmVndmFsLCBhZGRfaCwgYWRk X2w7Cj4gKwo+ICsJaWYgKGlycSA9PSBkcnZkYXRhLT5pcnFbZGlyX2NvcnJdKSB7Cj4gKwkJYWRk X2ggPSByZWFkbChkcnZkYXRhLT5iYXNlICsgU0lGSVZFX0VEQUNfRElSRklYX0hJR0gpOwo+ICsJ CWFkZF9sID0gcmVhZGwoZHJ2ZGF0YS0+YmFzZSArIFNJRklWRV9FREFDX0RJUkZJWF9MT1cpOwo+ ICsJCWRldl9lcnIoZGNpLT5kZXYsCj4gKwkJCSJEaXJFcnJvciBhdCBhZGRyZXNzIDB4JTA4WC4l MDhYXG4iLCBhZGRfaCwgYWRkX2wpOwoKU2FtZSBoZXJlIGFuZCBiZWxvdy4KCj4gKwkJcmVndmFs ID0gcmVhZGwoZHJ2ZGF0YS0+YmFzZSArIFNJRklWRV9FREFDX0RJUkZJWF9DT1VOVCk7Cj4gKwkJ ZWRhY19kZXZpY2VfaGFuZGxlX2NlKGRjaSwgMCwgMCwgIkRpckVDQ0ZpeCIpOwo+ICsJfQo+ICsJ aWYgKGlycSA9PSBkcnZkYXRhLT5pcnFbZGF0YV9jb3JyXSkgewo+ICsJCWFkZF9oID0gcmVhZGwo ZHJ2ZGF0YS0+YmFzZSArIFNJRklWRV9FREFDX0RBVEZJWF9ISUdIKTsKPiArCQlhZGRfbCA9IHJl YWRsKGRydmRhdGEtPmJhc2UgKyBTSUZJVkVfRURBQ19EQVRGSVhfTE9XKTsKPiArCQlkZXZfZXJy KGRjaS0+ZGV2LAo+ICsJCQkiRGF0YUVycm9yIGF0IGFkZHJlc3MgMHglMDhYLiUwOFhcbiIsIGFk ZF9oLCBhZGRfbCk7Cj4gKwkJcmVndmFsID0gcmVhZGwoZHJ2ZGF0YS0+YmFzZSArIFNJRklWRV9F REFDX0RBVEZJWF9DT1VOVCk7Cj4gKwkJZWRhY19kZXZpY2VfaGFuZGxlX2NlKGRjaSwgMCwgMCwg IkRhdEVDQ0ZpeCIpOwo+ICsJfQo+ICsJaWYgKGlycSA9PSBkcnZkYXRhLT5pcnFbZGF0YV91bmNv cnJdKSB7Cj4gKwkJYWRkX2ggPSByZWFkbChkcnZkYXRhLT5iYXNlICsgU0lGSVZFX0VEQUNfREFU RkFJTF9ISUdIKTsKPiArCQlhZGRfbCA9IHJlYWRsKGRydmRhdGEtPmJhc2UgKyBTSUZJVkVfRURB Q19EQVRGQUlMX0xPVyk7Cj4gKwkJZGV2X2VycihkY2ktPmRldiwKPiArCQkJIkRhdGFGYWlsIGF0 IGFkZHJlc3MgMHglMDhYLiUwOFhcbiIsIGFkZF9oLCBhZGRfbCk7Cj4gKwkJcmVndmFsID0gcmVh ZGwoZHJ2ZGF0YS0+YmFzZSArIFNJRklWRV9FREFDX0RBVEZBSUxfQ09VTlQpOwo+ICsJCWVkYWNf ZGV2aWNlX2hhbmRsZV91ZShkY2ksIDAsIDAsICJEYXRFQ0NGYWlsIik7Cj4gKwl9Cj4gKwo+ICsJ cmV0dXJuIElSUV9IQU5ETEVEOwo+ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZCBzaWZpdmVfZWRhY19s Ml9jb25maWdfcmVhZChzdHJ1Y3QgZWRhY19kZXZpY2VfY3RsX2luZm8gKmRjaSkKPiArewo+ICsJ c3RydWN0IHNpZml2ZV9lZGFjX2RldmljZV9kZXYgKmRydmRhdGEgPSBkY2ktPnB2dF9pbmZvOwo+ ICsJdTMyIHJlZ3ZhbCwgdmFsOwo+ICsKPiArCXJlZ3ZhbCA9IHJlYWRsKGRydmRhdGEtPmJhc2Ug KyBTSUZJVkVfRURBQ19DT05GSUcpOwo+ICsJdmFsID0gcmVndmFsICYgMHhGRjsKPiArCWRldl9p bmZvKGRjaS0+ZGV2LCAiTm8uIG9mIEJhbmtzIGluIHRoZSBjYWNoZTogJWRcbiIsIHZhbCk7Cj4g Kwl2YWwgPSAocmVndmFsICYgMHhGRjAwKSA+PiA4Owo+ICsJZGV2X2luZm8oZGNpLT5kZXYsICJO by4gb2Ygd2F5cyBwZXIgYmFuazogJWRcbiIsIHZhbCk7Cj4gKwl2YWwgPSAocmVndmFsICYgMHhG RjAwMDApID4+IDE2Owo+ICsJZGV2X2luZm8oZGNpLT5kZXYsICJTZXRzIHBlciBiYW5rOiAlbGx1 XG4iLCAodWludDY0X3QpMSA8PCB2YWwpOwo+ICsJdmFsID0gKHJlZ3ZhbCAmIDB4RkYwMDAwMDAp ID4+IDI0Owo+ICsJZGV2X2luZm8oZGNpLT5kZXYsCj4gKwkJICJCeXRlcyBwZXIgY2FjaGUgYmxv Y2s6ICVsbHVcbiIsICh1aW50NjRfdCkxIDw8IHZhbCk7Cj4gK30KPiArCj4gK3N0YXRpYyBjb25z dCBzdHJ1Y3Qgc2lmaXZlX2VkYWNfZGV2aWNlX3BydiBsMmVjY19kYXRhID0gewo+ICsJLnNldHVw ID0gc2lmaXZlX2VkYWNfbDJfY29uZmlnX3JlYWQsCj4gKwkuaW5qZWN0X2ZvcHMgPSAmc2lmaXZl X2VkYWNfbDJfZm9wcywKPiArCS5lY2NfaXJxX2hhbmRsZXIgPSBzaWZpdmVfZWRhY19sMl9pbnRf aGFuZGxlciwKPiArfTsKPiArCj4gKy8qCj4gKyAqIHNpZml2ZV9lZGFjX2RldmljZV9wcm9iZSgp Cj4gKyAqCVRoaXMgaXMgYSBnZW5lcmljIEVEQUMgZGV2aWNlIGRyaXZlciB0aGF0IHdpbGwgc3Vw cG9ydAo+ICsgKgl2YXJpb3VzIFNpRml2ZSBtZW1vcnkgZGV2aWNlcyBhcyB3ZWxsIGFzIHRoZSBt ZW1vcmllcwo+ICsgKglmb3Igb3RoZXIgcGVyaXBoZXJhbHMuIE1vZHVsZSBzcGVjaWZpYyBpbml0 aWFsaXphdGlvbiBpcwo+ICsgKglkb25lIGJ5IHBhc3NpbmcgdGhlIGZ1bmN0aW9uIGluZGV4IGlu IHRoZSBkZXZpY2UgdHJlZS4KClRoaXMgY29tbWVudCBkb2Vzbid0IGhhdmUgYW55dGhpbmcgdG8g ZG8gd2l0aCB0aGF0IGZ1bmN0aW9uIGJ1dCByYXRoZXIKYmVsb25ncyBhdCB0aGUgdG9wIG9mIHRo aXMgZmlsZS4KCj4gKyAqLwo+ICtzdGF0aWMgaW50IHNpZml2ZV9lZGFjX2RldmljZV9wcm9iZShz dHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICt7Cj4gKwlzdHJ1Y3QgZWRhY19kZXZpY2Vf Y3RsX2luZm8gKmRjaTsKPiArCXN0cnVjdCBzaWZpdmVfZWRhY19kZXZpY2VfZGV2ICpkcnZkYXRh Owo+ICsJaW50IHJjLCBpOwo+ICsJc3RydWN0IHJlc291cmNlICpyZXM7Cj4gKwl2b2lkIF9faW9t ZW0gKmJhc2VhZGRyOwo+ICsJc3RydWN0IGRldmljZV9ub2RlICpucCA9IHBkZXYtPmRldi5vZl9u b2RlOwo+ICsJY2hhciAqZWNjX25hbWUgPSAoY2hhciAqKW5wLT5uYW1lOwo+ICsJc3RhdGljIGlu dCBkZXZfaW5zdGFuY2U7CgpQbGVhc2Ugc29ydCBmdW5jdGlvbiBsb2NhbCB2YXJpYWJsZXMgZGVj bGFyYXRpb24gaW4gYSByZXZlcnNlIGNocmlzdG1hcwp0cmVlIG9yZGVyOgoKCTx0eXBlX2E+IGxv bmdlc3RfdmFyaWFibGVfbmFtZTsKCTx0eXBlX2I+IHNob3J0ZXJfdmFyX25hbWU7Cgk8dHlwZV9j PiBldmVuX3Nob3J0ZXI7Cgk8dHlwZV9kPiBpOwoKPiArCj4gKwkvKiBHZXQgdGhlIGRhdGEgZnJv bSB0aGUgcGxhdGZvcm0gZGV2aWNlICovCj4gKwlyZXMgPSBwbGF0Zm9ybV9nZXRfcmVzb3VyY2Uo cGRldiwgSU9SRVNPVVJDRV9NRU0sIDApOwo+ICsJYmFzZWFkZHIgPSBkZXZtX2lvcmVtYXBfcmVz b3VyY2UoJnBkZXYtPmRldiwgcmVzKTsKPiArCWlmIChJU19FUlIoYmFzZWFkZHIpKQo+ICsJCXJl dHVybiBQVFJfRVJSKGJhc2VhZGRyKTsKPiArCj4gKwlkY2kgPSBlZGFjX2RldmljZV9hbGxvY19j dGxfaW5mbyhzaXplb2YoKmRydmRhdGEpLCBlY2NfbmFtZSwKPiArCQkJCQkgMSwgZWNjX25hbWUs IDEsIDEsIE5VTEwsIDAsCj4gKwkJCQkJIGRldl9pbnN0YW5jZSsrKTsKPiArCWlmIChJU19FUlIo ZGNpKSkKPiArCQlyZXR1cm4gUFRSX0VSUihkY2kpOwo+ICsKPiArCWRydmRhdGEgPSBkY2ktPnB2 dF9pbmZvOwo+ICsJZHJ2ZGF0YS0+YmFzZSA9IGJhc2VhZGRyOwo+ICsJZHJ2ZGF0YS0+ZWRhY19k ZXZfbmFtZSA9IGVjY19uYW1lOwo+ICsJZGNpLT5kZXYgPSAmcGRldi0+ZGV2Owo+ICsJZGNpLT5t b2RfbmFtZSA9ICJTaWZpdmUgRUNDIE1hbmFnZXIiOwo+ICsJZGNpLT5jdGxfbmFtZSA9IGRldl9u YW1lKCZwZGV2LT5kZXYpOwo+ICsJZGNpLT5kZXZfbmFtZSA9IGRldl9uYW1lKCZwZGV2LT5kZXYp Owo+ICsKPiArCSAvKiBHZXQgZHJpdmVyIHNwZWNpZmljIGRhdGEgZm9yIHRoaXMgRURBQyBkZXZp Y2UgKi8KPiArCWRydmRhdGEtPmRhdGEgPSBvZl9tYXRjaF9ub2RlKHNpZml2ZV9lZGFjX2Rldmlj ZV9vZl9tYXRjaCwgbnApLT5kYXRhOwo+ICsKPiArCXNldHVwX3NpZml2ZV9kZWJ1ZyhkY2ksIGRy dmRhdGEtPmRhdGEpOwo+ICsKPiArCWlmIChkcnZkYXRhLT5kYXRhLT5zZXR1cCkKPiArCQlkcnZk YXRhLT5kYXRhLT5zZXR1cChkY2kpOwo+ICsKPiArCWZvciAoaSA9IDA7IGkgPCBTSUZJVkVfRURB Q19NQVhfSU5UUjsgaSsrKSB7Cj4gKwkJZHJ2ZGF0YS0+aXJxW2ldID0gcGxhdGZvcm1fZ2V0X2ly cShwZGV2LCBpKTsKPiArCQlyYyA9IGRldm1fcmVxdWVzdF9pcnEoJnBkZXYtPmRldiwgZHJ2ZGF0 YS0+aXJxW2ldLAo+ICsJCQkJICAgICAgc2lmaXZlX2VkYWNfbDJfaW50X2hhbmRsZXIsIDAsCj4g KwkJCQkgICAgICBkZXZfbmFtZSgmcGRldi0+ZGV2KSwgKHZvaWQgKilkY2kpOwo+ICsJCWlmIChy Yykgewo+ICsJCQlkZXZfZXJyKCZwZGV2LT5kZXYsCj4gKwkJCQkiQ291bGQgbm90IHJlcXVlc3Qg SVJRICVkXG4iLCBkcnZkYXRhLT5pcnFbaV0pOwo+ICsJCQlnb3RvIGRlbF9lZGFjX2RldmljZTsK PiArCQl9Cj4gKwl9Cj4gKwo+ICsJcmMgPSBlZGFjX2RldmljZV9hZGRfZGV2aWNlKGRjaSk7Cj4g KwlpZiAocmMpIHsKPiArCQlkZXZfZXJyKCZwZGV2LT5kZXYsICJmYWlsZWQgdG8gcmVnaXN0ZXIg d2l0aCBFREFDIGNvcmVcbiIpOwo+ICsJCWdvdG8gZGVsX2VkYWNfZGV2aWNlOwo+ICsJfQoKQ2Fs bCBzZXR1cF9zaWZpdmVfZGVidWcoKSBpbiB0aGUgc3VjY2VzcyBjYXNlIGhlcmUgc28gdGhhdCB5 b3UgZG9uJ3QKaGF2ZSB0byB0ZWFyZG93biBiZWxvdy4KCj4gKwo+ICsJcmV0dXJuIHJjOwo+ICsK PiArZGVsX2VkYWNfZGV2aWNlOgo+ICsJdGVhcmRvd25fc2lmaXZlX2RlYnVnKCk7Cj4gKwllZGFj X2RldmljZV9kZWxfZGV2aWNlKCZwZGV2LT5kZXYpOwo+ICsJZWRhY19kZXZpY2VfZnJlZV9jdGxf aW5mbyhkY2kpOwoKVGhvc2UgdGhyZWUgY2FuIGJlIHJlcGxhY2VkIGJ5IGEgY2FsbCB0byBzaWZp dmVfZWRhY19kZXZpY2VfcmVtb3ZlKCkgPwoKQnR3LCB5b3UgaGF2ZSBwcmVmaXhlZCB5b3VyIHN0 YXRpYyBmdW5jdGlvbnMgd2l0aCAic2lmaXZlX2VkYWNfIiB3aGljaApkb2Vzbid0IG1ha2UgbXVj aCBzZW5zZSBhbmQgeW91IGhhdmUgbG9uZyBuYW1lcyBmb3Igbm8gZ29vZCByZWFzb24uCgo+ICsK PiArCXJldHVybiByYzsKPiArfQo+ICsKPiArc3RhdGljIGludCBzaWZpdmVfZWRhY19kZXZpY2Vf cmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gK3sKPiArCXN0cnVjdCBlZGFj X2RldmljZV9jdGxfaW5mbyAqZGNpID0gcGxhdGZvcm1fZ2V0X2RydmRhdGEocGRldik7Cj4gKwo+ ICsJdGVhcmRvd25fc2lmaXZlX2RlYnVnKCk7Cj4gKwllZGFjX2RldmljZV9kZWxfZGV2aWNlKCZw ZGV2LT5kZXYpOwo+ICsJZWRhY19kZXZpY2VfZnJlZV9jdGxfaW5mbyhkY2kpOwo+ICsKPiArCXJl dHVybiAwOwo+ICt9Cj4gKwo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBzaWZp dmVfZWRhY19kZXZpY2Vfb2ZfbWF0Y2hbXSA9IHsKPiArCXsgLmNvbXBhdGlibGUgPSAic2lmaXZl LGNjYWNoZTAiLCAuZGF0YSA9ICZsMmVjY19kYXRhIH0sCj4gKwl7IC8qIGVuZCBvZiB0YWJsZSAq LyB9LAo+ICt9Owo+ICtNT0RVTEVfREVWSUNFX1RBQkxFKG9mLCBzaWZpdmVfZWRhY19kZXZpY2Vf b2ZfbWF0Y2gpOwo+ICsKPiArc3RhdGljIHN0cnVjdCBwbGF0Zm9ybV9kcml2ZXIgc2lmaXZlX2Vk YWNfZGV2aWNlX2RyaXZlciA9IHsKPiArCS5kcml2ZXIgPSB7Cj4gKwkJIC5uYW1lID0gInNpZml2 ZV9lZGFjX2RldmljZSIsCgoiZGV2aWNlIj8gSSB0aGluayBpdCBpcyBjbGVhciB0aGF0IGl0IGlz IGEgZGV2aWNlIGFuZCB0aHVzIGtpbmRhCnRhdXRvbG9naWNhbC4gInNpZml2ZV9lZGFjIiBzaG91 bGQgYmUgZW5vdWdoLi4uCgpMYXN0IGJ1dCBub3QgbGVhc3QsIGJ1aWxkaW5nIHRoaXMgZHJpdmVy IHdpdGggdGhlIHJpc2N2NjQgY3Jvc3MgY29tcGlsZXJzIGZyb20KaGVyZToKCmh0dHA6Ly9jZG4u a2VybmVsLm9yZy9wdWIvdG9vbHMvY3Jvc3N0b29sL2ZpbGVzL2Jpbi8KCmZhaWxzIGxpa2UgYmVs b3cuIFdpdGggdGhlIHJpc2N2MzIgY29tcGlsZXIgaXQgZmFpbHMgdGhlIHNhbWUuCgpQcm92aWRl ZCBJJ20gbm90IGRvaW5nIGFueXRoaW5nIHdyb25nLCB5b3Ugc2hvdWxkIG5vdCBiZSBzZW5kaW5n IG1lCmhhbGYtYmFrZWQgc3R1ZmYgd2hpY2ggZG9lc24ndCBldmVuIGJ1aWxkLgoKZHJpdmVycy9l ZGFjL3NpZml2ZV9lZGFjLmM6IEluIGZ1bmN0aW9uICdzaWZpdmVfZWRhY19kZXZpY2VfcHJvYmUn Ogpkcml2ZXJzL2VkYWMvc2lmaXZlX2VkYWMuYzoyMzE6MTY6IHdhcm5pbmc6IGFzc2lnbm1lbnQg ZGlzY2FyZHMgJ2NvbnN0JyBxdWFsaWZpZXIgZnJvbSBwb2ludGVyIHRhcmdldCB0eXBlIFstV2Rp c2NhcmRlZC1xdWFsaWZpZXJzXQogIGRydmRhdGEtPmRhdGEgPSBvZl9tYXRjaF9ub2RlKHNpZml2 ZV9lZGFjX2RldmljZV9vZl9tYXRjaCwgbnApLT5kYXRhOwogICAgICAgICAgICAgICAgXgpJbiBm aWxlIGluY2x1ZGVkIGZyb20gZHJpdmVycy9lZGFjL3NpZml2ZV9lZGFjLmM6MTA6CmRyaXZlcnMv ZWRhYy9zaWZpdmVfZWRhYy5jOiBBdCB0b3AgbGV2ZWw6Ci4vaW5jbHVkZS9saW51eC9tb2R1bGUu aDoxMzA6NDI6IGVycm9yOiByZWRlZmluaXRpb24gb2YgJ19faW5pdHRlc3QnCiAgc3RhdGljIGlu bGluZSBpbml0Y2FsbF90IF9fbWF5YmVfdW51c2VkIF9faW5pdHRlc3Qodm9pZCkgIFwKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXn5+fn5+fn5+fgouL2luY2x1ZGUv bGludXgvZGV2aWNlLmg6MTY0NzoxOiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8gJ21vZHVs ZV9pbml0JwogbW9kdWxlX2luaXQoX19kcml2ZXIjI19pbml0KTsgXAogXn5+fn5+fn5+fn4KLi9p bmNsdWRlL2xpbnV4L3BsYXRmb3JtX2RldmljZS5oOjIzMzoyOiBub3RlOiBpbiBleHBhbnNpb24g b2YgbWFjcm8gJ21vZHVsZV9kcml2ZXInCiAgbW9kdWxlX2RyaXZlcihfX3BsYXRmb3JtX2RyaXZl ciwgcGxhdGZvcm1fZHJpdmVyX3JlZ2lzdGVyLCBcCiAgXn5+fn5+fn5+fn5+fgpkcml2ZXJzL2Vk YWMvc2lmaXZlX2VkYWMuYzoyOTM6MTogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvICdtb2R1 bGVfcGxhdGZvcm1fZHJpdmVyJwogbW9kdWxlX3BsYXRmb3JtX2RyaXZlcihzaWZpdmVfZWRhY19k ZXZpY2VfZHJpdmVyKTsKIF5+fn5+fn5+fn5+fn5+fn5+fn5+fn4KLi9pbmNsdWRlL2xpbnV4L21v ZHVsZS5oOjEzMDo0Mjogbm90ZTogcHJldmlvdXMgZGVmaW5pdGlvbiBvZiAnX19pbml0dGVzdCcg d2FzIGhlcmUKICBzdGF0aWMgaW5saW5lIGluaXRjYWxsX3QgX19tYXliZV91bnVzZWQgX19pbml0 dGVzdCh2b2lkKSAgXAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBe fn5+fn5+fn5+Ci4vaW5jbHVkZS9saW51eC9kZXZpY2UuaDoxNjQ3OjE6IG5vdGU6IGluIGV4cGFu c2lvbiBvZiBtYWNybyAnbW9kdWxlX2luaXQnCiBtb2R1bGVfaW5pdChfX2RyaXZlciMjX2luaXQp OyBcCiBefn5+fn5+fn5+fgouL2luY2x1ZGUvbGludXgvcGxhdGZvcm1fZGV2aWNlLmg6MjMzOjI6 IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyAnbW9kdWxlX2RyaXZlcicKICBtb2R1bGVfZHJp dmVyKF9fcGxhdGZvcm1fZHJpdmVyLCBwbGF0Zm9ybV9kcml2ZXJfcmVnaXN0ZXIsIFwKICBefn5+ fn5+fn5+fn5+CmRyaXZlcnMvZWRhYy9zaWZpdmVfZWRhYy5jOjU3OjE6IG5vdGU6IGluIGV4cGFu c2lvbiBvZiBtYWNybyAnbW9kdWxlX3BsYXRmb3JtX2RyaXZlcicKIG1vZHVsZV9wbGF0Zm9ybV9k cml2ZXIoc2lmaXZlX2VkYWNfZHJpdmVyKTsKIF5+fn5+fn5+fn5+fn5+fn5+fn5+fn4KLi9pbmNs dWRlL2xpbnV4L21vZHVsZS5oOjEzMjo2OiBlcnJvcjogcmVkZWZpbml0aW9uIG9mICdpbml0X21v ZHVsZScKICBpbnQgaW5pdF9tb2R1bGUodm9pZCkgX19jb3B5KGluaXRmbikgX19hdHRyaWJ1dGVf XygoYWxpYXMoI2luaXRmbikpKTsKICAgICAgXn5+fn5+fn5+fn4KLi9pbmNsdWRlL2xpbnV4L2Rl dmljZS5oOjE2NDc6MTogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvICdtb2R1bGVfaW5pdCcK IG1vZHVsZV9pbml0KF9fZHJpdmVyIyNfaW5pdCk7IFwKIF5+fn5+fn5+fn5+Ci4vaW5jbHVkZS9s aW51eC9wbGF0Zm9ybV9kZXZpY2UuaDoyMzM6Mjogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3Jv ICdtb2R1bGVfZHJpdmVyJwogIG1vZHVsZV9kcml2ZXIoX19wbGF0Zm9ybV9kcml2ZXIsIHBsYXRm b3JtX2RyaXZlcl9yZWdpc3RlciwgXAogIF5+fn5+fn5+fn5+fn4KZHJpdmVycy9lZGFjL3NpZml2 ZV9lZGFjLmM6MjkzOjE6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyAnbW9kdWxlX3BsYXRm b3JtX2RyaXZlcicKIG1vZHVsZV9wbGF0Zm9ybV9kcml2ZXIoc2lmaXZlX2VkYWNfZGV2aWNlX2Ry aXZlcik7CiBefn5+fn5+fn5+fn5+fn5+fn5+fn5+Ci4vaW5jbHVkZS9saW51eC9tb2R1bGUuaDox MzI6Njogbm90ZTogcHJldmlvdXMgZGVmaW5pdGlvbiBvZiAnaW5pdF9tb2R1bGUnIHdhcyBoZXJl CiAgaW50IGluaXRfbW9kdWxlKHZvaWQpIF9fY29weShpbml0Zm4pIF9fYXR0cmlidXRlX18oKGFs aWFzKCNpbml0Zm4pKSk7CiAgICAgIF5+fn5+fn5+fn5+Ci4vaW5jbHVkZS9saW51eC9kZXZpY2Uu aDoxNjQ3OjE6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyAnbW9kdWxlX2luaXQnCiBtb2R1 bGVfaW5pdChfX2RyaXZlciMjX2luaXQpOyBcCiBefn5+fn5+fn5+fgouL2luY2x1ZGUvbGludXgv cGxhdGZvcm1fZGV2aWNlLmg6MjMzOjI6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyAnbW9k dWxlX2RyaXZlcicKICBtb2R1bGVfZHJpdmVyKF9fcGxhdGZvcm1fZHJpdmVyLCBwbGF0Zm9ybV9k cml2ZXJfcmVnaXN0ZXIsIFwKICBefn5+fn5+fn5+fn5+CmRyaXZlcnMvZWRhYy9zaWZpdmVfZWRh Yy5jOjU3OjE6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyAnbW9kdWxlX3BsYXRmb3JtX2Ry aXZlcicKIG1vZHVsZV9wbGF0Zm9ybV9kcml2ZXIoc2lmaXZlX2VkYWNfZHJpdmVyKTsKIF5+fn5+ fn5+fn5+fn5+fn5+fn5+fn4KLi9pbmNsdWRlL2xpbnV4L21vZHVsZS5oOjEzNjo0MjogZXJyb3I6 IHJlZGVmaW5pdGlvbiBvZiAnX19leGl0dGVzdCcKICBzdGF0aWMgaW5saW5lIGV4aXRjYWxsX3Qg X19tYXliZV91bnVzZWQgX19leGl0dGVzdCh2b2lkKSAgXAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBefn5+fn5+fn5+Ci4vaW5jbHVkZS9saW51eC9kZXZpY2UuaDox NjUyOjE6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyAnbW9kdWxlX2V4aXQnCiBtb2R1bGVf ZXhpdChfX2RyaXZlciMjX2V4aXQpOwogXn5+fn5+fn5+fn4KLi9pbmNsdWRlL2xpbnV4L3BsYXRm b3JtX2RldmljZS5oOjIzMzoyOiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8gJ21vZHVsZV9k cml2ZXInCiAgbW9kdWxlX2RyaXZlcihfX3BsYXRmb3JtX2RyaXZlciwgcGxhdGZvcm1fZHJpdmVy X3JlZ2lzdGVyLCBcCiAgXn5+fn5+fn5+fn5+fgpkcml2ZXJzL2VkYWMvc2lmaXZlX2VkYWMuYzoy OTM6MTogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvICdtb2R1bGVfcGxhdGZvcm1fZHJpdmVy JwogbW9kdWxlX3BsYXRmb3JtX2RyaXZlcihzaWZpdmVfZWRhY19kZXZpY2VfZHJpdmVyKTsKIF5+ fn5+fn5+fn5+fn5+fn5+fn5+fn4KLi9pbmNsdWRlL2xpbnV4L21vZHVsZS5oOjEzNjo0Mjogbm90 ZTogcHJldmlvdXMgZGVmaW5pdGlvbiBvZiAnX19leGl0dGVzdCcgd2FzIGhlcmUKICBzdGF0aWMg aW5saW5lIGV4aXRjYWxsX3QgX19tYXliZV91bnVzZWQgX19leGl0dGVzdCh2b2lkKSAgXAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBefn5+fn5+fn5+Ci4vaW5jbHVk ZS9saW51eC9kZXZpY2UuaDoxNjUyOjE6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyAnbW9k dWxlX2V4aXQnCiBtb2R1bGVfZXhpdChfX2RyaXZlciMjX2V4aXQpOwogXn5+fn5+fn5+fn4KLi9p bmNsdWRlL2xpbnV4L3BsYXRmb3JtX2RldmljZS5oOjIzMzoyOiBub3RlOiBpbiBleHBhbnNpb24g b2YgbWFjcm8gJ21vZHVsZV9kcml2ZXInCiAgbW9kdWxlX2RyaXZlcihfX3BsYXRmb3JtX2RyaXZl ciwgcGxhdGZvcm1fZHJpdmVyX3JlZ2lzdGVyLCBcCiAgXn5+fn5+fn5+fn5+fgpkcml2ZXJzL2Vk YWMvc2lmaXZlX2VkYWMuYzo1NzoxOiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8gJ21vZHVs ZV9wbGF0Zm9ybV9kcml2ZXInCiBtb2R1bGVfcGxhdGZvcm1fZHJpdmVyKHNpZml2ZV9lZGFjX2Ry aXZlcik7CiBefn5+fn5+fn5+fn5+fn5+fn5+fn5+Ci4vaW5jbHVkZS9saW51eC9tb2R1bGUuaDox Mzg6NzogZXJyb3I6IHJlZGVmaW5pdGlvbiBvZiAnY2xlYW51cF9tb2R1bGUnCiAgdm9pZCBjbGVh bnVwX21vZHVsZSh2b2lkKSBfX2NvcHkoZXhpdGZuKSBfX2F0dHJpYnV0ZV9fKChhbGlhcygjZXhp dGZuKSkpOwogICAgICAgXn5+fn5+fn5+fn5+fn4KLi9pbmNsdWRlL2xpbnV4L2RldmljZS5oOjE2 NTI6MTogbm90ZTogaW4gZXhwYW5zaW9uIG9mIG1hY3JvICdtb2R1bGVfZXhpdCcKIG1vZHVsZV9l eGl0KF9fZHJpdmVyIyNfZXhpdCk7CiBefn5+fn5+fn5+fgouL2luY2x1ZGUvbGludXgvcGxhdGZv cm1fZGV2aWNlLmg6MjMzOjI6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyAnbW9kdWxlX2Ry aXZlcicKICBtb2R1bGVfZHJpdmVyKF9fcGxhdGZvcm1fZHJpdmVyLCBwbGF0Zm9ybV9kcml2ZXJf cmVnaXN0ZXIsIFwKICBefn5+fn5+fn5+fn5+CmRyaXZlcnMvZWRhYy9zaWZpdmVfZWRhYy5jOjI5 MzoxOiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8gJ21vZHVsZV9wbGF0Zm9ybV9kcml2ZXIn CiBtb2R1bGVfcGxhdGZvcm1fZHJpdmVyKHNpZml2ZV9lZGFjX2RldmljZV9kcml2ZXIpOwogXn5+ fn5+fn5+fn5+fn5+fn5+fn5+fgouL2luY2x1ZGUvbGludXgvbW9kdWxlLmg6MTM4Ojc6IG5vdGU6 IHByZXZpb3VzIGRlZmluaXRpb24gb2YgJ2NsZWFudXBfbW9kdWxlJyB3YXMgaGVyZQogIHZvaWQg Y2xlYW51cF9tb2R1bGUodm9pZCkgX19jb3B5KGV4aXRmbikgX19hdHRyaWJ1dGVfXygoYWxpYXMo I2V4aXRmbikpKTsKICAgICAgIF5+fn5+fn5+fn5+fn5+Ci4vaW5jbHVkZS9saW51eC9kZXZpY2Uu aDoxNjUyOjE6IG5vdGU6IGluIGV4cGFuc2lvbiBvZiBtYWNybyAnbW9kdWxlX2V4aXQnCiBtb2R1 bGVfZXhpdChfX2RyaXZlciMjX2V4aXQpOwogXn5+fn5+fn5+fn4KLi9pbmNsdWRlL2xpbnV4L3Bs YXRmb3JtX2RldmljZS5oOjIzMzoyOiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8gJ21vZHVs ZV9kcml2ZXInCiAgbW9kdWxlX2RyaXZlcihfX3BsYXRmb3JtX2RyaXZlciwgcGxhdGZvcm1fZHJp dmVyX3JlZ2lzdGVyLCBcCiAgXn5+fn5+fn5+fn5+fgpkcml2ZXJzL2VkYWMvc2lmaXZlX2VkYWMu Yzo1NzoxOiBub3RlOiBpbiBleHBhbnNpb24gb2YgbWFjcm8gJ21vZHVsZV9wbGF0Zm9ybV9kcml2 ZXInCiBtb2R1bGVfcGxhdGZvcm1fZHJpdmVyKHNpZml2ZV9lZGFjX2RyaXZlcik7CiBefn5+fn5+ fn5+fn5+fn5+fn5+fn5+Cm1ha2VbM106ICoqKiBbc2NyaXB0cy9NYWtlZmlsZS5idWlsZDoyODU6 IGRyaXZlcnMvZWRhYy9zaWZpdmVfZWRhYy5vXSBFcnJvciAxCm1ha2VbMl06ICoqKiBbc2NyaXB0 cy9NYWtlZmlsZS5idWlsZDo0ODk6IGRyaXZlcnMvZWRhY10gRXJyb3IgMgptYWtlWzJdOiAqKiog V2FpdGluZyBmb3IgdW5maW5pc2hlZCBqb2JzLi4uLgptYWtlWzFdOiAqKiogWy9ob21lL2Jvcmlz L2tlcm5lbC9saW51eC0yLjYvTWFrZWZpbGU6MTA0NjogZHJpdmVyc10gRXJyb3IgMgptYWtlOiAq KiogW01ha2VmaWxlOjE3MDogc3ViLW1ha2VdIEVycm9yIDIK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 428DEC43381 for ; Thu, 21 Mar 2019 13:34:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CBE420693 for ; Thu, 21 Mar 2019 13:34:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RlTnMiuR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="CesW61Gs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CBE420693 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=og1OpQkZ34UAnY80OzXtyUYN6gL12PfsJ2gEoP2VYms=; b=RlTnMiuRvgRwE7 6J0m0acG0UtEx0n96v3juMLZ+sY/V62wYJeJGS7SnIVWSWaJn+jorGVhpwOAjPS2DOlx7BZm39VTZ 55EHyDyuLkHdpF5fCibWX7vcxNgaoFUaIxrHBt4zjlnV8zkY7UY+X72evgLvOsebEzKYMNJiBzXBM yOZvC3VWnqD9t67APn3bCFDjrSUN+nG3/Jpnk2dVbk2op478xQWspAOyB+XKBkvxIQE3LNcFXE60h vfWGzHS2DBhBompMLWBM+dbIqaFEWCC3ZMHqVhVavugou3maaDse1SMRQU99SxK0FN6UErQuF7+MI 31SUE0sxwqUrT/qNcW2A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6xpY-000658-6i; Thu, 21 Mar 2019 13:34:00 +0000 Received: from mail.skyhub.de ([2a01:4f8:190:11c2::b:1457]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6xpS-00064O-Uf for linux-riscv@lists.infradead.org; Thu, 21 Mar 2019 13:33:58 +0000 Received: from nazgul.tnic (prg-ext-pat.suse.com [213.151.95.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 69AC81EC02AE; Thu, 21 Mar 2019 14:33:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1553175226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=wSX/OG/9bBzQkBxrQChjO5ACCWfsqwqKYEqfl3wrWq8=; b=CesW61GsSxGgb28plWXH1wuQD8dlYzvIwYd1K98W7EV6Ag+jxwW1ASIE72bWGySGeo8fhb zDqgmZsK16o1LuMgwflw9e8BTIiB9JEX5Gay3EkKdiC8LzMl0hQvomyua+9GURLgtg2KfM VbuBy3XukMN2ATvfdhxrxUEstfdPvZU= Date: Thu, 21 Mar 2019 14:33:40 +0100 From: Borislav Petkov To: Yash Shah Subject: Re: [PATCH 2/2] edac: sifive: Add EDAC driver for SiFive FU540-C000 chip Message-ID: <20190321133340.GB7047@nazgul.tnic> References: <1553082728-9232-1-git-send-email-yash.shah@sifive.com> <1553082728-9232-3-git-send-email-yash.shah@sifive.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1553082728-9232-3-git-send-email-yash.shah@sifive.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190321_063355_304465_1E242848 X-CRM114-Status: GOOD ( 24.85 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, aou@eecs.berkeley.edu, palmer@sifive.com, linux-kernel@vger.kernel.org, sachin.ghadi@sifive.com, robh+dt@kernel.org, paul.walmsley@sifive.com, linux-riscv@lists.infradead.org, mchehab@kernel.org, linux-edac@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, Mar 20, 2019 at 05:22:08PM +0530, Yash Shah wrote: > This EDAC driver supports: > - Initial configuration reporting on bootup via debug logs > - ECC event monitoring and reporting through the EDAC framework > - ECC event injection > > This driver is partially based on pnd2_edac.c and altera_edac.c > > Initially L2 Cache controller is added as a subcomponent to > this EDAC driver. > > Signed-off-by: Yash Shah ... > diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig > index e286b5b..112d9d1 100644 > --- a/drivers/edac/Kconfig > +++ b/drivers/edac/Kconfig > @@ -440,6 +440,19 @@ config EDAC_ALTERA_SDMMC > Support for error detection and correction on the > Altera SDMMC FIFO Memory for Altera SoCs. > > +config EDAC_SIFIVE > + tristate "Sifive ECC" > + depends on RISCV > + help > + Support for error detection and correction on the SiFive SoCs. > + > +config EDAC_SIFIVE_L2 That config item is unused. Drop it. > + bool "SiFive L2 Cache ECC" > + depends on EDAC_SIFIVE=y > + help > + Support for error detection and correction of the L2 cache > + memory on SiFive SoCs. > + > config EDAC_SYNOPSYS > tristate "Synopsys DDR Memory Controller" > depends on ARCH_ZYNQ || ARCH_ZYNQMP ... > +/* > + * sifive_edac_l2_int_handler - ISR function for l2 cache controller > + * @irq: Irq Number > + * @device: Pointer to the edac device controller instance > + * > + * This routine is triggered whenever there is ECC error detected > + * > + * Return: Always returns IRQ_HANDLED > + */ > +static irqreturn_t sifive_edac_l2_int_handler(int irq, void *device) > +{ > + struct edac_device_ctl_info *dci = > + (struct edac_device_ctl_info *)device; No ugly linebreaks like that - just let it stick out even if it is > 80 cols long. > + struct sifive_edac_device_dev *drvdata = dci->pvt_info; > + u32 regval, add_h, add_l; > + > + if (irq == drvdata->irq[dir_corr]) { > + add_h = readl(drvdata->base + SIFIVE_EDAC_DIRFIX_HIGH); > + add_l = readl(drvdata->base + SIFIVE_EDAC_DIRFIX_LOW); > + dev_err(dci->dev, > + "DirError at address 0x%08X.%08X\n", add_h, add_l); Same here and below. > + regval = readl(drvdata->base + SIFIVE_EDAC_DIRFIX_COUNT); > + edac_device_handle_ce(dci, 0, 0, "DirECCFix"); > + } > + if (irq == drvdata->irq[data_corr]) { > + add_h = readl(drvdata->base + SIFIVE_EDAC_DATFIX_HIGH); > + add_l = readl(drvdata->base + SIFIVE_EDAC_DATFIX_LOW); > + dev_err(dci->dev, > + "DataError at address 0x%08X.%08X\n", add_h, add_l); > + regval = readl(drvdata->base + SIFIVE_EDAC_DATFIX_COUNT); > + edac_device_handle_ce(dci, 0, 0, "DatECCFix"); > + } > + if (irq == drvdata->irq[data_uncorr]) { > + add_h = readl(drvdata->base + SIFIVE_EDAC_DATFAIL_HIGH); > + add_l = readl(drvdata->base + SIFIVE_EDAC_DATFAIL_LOW); > + dev_err(dci->dev, > + "DataFail at address 0x%08X.%08X\n", add_h, add_l); > + regval = readl(drvdata->base + SIFIVE_EDAC_DATFAIL_COUNT); > + edac_device_handle_ue(dci, 0, 0, "DatECCFail"); > + } > + > + return IRQ_HANDLED; > +} > + > +static void sifive_edac_l2_config_read(struct edac_device_ctl_info *dci) > +{ > + struct sifive_edac_device_dev *drvdata = dci->pvt_info; > + u32 regval, val; > + > + regval = readl(drvdata->base + SIFIVE_EDAC_CONFIG); > + val = regval & 0xFF; > + dev_info(dci->dev, "No. of Banks in the cache: %d\n", val); > + val = (regval & 0xFF00) >> 8; > + dev_info(dci->dev, "No. of ways per bank: %d\n", val); > + val = (regval & 0xFF0000) >> 16; > + dev_info(dci->dev, "Sets per bank: %llu\n", (uint64_t)1 << val); > + val = (regval & 0xFF000000) >> 24; > + dev_info(dci->dev, > + "Bytes per cache block: %llu\n", (uint64_t)1 << val); > +} > + > +static const struct sifive_edac_device_prv l2ecc_data = { > + .setup = sifive_edac_l2_config_read, > + .inject_fops = &sifive_edac_l2_fops, > + .ecc_irq_handler = sifive_edac_l2_int_handler, > +}; > + > +/* > + * sifive_edac_device_probe() > + * This is a generic EDAC device driver that will support > + * various SiFive memory devices as well as the memories > + * for other peripherals. Module specific initialization is > + * done by passing the function index in the device tree. This comment doesn't have anything to do with that function but rather belongs at the top of this file. > + */ > +static int sifive_edac_device_probe(struct platform_device *pdev) > +{ > + struct edac_device_ctl_info *dci; > + struct sifive_edac_device_dev *drvdata; > + int rc, i; > + struct resource *res; > + void __iomem *baseaddr; > + struct device_node *np = pdev->dev.of_node; > + char *ecc_name = (char *)np->name; > + static int dev_instance; Please sort function local variables declaration in a reverse christmas tree order: longest_variable_name; shorter_var_name; even_shorter; i; > + > + /* Get the data from the platform device */ > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + baseaddr = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(baseaddr)) > + return PTR_ERR(baseaddr); > + > + dci = edac_device_alloc_ctl_info(sizeof(*drvdata), ecc_name, > + 1, ecc_name, 1, 1, NULL, 0, > + dev_instance++); > + if (IS_ERR(dci)) > + return PTR_ERR(dci); > + > + drvdata = dci->pvt_info; > + drvdata->base = baseaddr; > + drvdata->edac_dev_name = ecc_name; > + dci->dev = &pdev->dev; > + dci->mod_name = "Sifive ECC Manager"; > + dci->ctl_name = dev_name(&pdev->dev); > + dci->dev_name = dev_name(&pdev->dev); > + > + /* Get driver specific data for this EDAC device */ > + drvdata->data = of_match_node(sifive_edac_device_of_match, np)->data; > + > + setup_sifive_debug(dci, drvdata->data); > + > + if (drvdata->data->setup) > + drvdata->data->setup(dci); > + > + for (i = 0; i < SIFIVE_EDAC_MAX_INTR; i++) { > + drvdata->irq[i] = platform_get_irq(pdev, i); > + rc = devm_request_irq(&pdev->dev, drvdata->irq[i], > + sifive_edac_l2_int_handler, 0, > + dev_name(&pdev->dev), (void *)dci); > + if (rc) { > + dev_err(&pdev->dev, > + "Could not request IRQ %d\n", drvdata->irq[i]); > + goto del_edac_device; > + } > + } > + > + rc = edac_device_add_device(dci); > + if (rc) { > + dev_err(&pdev->dev, "failed to register with EDAC core\n"); > + goto del_edac_device; > + } Call setup_sifive_debug() in the success case here so that you don't have to teardown below. > + > + return rc; > + > +del_edac_device: > + teardown_sifive_debug(); > + edac_device_del_device(&pdev->dev); > + edac_device_free_ctl_info(dci); Those three can be replaced by a call to sifive_edac_device_remove() ? Btw, you have prefixed your static functions with "sifive_edac_" which doesn't make much sense and you have long names for no good reason. > + > + return rc; > +} > + > +static int sifive_edac_device_remove(struct platform_device *pdev) > +{ > + struct edac_device_ctl_info *dci = platform_get_drvdata(pdev); > + > + teardown_sifive_debug(); > + edac_device_del_device(&pdev->dev); > + edac_device_free_ctl_info(dci); > + > + return 0; > +} > + > +static const struct of_device_id sifive_edac_device_of_match[] = { > + { .compatible = "sifive,ccache0", .data = &l2ecc_data }, > + { /* end of table */ }, > +}; > +MODULE_DEVICE_TABLE(of, sifive_edac_device_of_match); > + > +static struct platform_driver sifive_edac_device_driver = { > + .driver = { > + .name = "sifive_edac_device", "device"? I think it is clear that it is a device and thus kinda tautological. "sifive_edac" should be enough... Last but not least, building this driver with the riscv64 cross compilers from here: http://cdn.kernel.org/pub/tools/crosstool/files/bin/ fails like below. With the riscv32 compiler it fails the same. Provided I'm not doing anything wrong, you should not be sending me half-baked stuff which doesn't even build. drivers/edac/sifive_edac.c: In function 'sifive_edac_device_probe': drivers/edac/sifive_edac.c:231:16: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] drvdata->data = of_match_node(sifive_edac_device_of_match, np)->data; ^ In file included from drivers/edac/sifive_edac.c:10: drivers/edac/sifive_edac.c: At top level: ./include/linux/module.h:130:42: error: redefinition of '__inittest' static inline initcall_t __maybe_unused __inittest(void) \ ^~~~~~~~~~ ./include/linux/device.h:1647:1: note: in expansion of macro 'module_init' module_init(__driver##_init); \ ^~~~~~~~~~~ ./include/linux/platform_device.h:233:2: note: in expansion of macro 'module_driver' module_driver(__platform_driver, platform_driver_register, \ ^~~~~~~~~~~~~ drivers/edac/sifive_edac.c:293:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(sifive_edac_device_driver); ^~~~~~~~~~~~~~~~~~~~~~ ./include/linux/module.h:130:42: note: previous definition of '__inittest' was here static inline initcall_t __maybe_unused __inittest(void) \ ^~~~~~~~~~ ./include/linux/device.h:1647:1: note: in expansion of macro 'module_init' module_init(__driver##_init); \ ^~~~~~~~~~~ ./include/linux/platform_device.h:233:2: note: in expansion of macro 'module_driver' module_driver(__platform_driver, platform_driver_register, \ ^~~~~~~~~~~~~ drivers/edac/sifive_edac.c:57:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(sifive_edac_driver); ^~~~~~~~~~~~~~~~~~~~~~ ./include/linux/module.h:132:6: error: redefinition of 'init_module' int init_module(void) __copy(initfn) __attribute__((alias(#initfn))); ^~~~~~~~~~~ ./include/linux/device.h:1647:1: note: in expansion of macro 'module_init' module_init(__driver##_init); \ ^~~~~~~~~~~ ./include/linux/platform_device.h:233:2: note: in expansion of macro 'module_driver' module_driver(__platform_driver, platform_driver_register, \ ^~~~~~~~~~~~~ drivers/edac/sifive_edac.c:293:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(sifive_edac_device_driver); ^~~~~~~~~~~~~~~~~~~~~~ ./include/linux/module.h:132:6: note: previous definition of 'init_module' was here int init_module(void) __copy(initfn) __attribute__((alias(#initfn))); ^~~~~~~~~~~ ./include/linux/device.h:1647:1: note: in expansion of macro 'module_init' module_init(__driver##_init); \ ^~~~~~~~~~~ ./include/linux/platform_device.h:233:2: note: in expansion of macro 'module_driver' module_driver(__platform_driver, platform_driver_register, \ ^~~~~~~~~~~~~ drivers/edac/sifive_edac.c:57:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(sifive_edac_driver); ^~~~~~~~~~~~~~~~~~~~~~ ./include/linux/module.h:136:42: error: redefinition of '__exittest' static inline exitcall_t __maybe_unused __exittest(void) \ ^~~~~~~~~~ ./include/linux/device.h:1652:1: note: in expansion of macro 'module_exit' module_exit(__driver##_exit); ^~~~~~~~~~~ ./include/linux/platform_device.h:233:2: note: in expansion of macro 'module_driver' module_driver(__platform_driver, platform_driver_register, \ ^~~~~~~~~~~~~ drivers/edac/sifive_edac.c:293:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(sifive_edac_device_driver); ^~~~~~~~~~~~~~~~~~~~~~ ./include/linux/module.h:136:42: note: previous definition of '__exittest' was here static inline exitcall_t __maybe_unused __exittest(void) \ ^~~~~~~~~~ ./include/linux/device.h:1652:1: note: in expansion of macro 'module_exit' module_exit(__driver##_exit); ^~~~~~~~~~~ ./include/linux/platform_device.h:233:2: note: in expansion of macro 'module_driver' module_driver(__platform_driver, platform_driver_register, \ ^~~~~~~~~~~~~ drivers/edac/sifive_edac.c:57:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(sifive_edac_driver); ^~~~~~~~~~~~~~~~~~~~~~ ./include/linux/module.h:138:7: error: redefinition of 'cleanup_module' void cleanup_module(void) __copy(exitfn) __attribute__((alias(#exitfn))); ^~~~~~~~~~~~~~ ./include/linux/device.h:1652:1: note: in expansion of macro 'module_exit' module_exit(__driver##_exit); ^~~~~~~~~~~ ./include/linux/platform_device.h:233:2: note: in expansion of macro 'module_driver' module_driver(__platform_driver, platform_driver_register, \ ^~~~~~~~~~~~~ drivers/edac/sifive_edac.c:293:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(sifive_edac_device_driver); ^~~~~~~~~~~~~~~~~~~~~~ ./include/linux/module.h:138:7: note: previous definition of 'cleanup_module' was here void cleanup_module(void) __copy(exitfn) __attribute__((alias(#exitfn))); ^~~~~~~~~~~~~~ ./include/linux/device.h:1652:1: note: in expansion of macro 'module_exit' module_exit(__driver##_exit); ^~~~~~~~~~~ ./include/linux/platform_device.h:233:2: note: in expansion of macro 'module_driver' module_driver(__platform_driver, platform_driver_register, \ ^~~~~~~~~~~~~ drivers/edac/sifive_edac.c:57:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(sifive_edac_driver); ^~~~~~~~~~~~~~~~~~~~~~ make[3]: *** [scripts/Makefile.build:285: drivers/edac/sifive_edac.o] Error 1 make[2]: *** [scripts/Makefile.build:489: drivers/edac] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/home/boris/kernel/linux-2.6/Makefile:1046: drivers] Error 2 make: *** [Makefile:170: sub-make] Error 2 -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv