From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=/BZh=RY=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 68F4CC43381
	for <linux-kernel@archiver.kernel.org>; Thu, 21 Mar 2019 13:57:16 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 3B859218A5
	for <linux-kernel@archiver.kernel.org>; Thu, 21 Mar 2019 13:57:16 +0000 (UTC)
Authentication-Results: mail.kernel.org;
	dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="fq/2RItF"
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728409AbfCUN5O (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 21 Mar 2019 09:57:14 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:33430 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727829AbfCUN5O (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 21 Mar 2019 09:57:14 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=3nfnSicQ3jrBCesANn6VVd+OcC0n8YKrR/A1tNARnTg=; b=fq/2RItF13mCkdBCXgti9iMU0V
        um5cU78WXdgc/heEQwjtVDpDhW68PI+o7vaavsjEqTq/hCkkNXQfogNxEjhbRoRUxyBRr3anH4qnx
        iDaefqZrMDXLJ1RWywUIi/lHqPKAt0qQ4FHNFQjTdLiT2KIt3CgZOWvAn+6dUnkwhSQQ=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.89)
        (envelope-from <andrew@lunn.ch>)
        id 1h6yBt-00055O-M2; Thu, 21 Mar 2019 14:57:05 +0100
Date:   Thu, 21 Mar 2019 14:57:05 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Michal Kubecek <mkubecek@suse.cz>
Cc:     David Miller <davem@davemloft.net>, netdev@vger.kernel.org,
        Jakub Kicinski <jakub.kicinski@netronome.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Florian Fainelli <f.fainelli@gmail.com>,
        John Linville <linville@tuxdriver.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 05/22] ethtool: introduce ethtool netlink
 interface
Message-ID: <20190321135705.GB17655@lunn.ch>
References: <cover.1553170807.git.mkubecek@suse.cz>
 <a5a50f3d60cee03f75b70fdf17e73a6212aaec3d.1553170807.git.mkubecek@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a5a50f3d60cee03f75b70fdf17e73a6212aaec3d.1553170807.git.mkubecek@suse.cz>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 21, 2019 at 02:07:35PM +0100, Michal Kubecek wrote:
> +static int __init ethnl_init(void)
> +{
> +	int ret;
> +
> +	ret = genl_register_family(&ethtool_genl_family);
> +	if (ret < 0)
> +		panic("ethtool: could not register genetlink family\n");

Hi Michal

Panic seems a bit strong. Do we really want to kill the box because
this fails?

     Andrew