From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23057C43381 for ; Thu, 21 Mar 2019 15:10:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E66A1218D4 for ; Thu, 21 Mar 2019 15:10:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="uv7HObzV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728504AbfCUPKH (ORCPT ); Thu, 21 Mar 2019 11:10:07 -0400 Received: from outils.crapouillou.net ([89.234.176.41]:47338 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728274AbfCUPKE (ORCPT ); Thu, 21 Mar 2019 11:10:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1553181002; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=FzSG5ZvXQaujyFWbABWv+SiDD090vHGG/SizFLCc2a0=; b=uv7HObzVQLrauC9xGQcTVsMmNDyMjQ4YA6qZyM2oIUp0bqlLG9wEZDRgQ4ffGOdc3Yq5hi eYyR5LzfoxP/NFmQ1z489gQmfT0kDCYjuiSg2PHUyseF64tOcDP74M+5OyWef3IOiWi9aQ ru5hVn9R8oGVVOgmUDICtqftALcyDVg= From: Paul Cercueil To: Bin Liu , Rob Herring , Mark Rutland Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, od@zcrc.me, Paul Cercueil Subject: [PATCH 2/3] usb: musb: jz4740: Let the platform probe the PHY Date: Thu, 21 Mar 2019 16:09:55 +0100 Message-Id: <20190321150956.6629-2-paul@crapouillou.net> In-Reply-To: <20190321150956.6629-1-paul@crapouillou.net> References: <20190321150956.6629-1-paul@crapouillou.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org By registering a generic USB PHY from within the driver, we may shadow the USB PHY registered by the platform, which might be different. Signed-off-by: Paul Cercueil --- drivers/usb/musb/jz4740.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/musb/jz4740.c b/drivers/usb/musb/jz4740.c index a60627bf7be3..ad35e09f90bd 100644 --- a/drivers/usb/musb/jz4740.c +++ b/drivers/usb/musb/jz4740.c @@ -74,7 +74,6 @@ static struct musb_hdrc_platform_data jz4740_musb_platform_data = { static int jz4740_musb_init(struct musb *musb) { - usb_phy_generic_register(); musb->xceiv = usb_get_phy(USB_PHY_TYPE_USB2); if (IS_ERR(musb->xceiv)) { pr_err("HS UDC: no transceiver configured\n"); @@ -183,7 +182,6 @@ static int jz4740_remove(struct platform_device *pdev) struct jz4740_glue *glue = platform_get_drvdata(pdev); platform_device_unregister(glue->musb); - usb_phy_generic_unregister(pdev); clk_disable_unprepare(glue->clk); return 0; -- 2.11.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [2/3] usb: musb: jz4740: Let the platform probe the PHY From: Paul Cercueil Message-Id: <20190321150956.6629-2-paul@crapouillou.net> Date: Thu, 21 Mar 2019 16:09:55 +0100 To: Bin Liu , Rob Herring , Mark Rutland Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, od@zcrc.me, Paul Cercueil List-ID: QnkgcmVnaXN0ZXJpbmcgYSBnZW5lcmljIFVTQiBQSFkgZnJvbSB3aXRoaW4gdGhlIGRyaXZlciwg d2UgbWF5IHNoYWRvdwp0aGUgVVNCIFBIWSByZWdpc3RlcmVkIGJ5IHRoZSBwbGF0Zm9ybSwgd2hp Y2ggbWlnaHQgYmUgZGlmZmVyZW50LgoKU2lnbmVkLW9mZi1ieTogUGF1bCBDZXJjdWVpbCA8cGF1 bEBjcmFwb3VpbGxvdS5uZXQ+Ci0tLQogZHJpdmVycy91c2IvbXVzYi9qejQ3NDAuYyB8IDIgLS0K IDEgZmlsZSBjaGFuZ2VkLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNi L211c2Ivano0NzQwLmMgYi9kcml2ZXJzL3VzYi9tdXNiL2p6NDc0MC5jCmluZGV4IGE2MDYyN2Jm N2JlMy4uYWQzNWUwOWY5MGJkIDEwMDY0NAotLS0gYS9kcml2ZXJzL3VzYi9tdXNiL2p6NDc0MC5j CisrKyBiL2RyaXZlcnMvdXNiL211c2Ivano0NzQwLmMKQEAgLTc0LDcgKzc0LDYgQEAgc3RhdGlj IHN0cnVjdCBtdXNiX2hkcmNfcGxhdGZvcm1fZGF0YSBqejQ3NDBfbXVzYl9wbGF0Zm9ybV9kYXRh ID0gewogCiBzdGF0aWMgaW50IGp6NDc0MF9tdXNiX2luaXQoc3RydWN0IG11c2IgKm11c2IpCiB7 Ci0JdXNiX3BoeV9nZW5lcmljX3JlZ2lzdGVyKCk7CiAJbXVzYi0+eGNlaXYgPSB1c2JfZ2V0X3Bo eShVU0JfUEhZX1RZUEVfVVNCMik7CiAJaWYgKElTX0VSUihtdXNiLT54Y2VpdikpIHsKIAkJcHJf ZXJyKCJIUyBVREM6IG5vIHRyYW5zY2VpdmVyIGNvbmZpZ3VyZWRcbiIpOwpAQCAtMTgzLDcgKzE4 Miw2IEBAIHN0YXRpYyBpbnQgano0NzQwX3JlbW92ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpw ZGV2KQogCXN0cnVjdCBqejQ3NDBfZ2x1ZQkqZ2x1ZSA9IHBsYXRmb3JtX2dldF9kcnZkYXRhKHBk ZXYpOwogCiAJcGxhdGZvcm1fZGV2aWNlX3VucmVnaXN0ZXIoZ2x1ZS0+bXVzYik7Ci0JdXNiX3Bo eV9nZW5lcmljX3VucmVnaXN0ZXIocGRldik7CiAJY2xrX2Rpc2FibGVfdW5wcmVwYXJlKGdsdWUt PmNsayk7CiAKIAlyZXR1cm4gMDsK