From mboxrd@z Thu Jan 1 00:00:00 1970 From: Troy Benjegerdes Date: Thu, 21 Mar 2019 09:24:41 -0700 Subject: [U-Boot] [PATCH 2/9] riscv: Add a SYSCON driver for Andestech's PLIC In-Reply-To: References: <20190319090750.8923-1-uboot@andestech.com> <20190319090750.8923-3-uboot@andestech.com> Message-ID: <20190321162441.GD9699@bc.grid.coop> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > > > > > > > > Probably it makes more sense to put this to arch/riscv/cpu/ax25/Kconfig? > > > > > > I just refer to SIFIVE_CLINT. It also not make sense to place here, right ? > > > > Maybe, but since the cpu directory is renamed to 'generic', I am not > > sure moving to that directory is a good idea. > > Maybe I will still put it in /arch/riscv/Kconfig. > And we can move them to the place they belong individually together if > there have better place to accommodate to SIFIVE_CLINT. > How do you think ? > > > > > > +++ b/arch/riscv/lib/Makefile > > > > > @@ -11,6 +11,7 @@ obj-$(CONFIG_CMD_GO) += boot.o > > > > > obj-y += cache.o > > > > > obj-$(CONFIG_RISCV_RDTIME) += rdtime.o > > > > > obj-$(CONFIG_SIFIVE_CLINT) += sifive_clint.o > > > > > +obj-$(CONFIG_NDS_PLIC) += nds_plic.o > > > > > obj-y += interrupts.o > > > > > obj-y += reset.o > > > > > obj-$(CONFIG_SBI_IPI) += sbi_ipi.o > > > > > diff --git a/arch/riscv/lib/nds_plic.c b/arch/riscv/lib/nds_plic.c > > > > > > > > And move this driver to arch/riscv/cpu/ax25 since it's only available > > > > in AX25 CPUs? > > > > > > Same as sifive_clint.c . Shall it also move away from /lib ? > > > > > > > I agree, but see comments above :) It seems to me there might be a usefull distinction between potentially generic things like the Sifive/Berkely/Rocket-chip clint [1] and other vendor implementations which do not have necessarily have publicly reviewable hardware implementations. [1] https://github.com/sifive/rocket-chip/blob/master/src/main/scala/devices/tilelink/CLINT.scala