From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48AECC43381 for ; Thu, 21 Mar 2019 17:31:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F272E21874 for ; Thu, 21 Mar 2019 17:31:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="HRsXb/j9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728305AbfCURbR (ORCPT ); Thu, 21 Mar 2019 13:31:17 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:40072 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727198AbfCURbQ (ORCPT ); Thu, 21 Mar 2019 13:31:16 -0400 Received: by mail-wm1-f68.google.com with SMTP id u10so3608044wmj.5 for ; Thu, 21 Mar 2019 10:31:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WO8m++QnlN3vxRUy4sj/CrsDWvBNwKhpBtZy4Mb1E3Q=; b=HRsXb/j9eHHOBaRICH5V9RA4rhkU7NmddisUv+VQC100nUvbqHjU7xY5K8ai3U69KG REB9FUs3x/cbV9BcPR2VaEPHbqB1loaJWxzizF5o5XcftX3fW9bSVEfUboFuOUA64jlc iWeSqYnLA45Q1EbniZcEmxIVBBVNMPfXVc+ndMZ18fqEhlh4V1sqVPrxMUL93kA0qwI7 OD4sKNB6DF+Qp11gp/rJklGyjRkklGcV8nkC1H4vmTloZ+oT5xkVWOpB5xRxlIaOmxyb zon0KeSp5y4H4H4Scc15ODxpv+CTKDK7SpjaaxiBKrzPBgD4D9Z1EYBioqobOITFBiV5 nYAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WO8m++QnlN3vxRUy4sj/CrsDWvBNwKhpBtZy4Mb1E3Q=; b=JFEtLu5BYohEpbAJn5GSwt0PZ1Mv/d4Uqs9E2VGtvp9brS6pRrOm9IUGv2T6CgpGZJ SElWxAGhJe+eSQ0rODQlbtAalTr4KuS9axGD+8CDwmVHJt2CMYInKoSg0aNOhTbmem7Y SwG+ScIG4ocLjeJzjGYSe0Shm+8MqOy2L6RXBADpBqKWjaMKtrDtIy81tSTWX5U4dpFh 5edxuOTqV+9KvJipAAIi/VPFEzuqoWArLM9Udi8hVEC/KolYE7NhiE6DktzMNdR3jDlf T1PDm5eJu5rX8ei8Z3c5/D++3xjS5NPg4o9AXSDiSCcLDgTWcIo+cpLn9zKrdgjdLkiE dRMQ== X-Gm-Message-State: APjAAAUdsSuL/CMiIdz+oGYKPvkTRBU9cB4loCdUoMfiJaZK7EWJmFQC Iko2YPnXZF+uDhzzQ7l5osJ4qQ== X-Google-Smtp-Source: APXvYqwTW6MczvURiH0wEa0TPGfCna3lWI6l6ZVuk2hn5Yx18MbgFxcKuXgSZei1M4FzSmJHOQQ5ew== X-Received: by 2002:a1c:f115:: with SMTP id p21mr249938wmh.93.1553189473874; Thu, 21 Mar 2019 10:31:13 -0700 (PDT) Received: from localhost ([195.39.71.253]) by smtp.gmail.com with ESMTPSA id t202sm10979477wmt.0.2019.03.21.10.31.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Mar 2019 10:31:13 -0700 (PDT) Date: Thu, 21 Mar 2019 18:20:34 +0100 From: Jiri Pirko To: Parav Pandit Cc: Jakub Kicinski , "Samudrala, Sridhar" , "davem@davemloft.net" , "netdev@vger.kernel.org" , "oss-drivers@netronome.com" Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI ports Message-ID: <20190321172034.GW2087@nanopsycho> References: <20190315200814.GD2305@nanopsycho> <20190315134454.581f47ca@cakuba.netronome.com> <20190318121154.GG2270@nanopsycho> <20190318121642.74a56b7e@cakuba.netronome.com> <20190321084526.GA2087@nanopsycho> <20190321161421.GR2087@nanopsycho> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Mar 21, 2019 at 05:52:09PM CET, parav@mellanox.com wrote: > > >> -----Original Message----- >> From: Jiri Pirko >> Sent: Thursday, March 21, 2019 11:14 AM >> To: Parav Pandit >> Cc: Jakub Kicinski ; Samudrala, Sridhar >> ; davem@davemloft.net; >> netdev@vger.kernel.org; oss-drivers@netronome.com >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on devlink PCI >> ports >> >> Thu, Mar 21, 2019 at 04:14:53PM CET, parav@mellanox.com wrote: >> > >> > >> >> -----Original Message----- >> >> From: Jiri Pirko >> >> Sent: Thursday, March 21, 2019 3:45 AM >> >> To: Jakub Kicinski >> >> Cc: Parav Pandit ; Samudrala, Sridhar >> >> ; davem@davemloft.net; >> >> netdev@vger.kernel.org; oss-drivers@netronome.com >> >> Subject: Re: [PATCH net-next v2 4/7] devlink: allow subports on >> >> devlink PCI ports >> >> >> >> Mon, Mar 18, 2019 at 08:16:42PM CET, jakub.kicinski@netronome.com >> >> wrote: >> >> >On Mon, 18 Mar 2019 13:11:54 +0100, Jiri Pirko wrote: >> >> >> >> >2. flavour should not be vf/pf, flavour should be hostport, >> switchport. >> >> >> >> >Because switch is flat and agnostic of pf/vf/mdev. >> >> >> >> >> >> >> >> Not sure. It's good to have this kind of visibility. >> >> >> > >> >> >> >Yes, this subthread honestly makes me go from 60% sure to 95% >> >> >> >sure we shouldn't do the dual object thing :( Seems like Parav >> >> >> >is already confused by it and suggests host port can exist >> >> >> >without switch port :( >> >> >> >> >> >> Although I understand your hesitation, the host ports are also >> >> >> associated with the asic and should be under the devlink instance. >> >> >> It is just a matter of proper documentation and clear code to >> >> >> avoid confusions. >> >> > >> >> >They are certainly a part and belong to the ASIC, the question in my >> >> >mind is more along the lines of do we want "one pipe/one port" or is >> >> >it okay to have multiple software objects of the same kind for those >> >> >objects. >> >> > >> >> >To put it differently - do want a port object for each port of the >> >> >ASIC or do we want a port object for each netdev.. >> >> >> >> Perhaps "port" name of the object is misleading. From the beginning, >> >> I ment to have it for both switch ports and host ports. I admit that >> >> "host port" is a bit misleading, as it is not really a port of >> >> eswitch, but the counter part. But if we introduce another object for >> >> that purpose in devlink (like "partititon"), it would be a lot of duplication >> I think. >> >> >> >> Question is, do we need the "host port"? Can't we just put a relation >> >> to host netdev in the eswitch port. >> >> >> >Can you please explain how does it work for rdma for non sriov use case? >> >Do we have to create a fake eswitch object? >> >> Could you please provide details on "rdma for non sriov use case"? >> >There are multiple mdevs on PFs that happen to have link layer as IB and those devlink instances have port that deserved to be configured same way as that of Eth. Could you please describe it a bit more. There is still an eswitch through which the traffic is going, isn't it?