All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
Cc: outreachy-kernel@googlegroups.com, ajay.kathat@microchip.com,
	adham.abozaeid@microchip.com
Subject: Re: [PATCH v2 1/3] staging: wilc1000: Remove return variables in host_interface.c
Date: Thu, 21 Mar 2019 19:59:39 +0100	[thread overview]
Message-ID: <20190321185939.GA28776@kroah.com> (raw)
In-Reply-To: <20190321074927.2865-2-nishka.dasgupta@yahoo.com>

On Thu, Mar 21, 2019 at 01:19:25PM +0530, Nishka Dasgupta wrote:
> Remove return variables in host_interface.c. Issue suggested with
> Coccinelle using ret.cocci.
> 
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta@yahoo.com>
> ---
>  drivers/staging/wilc1000/host_interface.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)

Patch 1 and 2 almost have identical subject lines, that is not ok.

Also, did you test build this series?  It adds new build warnings to the
kernel build process, which is not acceptable and will cause a patch to
be rejected :(

Please fix this series up and resend.

thanks,

greg k-h


  reply	other threads:[~2019-03-21 18:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21  7:49 [PATCH v2 0/3] staging: wilc1000: Remove return variables Nishka Dasgupta
2019-03-21  7:49 ` [PATCH v2 1/3] staging: wilc1000: Remove return variables in host_interface.c Nishka Dasgupta
2019-03-21 18:59   ` Greg KH [this message]
2019-03-21  7:49 ` [PATCH v2 2/3] staging: wilc1000: Remove return variable " Nishka Dasgupta
2019-03-21  7:49 ` [PATCH v2 3/3] staging: wilc1000: Remove return variables in wilc_spi.c Nishka Dasgupta
2019-03-21 18:57   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190321185939.GA28776@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=adham.abozaeid@microchip.com \
    --cc=ajay.kathat@microchip.com \
    --cc=nishka.dasgupta@yahoo.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.