All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org, "Andy Lutomirski" <luto@kernel.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	kvm@vger.kernel.org, "Jason A. Donenfeld" <Jason@zx2c4.com>,
	"Rik van Riel" <riel@surriel.com>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>
Subject: [PATCH 24/24] x86/pkeys: add PKRU value to init_fpstate
Date: Thu, 21 Mar 2019 21:26:32 +0100	[thread overview]
Message-ID: <20190321202632.16810-25-bigeasy@linutronix.de> (raw)
In-Reply-To: <20190321202632.16810-1-bigeasy@linutronix.de>

The task's initiall PKRU value is set part for fpu__clear()/
copy_init_pkru_to_fpregs(). It is not part of init_fpstate.xsave and
instead it is set explictly.
If the user removes the PKRU state from XSAVE in the signal handler then
__fpu__restore_sig() will restore the missing bits from `init_fpstate'
and initialize the PKRU value to 0.

Add the `init_pkru_value' to `init_fpstate' so it is set to the init
value in such a case.

In theory we could drop copy_init_pkru_to_fpregs() because restoring the
PKRU at return-to-userland should be enough.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 arch/x86/kernel/cpu/common.c | 5 +++++
 arch/x86/mm/pkeys.c          | 6 ++++++
 2 files changed, 11 insertions(+)

diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index cb28e98a0659a..352fa19e63110 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -372,6 +372,8 @@ static bool pku_disabled;
 
 static __always_inline void setup_pku(struct cpuinfo_x86 *c)
 {
+	struct pkru_state *pk;
+
 	/* check the boot processor, plus compile options for PKU: */
 	if (!cpu_feature_enabled(X86_FEATURE_PKU))
 		return;
@@ -382,6 +384,9 @@ static __always_inline void setup_pku(struct cpuinfo_x86 *c)
 		return;
 
 	cr4_set_bits(X86_CR4_PKE);
+	pk = get_xsave_addr(&init_fpstate.xsave, XFEATURE_PKRU);
+	if (pk)
+		pk->pkru = init_pkru_value;
 	/*
 	 * Seting X86_CR4_PKE will cause the X86_FEATURE_OSPKE
 	 * cpuid bit to be set.  We need to ensure that we
diff --git a/arch/x86/mm/pkeys.c b/arch/x86/mm/pkeys.c
index 2ecbf4155f98f..1dcfc91c8f0c3 100644
--- a/arch/x86/mm/pkeys.c
+++ b/arch/x86/mm/pkeys.c
@@ -18,6 +18,7 @@
 
 #include <asm/cpufeature.h>             /* boot_cpu_has, ...            */
 #include <asm/mmu_context.h>            /* vma_pkey()                   */
+#include <asm/fpu/internal.h>		/* init_fpstate			*/
 
 int __execute_only_pkey(struct mm_struct *mm)
 {
@@ -161,6 +162,7 @@ static ssize_t init_pkru_read_file(struct file *file, char __user *user_buf,
 static ssize_t init_pkru_write_file(struct file *file,
 		 const char __user *user_buf, size_t count, loff_t *ppos)
 {
+	struct pkru_state *pk;
 	char buf[32];
 	ssize_t len;
 	u32 new_init_pkru;
@@ -183,6 +185,10 @@ static ssize_t init_pkru_write_file(struct file *file,
 		return -EINVAL;
 
 	WRITE_ONCE(init_pkru_value, new_init_pkru);
+	pk = get_xsave_addr(&init_fpstate.xsave, XFEATURE_PKRU);
+	if (!pk)
+		return -EINVAL;
+	pk->pkru = new_init_pkru;
 	return count;
 }
 
-- 
2.20.1


      parent reply	other threads:[~2019-03-21 20:27 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21 20:26 [PATCH v8] x86: load FPU registers on return to userland Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 01/24] x86/fpu: Remove fpu->initialized usage in __fpu__restore_sig() Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 02/24] x86/fpu: Remove fpu__restore() Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 03/24] x86/fpu: Remove preempt_disable() in fpu__clear() Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 04/24] x86/fpu: Always init the `state' " Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 05/24] x86/fpu: Remove fpu->initialized usage in copy_fpstate_to_sigframe() Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 06/24] x86/fpu: Don't save fxregs for ia32 frames " Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 07/24] x86/fpu: Remove fpu->initialized Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 08/24] x86/fpu: Remove user_fpu_begin() Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 09/24] x86/fpu: Add (__)make_fpregs_active helpers Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 10/24] x86/fpu: Make __raw_xsave_addr() use feature number instead of mask Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 11/24] x86/fpu: Make get_xsave_field_ptr() and get_xsave_addr() " Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 12/24] x86/pkru: Provide .*_pkru_ins() functions Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 13/24] x86/fpu: Only write PKRU if it is different from current Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 14/24] x86/pkeys: Don't check if PKRU is zero before writting it Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 15/24] x86/fpu: Eager switch PKRU state Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 16/24] x86/entry: Add TIF_NEED_FPU_LOAD Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 17/24] x86/fpu: Always store the registers in copy_fpstate_to_sigframe() Sebastian Andrzej Siewior
2019-03-31 16:54   ` Thomas Gleixner
2019-03-21 20:26 ` [PATCH 18/24] x86/fpu: Prepare copy_fpstate_to_sigframe() for TIF_NEED_FPU_LOAD Sebastian Andrzej Siewior
2019-03-31 18:20   ` Thomas Gleixner
2019-04-01  8:24     ` Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 19/24] x86/fpu: Update xstate's PKRU value on write_pkru() Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 20/24] x86/fpu: Inline copy_user_to_fpregs_zeroing() Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 21/24] x86/fpu: Let __fpu__restore_sig() restore the !32bit+fxsr frame from kernel memory Sebastian Andrzej Siewior
2019-03-22 14:55   ` Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 22/24] x86/fpu: Merge the two code paths in __fpu__restore_sig() Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 23/24] x86/fpu: Defer FPU state load until return to userspace Sebastian Andrzej Siewior
2019-03-21 20:26 ` Sebastian Andrzej Siewior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190321202632.16810-25-bigeasy@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=Jason@zx2c4.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=riel@surriel.com \
    --cc=rkrcmar@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.