From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BA04C43381 for ; Thu, 21 Mar 2019 19:56:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0463C2183E for ; Thu, 21 Mar 2019 19:55:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nic.cz header.i=@nic.cz header.b="UQpnT5zx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728528AbfCUTz6 (ORCPT ); Thu, 21 Mar 2019 15:55:58 -0400 Received: from mail.nic.cz ([217.31.204.67]:34843 "EHLO mail.nic.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727997AbfCUTz6 (ORCPT ); Thu, 21 Mar 2019 15:55:58 -0400 Received: from localhost (unknown [172.20.6.218]) by mail.nic.cz (Postfix) with ESMTPS id 68BFA62F8D; Thu, 21 Mar 2019 20:55:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1553198156; bh=8p+YyxYfxmE/lAuxlGOkuQCmNubGnRq8+tZ1IiF0A5E=; h=Date:From:To; b=UQpnT5zx3rCPM0TQLSRzkIsUA9NJ0UFNpDvENVpuix4dg2z2CMa63M3p2MgSwh3vk vhPciydMVnX+KObl09mbFkBfdzJEt3HLU97EbbimURSccLDIvrHIveMDl6ikkRPTcn 0V9+6H7hKPGxFNdRuYfVABxMqx5t4F3cyTM2yA20= Date: Thu, 21 Mar 2019 20:55:55 +0100 From: Marek Behun To: Florian Fainelli Cc: netdev@vger.kernel.org, Andrew Lunn , Michal =?UTF-8?B?Vm9rw6HEjQ==?= , John Crispin , Wei Yongjun , Christian Lamparter Subject: Re: [PATCH net-next 1/1] net: dsa: qca8k: Fix internal PHY MDIO address Message-ID: <20190321205555.358eaaee@nic.cz> In-Reply-To: <4f2160f2-28f1-bd61-86ee-3db77fd67ba4@gmail.com> References: <20190321182319.10664-1-marek.behun@nic.cz> <4f2160f2-28f1-bd61-86ee-3db77fd67ba4@gmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: clamav-milter 0.99.2 at mail X-Virus-Status: Clean Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, Oh, I didn't know about Christian's patch. I shall test on our device tomorrow. If it works, we will use internal PHY access. But I think that qca8k_port_to_phy should be used in the external mode as well. On our device the PHYs are mapped on 0-4 on the master bus even in that mode. Marek On Thu, 21 Mar 2019 11:26:08 -0700 Florian Fainelli wrote: > +Christian, >=20 > On 3/21/19 11:23 AM, Marek Beh=C3=BAn wrote: > > The MDIO addresses of the internal PHYs on this switch for ports 1-5 > > have addresses 0-4, not 1-5. > > =20 >=20 > Can you provide a Fixes: tag for this? Your change will conflicts with > Christian's patch series here: >=20 > http://patchwork.ozlabs.org/project/netdev/list/?series=3D98063 >=20 > > Signed-off-by: Marek Beh=C3=BAn > > Cc: Andrew Lunn > > Cc: Florian Fainelli > > Cc: Michal Vok=C3=A1=C4=8D > > Cc: John Crispin > > Cc: Wei Yongjun > > --- > > drivers/net/dsa/qca8k.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > >=20 > > diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c > > index cdcde7f8e0b2..eb199193cc3b 100644 > > --- a/drivers/net/dsa/qca8k.c > > +++ b/drivers/net/dsa/qca8k.c > > @@ -625,7 +625,7 @@ qca8k_phy_read(struct dsa_switch *ds, int phy, > > int regnum) { > > struct qca8k_priv *priv =3D (struct qca8k_priv *)ds->priv; > > =20 > > - return mdiobus_read(priv->bus, phy, regnum); > > + return mdiobus_read(priv->bus, phy - 1, regnum); > > } > > =20 > > static int > > @@ -633,7 +633,7 @@ qca8k_phy_write(struct dsa_switch *ds, int phy, > > int regnum, u16 val) { > > struct qca8k_priv *priv =3D (struct qca8k_priv *)ds->priv; > > =20 > > - return mdiobus_write(priv->bus, phy, regnum, val); > > + return mdiobus_write(priv->bus, phy - 1, regnum, val); > > } > > =20 > > static void > > =20 >=20 >=20