From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tiwei Bie Subject: Re: [PATCH v2] drivers/virtio: fix duplicate naming of include guard Date: Fri, 22 Mar 2019 14:06:32 +0800 Message-ID: <20190322060632.GA32747@dpdk-tbie.sh.intel.com> References: <1553090259-30893-1-git-send-email-andrius.sirvys@intel.com> <1553162993-42643-1-git-send-email-andrius.sirvys@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: dev@dpdk.org, Maxime Coquelin , Zhihong Wang , stable@dpdk.org, jianfeng.tan@intel.com To: Andrius Sirvys Return-path: Content-Disposition: inline In-Reply-To: <1553162993-42643-1-git-send-email-andrius.sirvys@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Mar 21, 2019 at 10:09:53AM +0000, Andrius Sirvys wrote: > "The macro name '_VHOST_NET_USER_H' of this include guard is used > in 2 different header files." > > lib/librte_vhost/vhost_user.h has the same include guard. > Renamed the include guard in vhost.h to differentiate. > > Fixes: 6a84c37e3975 ("net/virtio-user: add vhost-user adapter layer") > Cc: jianfeng.tan@intel.com > Signed-off-by: Andrius Sirvys > Acked-by: Rami Rosen > --- > v2: changed the name of the variable > --- > drivers/net/virtio/virtio_user/vhost.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/virtio/virtio_user/vhost.h b/drivers/net/virtio/virtio_user/vhost.h > index 83a85cc..55f4703 100644 > --- a/drivers/net/virtio/virtio_user/vhost.h > +++ b/drivers/net/virtio/virtio_user/vhost.h > @@ -2,8 +2,8 @@ > * Copyright(c) 2010-2016 Intel Corporation > */ > > -#ifndef _VHOST_NET_USER_H > -#define _VHOST_NET_USER_H > +#ifndef _VIRTIO_USER_VHOST_H > +#define _VIRTIO_USER_VHOST_H > > #include > #include > -- > 2.7.4 Reviewed-by: Tiwei Bie