From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id A6BE66E2F0 for ; Fri, 22 Mar 2019 09:51:56 +0000 (UTC) Date: Fri, 22 Mar 2019 11:51:55 +0200 From: Andi Shyti Message-ID: <20190322095155.GA1557@intel.intel> References: <20190321160528.4131-1-andi.shyti@intel.com> <20190321160528.4131-5-andi.shyti@intel.com> <6b531677-8e74-c51c-535a-bb5e1c1f2ac7@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6b531677-8e74-c51c-535a-bb5e1c1f2ac7@linux.intel.com> Subject: Re: [igt-dev] [PATCH v15 4/5] lib/i915: add gem_engine_topology library and for_each loop definition List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Tvrtko Ursulin Cc: IGT dev , Andi Shyti List-ID: SGkgVHZydGtvLAoKPiA+ICtzdGF0aWMgdm9pZCBpbml0X2VuZ2luZShzdHJ1Y3QgaW50ZWxfZXhl Y3V0aW9uX2VuZ2luZTIgKmUyLCBjb25zdCBjaGFyICpuYW1lLAo+ID4gKwkJCXVpbnQxNl90IGNs YXNzLCB1aW50MTZfdCBpbnN0YW5jZSwgdWludDY0X3QgZmxhZ3MpCj4gCj4gWW91IGFyZSBrZWVw aW5nIG5hbWUgZm9yIHRoZSBmdXR1cmU/IChJdCBpcyB1bnVzZWQgYXQgdGhlIG1vbWVudC4pCgpJ IHNpbXBseSBmb3Jnb3QgdG8gcmVtb3ZlIGl0IDopCgo+ID4gK3sKPiA+ICsJc3RhdGljIGNvbnN0 IGNoYXIgKnVua25vd25fbmFtZSA9ICJ1bmtub3duIiwKPiA+ICsJCQkgICp2aXJ0dWFsX25hbWUg PSAidmlydHVhbCI7Cj4gCj4gVW51c3VhbCBzdHlsZSBidXQgaXQgaXMgYWN0dWFsbHkgcmVhZGFi bGUgc28gSSB0aGluayBJIGxpa2UgaXQuCgpsaWtlIHRoZSBmdW5jdGlvbiBiZWxvdywgaXQgZG9l c24ndCBoYXBwZW4gZXZlcnlkYXkgdG8gZGVjbGFyZQp2YXJpYWJsZXMvZnVuY3Rpb25zIHdoZXJl IHRoZSBsb25nZXN0IHBhcnQgb2YgdGhlIGxpbmUgaXMgdGhlCnR5cGUuCgpOZWVkIHRvIGNvbWUg b3V0IHdpdGggc29tZXRoaW5nIDopCgo+ID4gKwo+ID4gKwllMi0+Y2xhc3MgICAgPSBjbGFzczsK PiA+ICsJZTItPmluc3RhbmNlID0gaW5zdGFuY2U7Cj4gPiArCWUyLT5mbGFncyAgICA9IGZsYWdz Owo+ID4gKwo+ID4gKwlpZiAoY2xhc3MgPCAwICYmIGluc3RhbmNlIDwgMCkgewo+ID4gKwkJZTIt Pm5hbWUgPSB2aXJ0dWFsX25hbWU7Cj4gPiArCX0gZWxzZSB7Cj4gPiArCQljb25zdCBzdHJ1Y3Qg aW50ZWxfZXhlY3V0aW9uX2VuZ2luZTIgKl9fZTI7Cj4gPiArCj4gPiArCQlfX2Zvcl9lYWNoX3N0 YXRpY19lbmdpbmUoX19lMikKPiA+ICsJCQlpZiAoX19lMi0+Y2xhc3MgPT0gY2xhc3MgJiYgX19l Mi0+aW5zdGFuY2UgPT0gaW5zdGFuY2UpCj4gPiArCQkJCWJyZWFrOwo+ID4gKwo+ID4gKwkJZTIt Pm5hbWUgPSBfX2UyLT5uYW1lID8gX19lMi0+bmFtZSA6IHVua25vd25fbmFtZTsKPiAKPiBJJ3Zl IG5vdyBzdGFydGVkIHRvIHdvcnJ5IGFib3V0IGhvdyB3aWxsIENJL2J1Z2xvZyBoYW5kbGUgdXMg Zm9yZ2V0dGluZyB0bwo+IGV4cGFuZCB0aGUgc3RhdGljIGxpc3QuIChNb3JlIHRoYW4gb25lIHN1 YnRlc3Qgb2YgYSBzYW1lIG5hbWUgZm9yCj4gInRlc3QtJGVuZ2luZV9uYW1lIiBvbmVzPykgRG8g d2Ugd2FudCBhbmQgaWd0X3dhcm4gb24gdW5rbm93biBlbmdpbmVzIHRvCj4gbWFrZSBpdCBtb3Jl IHZpc2libGU/IE9yIGV2ZW4ganVzdCBjcmFzaD8KClJpZ2h0ISBJIGd1ZXNzIGp1c3QgYSB3YXJu aW5nIHdvdWxkIGJlIG5pY2UsIHdlIGNhbiBnYXRoZXIgbW9yZQppbmZvcm1hdGlvbiBmcm9tIHRo ZSBsb2dzIGFib3V0IHVua293biBlbmdpbmVzLi4uIEkgZ3Vlc3MuCgo+ID4gKwlpZiAobmVuZ2lu ZXMgPiBJOTE1X0VYRUNfUklOR19NQVNLICsgMSkgewo+ID4gKwkJZW5naW5lX2RhdGEuZXJyb3Ig PSByZXQgPyByZXQgOiAtRUlOVkFMOwo+ID4gKwkJcmV0dXJuIGVuZ2luZV9kYXRhOwo+ID4gKwl9 Cj4gCj4gSWYgd2Ugb25lIGRheSBhbGxvdyBtb3JlIGVuZ2luZXMgaW4gdGhlIG1hcCB0aGFuIHRo ZSBjdXJyZW50IGxpbWl0PwoKZm9yIG5vdyB0aGlzIGlzIGEgZHJpdmVyIGxpbWl0YXRpb24gYW5k IHRoYXQncyB3aGF0IGlndCBjaGVja3MuIEkKZ3Vlc3MgdGhlIHJpZ2h0IGFwcHJvYWNoIHdvdWxk IGJlIHRvIHVwZGF0ZSBpZ3QgYWNjb3JkaW5nIHRvIHRoZQpkcml2ZXIsIHJpZ2h0PwoKPiBJdCBs b29rcyB0aGlzIHdvdWxkIG1ha2UgdGhlIGl0ZXJhdG9yIG5vdCB3b3JrLiBXYXMgdGhhdCB0aGUg aW50ZW50aW9uPyBXaGF0Cj4gaXMgdGhlIHBvaW50IG9mIGNvbnRpbnVpbmcgdGhlbiByYXRoZXIg dGhhbiBqdXN0IGFzc2VydGluZz8KCnllcywgdGhlIGl0ZXJhdG9yIHdvdWxkbid0IGxvb3AgYW5k IHdvdWxkIHByb3ZpZGUgYSAwIHNpemUgbGlzdApvZiBlbmdpbmVzLiBBc3NlcnRpbmcgbWFrZXMg bW9yZSBzZW5zZS4KCj4gPiArc3RydWN0IGludGVsX2V4ZWN1dGlvbl9lbmdpbmUyCj4gPiArCSpp bnRlbF9nZXRfY3VycmVudF9lbmdpbmUoc3RydWN0IGludGVsX2VuZ2luZV9kYXRhICplZCkKPiAK PiBVbnVzdWFsIGNvZGluZyBzdHlsZSwgd2UgdXNlOgo+IAo+IHR5cGUKPiBmdW5jKHBhcmFtcykK PiAKPiBvcjoKPiAKPiB0eXBlIGZ1bmMocGFyYW1zKQoKeWVzLCBJJ3ZlIHNlZW4gaXQgYXJvdW5k LCBJIHBlcnNvbmFsbHkgZG9uJ3QgbGlrZSBpdCwgYnV0IEkgd2lsbApkbyBpdCBhcyB0aGUgc3R5 bGUgaXMuCgo+ID4gKwlyZXR1cm4gKGVkLT5uIDwgZWQtPm5lbmdpbmVzKSAmJiAhZWQtPmVycm9y ID8KPiA+ICsJCSZlZC0+ZW5naW5lc1tlZC0+bl0gOgo+ID4gKwkJTlVMTDsKPiAKPiBTbyBjb3Vs ZCBzdG9yZSB0aGUgcG9pbnRlciB0byBjdXJyZW50IGVuZ2luZSBpbiB0aGUgaXRlcmF0b3I/CgpJ IHN0aWxsIGRvbid0IHNlZSB0aGUgdXNlIG9mIGl0LCBidXQgb2YgY291cnNlLCBJIGNhbiBhZGQg aXQuIEl0Cm1pZ2h0IG1ha2UgbW9yZSBzZW5zZSBub3cgdGhhdCBJIGhhdmUgYSAiX2N1cnJlbnQi IGFuZCBhICJfbmV4dCIKZnVuY3Rpb24uCgo+ID4gQEAgLTQzNCw3ICs0MzQsNyBAQCBidXN5X2No ZWNrX2FsbChpbnQgZ2VtX2ZkLCBjb25zdCBzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZTIg KmUsCj4gPiAgIAlpID0gMDsKPiA+ICAgCWZkWzBdID0gLTE7Cj4gPiAtCWZvcl9lYWNoX2VuZ2lu ZV9jbGFzc19pbnN0YW5jZShnZW1fZmQsIGVfKSB7Cj4gPiArCWZvcl9lYWNoX2NvbnRleHRfZW5n aW5lKGdlbV9mZCwgMCwgZV8pIHsKPiAKPiBNYWtlIHBlcmZfcG11IHVzZSBmb3JfZWFjaF9waHlz aWNhbF9lbmdpbmUsIGFwYXJ0IGZyb20gdGhlIHRlc3QgZW51bWVyYXRpb24uCgp0aGUgcmVhc29u IEkgZGlkbid0IHJlcGxhY2UgaXQgcmlnaHQgYXdheSBpcyB0aGF0IHN0aWxsIHRvIG1hbnkKZnVu Y3Rpb25zIGFyZSB1c2luZyB0aGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbiBvZgpmb3JfZWFjaF9w aHlzaWNhbF9lbmdpbmUgYW5kIEkgd2FudGVkIHRvIGF2b2lkLCBpbiB0aGlzIHBhdGNoc2V0LAp0 b3VjaGluZyB0b28gbWFueSBmaWxlcy4gSSdtIGFscmVhZHkgY2hhbmdpbmcgbW9yZSB0aGFuIEkK d2lzaGVkLgoKdGhhdCdzIHdoeSBJIGNhbGxlZCBpdDoKCiAgICNkZWZpbmUgX19mb3JfZWFjaF9w aHlzaWNhbF9lbmdpbmVfXyhmZF9fLCBlX18pCgphdCB0aGUgYmVnaW5uaW5nIEkgd2FudGVkIHRv IGNhbGwgaXQKCiAgICNkZWZpbmUgX19ET19OT1RfVVNFX2Zvcl9lYWNoX3BoeXNpY2FsX2VuZ2lu ZV9ZRVRfXyhmZF9fLCBlX18pIFwKCkJlc2lkZXMsIG5vbmUgb2YgYWxsIHRob3NlIGZ1bmN0aW9u cyBpcyB1c2luZyB0aGUgbmV3IGUyCnN0cnVjdHVyZS4KCklmIGl0J3MgT0sgd2l0aCB5b3UsIEkg d291bGQgc3dhcCBldmVyeXRoaW5nIHRvIHVzZSBlaXRoZXIKX19mb3JfZWFjaF9zdGF0aWNfZW5n aW5lIG9yIHRoZSBuZXcgZm9yX2VhY2hfcGh5c2ljYWxfZW5naW5lCnJpZ2h0IGFmdGVyIHRoaXMg cGF0Y2ggZ29lcyBpbi4KCkFuZGkKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3Qt ZGV2