From: Pavel Machek <pavel@ucw.cz>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Input <linux-input@vger.kernel.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Rob Herring <robh@kernel.org>
Subject: Re: [RESEND PATCH v6 04/11] dt-bindings: input: add DT bindings for max77650
Date: Fri, 22 Mar 2019 10:59:21 +0100 [thread overview]
Message-ID: <20190322095920.GM27015@amd> (raw)
In-Reply-To: <CAMRc=Md0-UkY07vkf+irqUKwHFSj=Nq3fBYKFRqNG9nzWv9YRw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1138 bytes --]
On Fri 2019-03-22 10:55:26, Bartosz Golaszewski wrote:
> pt., 22 mar 2019 o 10:09 Pavel Machek <pavel@ucw.cz> napisał(a):
> >
> > On Mon 2019-03-18 18:42:21, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > >
> > > Add the DT binding document for the onkey module of max77650.
> > >
> > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > Reviewed-by: Rob Herring <robh@kernel.org>
> >
> > > + onkey {
> > > + compatible = "maxim,max77650-onkey";
> > > + linux,code = <KEY_END>;
> > > + maxim,onkey-slide;
> > > + };
> >
> > This is certainly wrong.
> >
> > "End" key is normal key on a keyboard, certainly not some kind of
> > slider.
> >
> > And this controller is likely to be used for power key, not end key,
> > right?
>
> But this is just an example of available properties, not a real use-case.
We can have example that makes sense, right?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-03-22 9:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 17:42 [RESEND PATCH v6 00/11] mfd: add support for max77650 PMIC Bartosz Golaszewski
2019-03-18 17:42 ` [RESEND PATCH v6 01/11] dt-bindings: mfd: add DT bindings for max77650 Bartosz Golaszewski
2019-04-02 7:25 ` Lee Jones
2019-03-18 17:42 ` [RESEND PATCH v6 02/11] dt-bindings: power: supply: " Bartosz Golaszewski
2019-03-25 20:46 ` Rob Herring
2019-03-18 17:42 ` [RESEND PATCH v6 03/11] dt-bindings: leds: " Bartosz Golaszewski
2019-03-18 17:42 ` [RESEND PATCH v6 04/11] dt-bindings: input: " Bartosz Golaszewski
2019-03-22 9:09 ` Pavel Machek
2019-03-22 9:55 ` Bartosz Golaszewski
2019-03-22 9:59 ` Pavel Machek [this message]
2019-03-18 17:42 ` [RESEND PATCH v6 05/11] mfd: core: document mfd_add_devices() Bartosz Golaszewski
2019-03-22 9:10 ` Pavel Machek
2019-04-02 7:41 ` Lee Jones
2019-04-02 8:08 ` Bartosz Golaszewski
2019-03-18 17:42 ` [RESEND PATCH v6 06/11] mfd: max77650: new core mfd driver Bartosz Golaszewski
2019-03-22 9:12 ` Pavel Machek
2019-03-26 13:49 ` Bartosz Golaszewski
2019-03-18 17:42 ` [RESEND PATCH v6 07/11] power: supply: max77650: add support for battery charger Bartosz Golaszewski
2019-04-04 3:45 ` Linus Walleij
2019-04-04 3:45 ` Linus Walleij
2019-03-18 17:42 ` [RESEND PATCH v6 08/11] gpio: max77650: add GPIO support Bartosz Golaszewski
2019-03-18 17:42 ` [RESEND PATCH v6 09/11] leds: max77650: add LEDs support Bartosz Golaszewski
2019-03-22 9:21 ` Pavel Machek
2019-03-22 9:53 ` Bartosz Golaszewski
2019-03-22 19:40 ` Jacek Anaszewski
2019-03-18 17:42 ` [RESEND PATCH v6 10/11] input: max77650: add onkey support Bartosz Golaszewski
2019-03-22 9:18 ` Pavel Machek
2019-03-18 17:42 ` [RESEND PATCH v6 11/11] MAINTAINERS: add an entry for max77650 mfd driver Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322095920.GM27015@amd \
--to=pavel@ucw.cz \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.