From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45A12C43381 for ; Fri, 22 Mar 2019 13:20:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 114F12075E for ; Fri, 22 Mar 2019 13:20:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553260859; bh=J3HqjFZ72iKIw6xQL5DarYOww9fuRRyNMJsLEP5x3FM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=qXkgd3o0ZyQUswb1AwdLFcnbJACRCL9QpOQbPiwHBQU1qDE9BPt0iSmpTWxVXARKD fjsexkMraLJL2mD2/2kR+GCB5pIFOS4Q2H8IOBsxgMz7BvUCYjMmNDtWDcZOSm7GcI SpkIEHuwlhhSU0/qFdkWxxJMdakXlPRumyl1kjVg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728617AbfCVNU6 (ORCPT ); Fri, 22 Mar 2019 09:20:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:47214 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728451AbfCVLUt (ORCPT ); Fri, 22 Mar 2019 07:20:49 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1F4FE21916; Fri, 22 Mar 2019 11:20:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553253648; bh=J3HqjFZ72iKIw6xQL5DarYOww9fuRRyNMJsLEP5x3FM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EBnriZ1WvwtSfKN7p4H9mcc7bWH/B9ueoTn23Ksxn6AyVt/4IF1Tm+NFfDqvo+Chc YSUhAmPnPdsD+wUnWXSwkzEzVXGa5JNHVfr4G33kDBXBJtx7t5mmT2yVCTAD43USiC cHe1baOSM+8P8nQOkuvLi4I7YhzAd5OZDiQHsE24= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Mark Brown , Sasha Levin Subject: [PATCH 3.18 029/134] ALSA: compress: prevent potential divide by zero bugs Date: Fri, 22 Mar 2019 12:14:02 +0100 Message-Id: <20190322111211.879359487@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190322111210.465931067@linuxfoundation.org> References: <20190322111210.465931067@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 678e2b44c8e3fec3afc7202f1996a4500a50be93 ] The problem is seen in the q6asm_dai_compr_set_params() function: ret = q6asm_map_memory_regions(dir, prtd->audio_client, prtd->phys, (prtd->pcm_size / prtd->periods), ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ prtd->periods); In this code prtd->pcm_size is the buffer_size and prtd->periods comes from params->buffer.fragments. If we allow the number of fragments to be zero then it results in a divide by zero bug. One possible fix would be to use prtd->pcm_count directly instead of using the division to re-calculate it. But I decided that it doesn't really make sense to allow zero fragments. Signed-off-by: Dan Carpenter Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/core/compress_offload.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c index 53cd5d69293e9..307344452b5c0 100644 --- a/sound/core/compress_offload.c +++ b/sound/core/compress_offload.c @@ -500,7 +500,8 @@ static int snd_compress_check_input(struct snd_compr_params *params) { /* first let's check the buffer parameter's */ if (params->buffer.fragment_size == 0 || - params->buffer.fragments > INT_MAX / params->buffer.fragment_size) + params->buffer.fragments > INT_MAX / params->buffer.fragment_size || + params->buffer.fragments == 0) return -EINVAL; /* now codec parameters */ -- 2.19.1