All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Slavomir Kaslev <kaslevs@vmware.com>
Cc: "linux-trace-devel@vger.kernel.org"  <linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH] trace-cmd: Change tracecmd_msg's buf member type to char *
Date: Fri, 22 Mar 2019 12:14:50 -0400	[thread overview]
Message-ID: <20190322121450.193ed84e@gandalf.local.home> (raw)
In-Reply-To: <CAE0o1Nvph5RHtEuT7rQMtrLyA76B4yVb8rxFKQupYzNLdTkFpw@mail.gmail.com>

On Fri, 22 Mar 2019 15:39:11 +0000
Slavomir Kaslev <kaslevs@vmware.com> wrote:

> You're completely right. I still think that it makes sense to have
> that patch go in, maybe with rewritten commit message.
> In tracecmd_msg_read_data()[1] we do pointer arithmetic on void
> pointer which is undefined behavior (though gcc allows it unless
> -pedantic-errors is passed) and this patch will take care of it.
> 
> Should I resend or drop it?

I think the patch cleans up the code (removes a lot of the type
casting). Resend it with a new change log.

-- Steve

  reply	other threads:[~2019-03-22 16:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-22 15:01 [PATCH] trace-cmd: Change tracecmd_msg's buf member type to char * Slavomir Kaslev
2019-03-22 15:25 ` Steven Rostedt
2019-03-22 15:39   ` Slavomir Kaslev
2019-03-22 16:14     ` Steven Rostedt [this message]
2019-03-22 16:26 Slavomir Kaslev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190322121450.193ed84e@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=kaslevs@vmware.com \
    --cc=linux-trace-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.