From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 1/3] drm/i915/skl: use previous pll hw
 readout
Date: Fri, 22 Mar 2019 15:05:46 +0200
Message-ID: <20190322130546.GN3888@intel.com>
References: <20190321220257.32638-1-lucas.demarchi@intel.com>
 <20190321220257.32638-2-lucas.demarchi@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 48C4E6E380
 for <intel-gfx@lists.freedesktop.org>; Fri, 22 Mar 2019 13:05:50 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190321220257.32638-2-lucas.demarchi@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBNYXIgMjEsIDIwMTkgYXQgMDM6MDI6NTVQTSAtMDcwMCwgTHVjYXMgRGUgTWFyY2hp
IHdyb3RlOgo+IEJ5IHRoZSB0aW1lIHNrbF9kZGlfY2xvY2tfZ2V0KCkgaXMgY2FsbGVkIC0gYW5k
IHRodXMKPiBza2xfY2FsY193cnBsbF9saW5rKCkgLSB3ZSd2ZSBqdXN0IGdvdCB0aGUgaHcgc3Rh
dGUgZnJvbSB0aGUgcGxsCj4gcmVnaXN0ZXJzLiBXZSBkb24ndCBuZWVkIHRvIHJlYWQgdGhlbSBh
Z2Fpbjogd2UgY2FuIHJhdGhlciByZXVzZSB3aGF0Cj4gd2FzIGNhY2hlZCBpbiB0aGUgZHBsbF9o
d19zdGF0ZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBMdWNhcyBEZSBNYXJjaGkgPGx1Y2FzLmRlbWFy
Y2hpQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMg
fCA0OSArKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwg
MjIgaW5zZXJ0aW9ucygrKSwgMjcgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
ZGRpLmMKPiBpbmRleCA5MzNkZjNhNTdhOGEuLjY0NDU0MTkyNDIwOCAxMDA2NDQKPiAtLS0gYS9k
cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2RkaS5jCj4gQEAgLTEyNDAsMjQgKzEyNDAsMTUgQEAgc3RhdGljIGludCBoc3df
ZGRpX2NhbGNfd3JwbGxfbGluayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4g
IAlyZXR1cm4gKHJlZmNsayAqIG4gKiAxMDApIC8gKHAgKiByKTsKPiAgfQo+ICAKPiAtc3RhdGlj
IGludCBza2xfY2FsY193cnBsbF9saW5rKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp
diwKPiAtCQkJICAgICAgIGVudW0gaW50ZWxfZHBsbF9pZCBwbGxfaWQpCj4gK3N0YXRpYyBpbnQg
c2tsX2NhbGNfd3JwbGxfbGluayhzdHJ1Y3QgaW50ZWxfZHBsbF9od19zdGF0ZSAqc3RhdGUpCgpj
b25zdAoKQW5kIHBsZWFzZSBjYWxsIGl0IHBsbF9zdGF0ZSBvciBzb21ldGhpbmcgbGlrZSB0aGF0
LiBCb251cyBwb2ludHMgZm9yCnVuaWZ5aW5nIHRoZSBuYW1pbmcgY29udmVudGlvbiBlbHNld2hl
cmUgYXMgd2VsbC4KCj4gIHsKPiAtCWk5MTVfcmVnX3QgY2ZnY3IxX3JlZywgY2ZnY3IyX3JlZzsK
PiAtCXUzMiBjZmdjcjFfdmFsLCBjZmdjcjJfdmFsOwo+ICAJdTMyIHAwLCBwMSwgcDIsIGRjb19m
cmVxOwo+ICAKPiAtCWNmZ2NyMV9yZWcgPSBEUExMX0NGR0NSMShwbGxfaWQpOwo+IC0JY2ZnY3Iy
X3JlZyA9IERQTExfQ0ZHQ1IyKHBsbF9pZCk7Cj4gKwlwMCA9IHN0YXRlLT5jZmdjcjIgJiBEUExM
X0NGR0NSMl9QRElWX01BU0s7Cj4gKwlwMiA9IHN0YXRlLT5jZmdjcjIgJiBEUExMX0NGR0NSMl9L
RElWX01BU0s7Cj4gIAo+IC0JY2ZnY3IxX3ZhbCA9IEk5MTVfUkVBRChjZmdjcjFfcmVnKTsKPiAt
CWNmZ2NyMl92YWwgPSBJOTE1X1JFQUQoY2ZnY3IyX3JlZyk7Cj4gLQo+IC0JcDAgPSBjZmdjcjJf
dmFsICYgRFBMTF9DRkdDUjJfUERJVl9NQVNLOwo+IC0JcDIgPSBjZmdjcjJfdmFsICYgRFBMTF9D
RkdDUjJfS0RJVl9NQVNLOwo+IC0KPiAtCWlmIChjZmdjcjJfdmFsICYgIERQTExfQ0ZHQ1IyX1FE
SVZfTU9ERSgxKSkKPiAtCQlwMSA9IChjZmdjcjJfdmFsICYgRFBMTF9DRkdDUjJfUURJVl9SQVRJ
T19NQVNLKSA+PiA4Owo+ICsJaWYgKHN0YXRlLT5jZmdjcjIgJiAgRFBMTF9DRkdDUjJfUURJVl9N
T0RFKDEpKQo+ICsJCXAxID0gKHN0YXRlLT5jZmdjcjIgJiBEUExMX0NGR0NSMl9RRElWX1JBVElP
X01BU0spID4+IDg7Cj4gIAllbHNlCj4gIAkJcDEgPSAxOwo+ICAKPiBAQCAtMTI5MiwxMCArMTI4
MywxMCBAQCBzdGF0aWMgaW50IHNrbF9jYWxjX3dycGxsX2xpbmsoc3RydWN0IGRybV9pOTE1X3By
aXZhdGUgKmRldl9wcml2LAo+ICAJCWJyZWFrOwo+ICAJfQo+ICAKPiAtCWRjb19mcmVxID0gKGNm
Z2NyMV92YWwgJiBEUExMX0NGR0NSMV9EQ09fSU5URUdFUl9NQVNLKSAqIDI0ICogMTAwMDsKPiAr
CWRjb19mcmVxID0gKHN0YXRlLT5jZmdjcjEgJiBEUExMX0NGR0NSMV9EQ09fSU5URUdFUl9NQVNL
KSAqIDI0ICogMTAwMDsKPiAgCj4gLQlkY29fZnJlcSArPSAoKChjZmdjcjFfdmFsICYgRFBMTF9D
RkdDUjFfRENPX0ZSQUNUSU9OX01BU0spID4+IDkpICogMjQgKgo+IC0JCTEwMDApIC8gMHg4MDAw
Owo+ICsJZGNvX2ZyZXEgKz0gKCgoc3RhdGUtPmNmZ2NyMSAmIERQTExfQ0ZHQ1IxX0RDT19GUkFD
VElPTl9NQVNLKSA+PiA5KQo+ICsJCSAgICAgKiAyNCAqIDEwMDApIC8gMHg4MDAwOwo+ICAKPiAg
CWlmIChXQVJOX09OKHAwID09IDAgfHwgcDEgPT0gMCB8fCBwMiA9PSAwKSkKPiAgCQlyZXR1cm4g
MDsKPiBAQCAtMTU0NiwyMCArMTUzNywyMyBAQCBzdGF0aWMgdm9pZCBjbmxfZGRpX2Nsb2NrX2dl
dChzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgc3RhdGljIHZvaWQgc2tsX2RkaV9j
bG9ja19nZXQoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gIAkJCQlzdHJ1Y3QgaW50
ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcpCj4gIHsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2
YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZW5jb2Rlci0+YmFzZS5kZXYpOwo+ICsJc3RydWN0IGlu
dGVsX2RwbGxfaHdfc3RhdGUgKnN0YXRlOwo+ICAJaW50IGxpbmtfY2xvY2sgPSAwOwo+IC0JdTMy
IGRwbGxfY3RsMTsKPiAtCWVudW0gaW50ZWxfZHBsbF9pZCBwbGxfaWQ7Cj4gIAo+IC0JcGxsX2lk
ID0gaW50ZWxfZ2V0X3NoYXJlZF9kcGxsX2lkKGRldl9wcml2LCBwaXBlX2NvbmZpZy0+c2hhcmVk
X2RwbGwpOwo+IC0KPiAtCWRwbGxfY3RsMSA9IEk5MTVfUkVBRChEUExMX0NUUkwxKTsKPiArCS8q
IEZvciBEREkgcG9ydHMgd2UgYWx3YXlzIHVzZSBhIHNoYXJlZCBQTEwuICovCj4gKwlpZiAoV0FS
Tl9PTighcGlwZV9jb25maWctPnNoYXJlZF9kcGxsKSkKPiArCQlnb3RvIGVuZDsKCnJldHVybiAw
IHdpbGwgZG8uCgpPciBtYXliZSBlbGltaW5hdGUgdGhlc2UgZW50aXJlbHkuIEkgZG9uJ3Qgc2Vl
IHRoZXNlIGNoZWNrcyBhcwpwYXJ0aWN1bGFybHkgdXNlZnVsLgoKPiAgCj4gLQlpZiAoZHBsbF9j
dGwxICYgRFBMTF9DVFJMMV9IRE1JX01PREUocGxsX2lkKSkgewo+IC0JCWxpbmtfY2xvY2sgPSBz
a2xfY2FsY193cnBsbF9saW5rKGRldl9wcml2LCBwbGxfaWQpOwo+ICsJLyoKPiArCSAqIGN0cmwx
IHJlZ2lzdGVyIGlzIGFscmVhZHkgc2hpZnRlZCBmb3IgZWFjaCBwbGwsIGp1c3QgdXNlIDAgdG8g
Z2V0Cj4gKwkgKiB0aGUgaW50ZXJuYWwgc2hpZnQgZm9yIGVhY2ggZmllbGQKPiArCSAqLwo+ICsJ
c3RhdGUgPSAmcGlwZV9jb25maWctPmRwbGxfaHdfc3RhdGU7Cj4gKwlpZiAoc3RhdGUtPmN0cmwx
ICYgRFBMTF9DVFJMMV9IRE1JX01PREUoMCkpIHsKPiArCQlsaW5rX2Nsb2NrID0gc2tsX2NhbGNf
d3JwbGxfbGluayhzdGF0ZSk7Cj4gIAl9IGVsc2Ugewo+IC0JCWxpbmtfY2xvY2sgPSBkcGxsX2N0
bDEgJiBEUExMX0NUUkwxX0xJTktfUkFURV9NQVNLKHBsbF9pZCk7Cj4gLQkJbGlua19jbG9jayA+
Pj0gRFBMTF9DVFJMMV9MSU5LX1JBVEVfU0hJRlQocGxsX2lkKTsKPiArCQlsaW5rX2Nsb2NrID0g
c3RhdGUtPmN0cmwxICYgRFBMTF9DVFJMMV9MSU5LX1JBVEVfTUFTSygwKTsKPiArCQlsaW5rX2Ns
b2NrID4+PSBEUExMX0NUUkwxX0xJTktfUkFURV9TSElGVCgwKTsKPiAgCj4gIAkJc3dpdGNoIChs
aW5rX2Nsb2NrKSB7Cj4gIAkJY2FzZSBEUExMX0NUUkwxX0xJTktfUkFURV84MTA6Cj4gQEAgLTE1
ODcsNiArMTU4MSw3IEBAIHN0YXRpYyB2b2lkIHNrbF9kZGlfY2xvY2tfZ2V0KHN0cnVjdCBpbnRl
bF9lbmNvZGVyICplbmNvZGVyLAo+ICAJCWxpbmtfY2xvY2sgKj0gMjsKPiAgCX0KPiAgCj4gK2Vu
ZDoKPiAgCXBpcGVfY29uZmlnLT5wb3J0X2Nsb2NrID0gbGlua19jbG9jazsKPiAgCj4gIAlkZGlf
ZG90Y2xvY2tfZ2V0KHBpcGVfY29uZmlnKTsKPiAtLSAKPiAyLjIwLjEKCi0tIApWaWxsZSBTeXJq
w6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn
Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4