From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/2] drm/i915/icl: Enable TRANSCODER PORT SYNC for tiled displays across separate ports Date: Fri, 22 Mar 2019 15:16:03 +0200 Message-ID: <20190322131603.GR3888@intel.com> References: <20190322015939.23189-1-manasi.d.navare@intel.com> <20190322015939.23189-2-manasi.d.navare@intel.com> <87va0bb6ce.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 42F4A6E388 for ; Fri, 22 Mar 2019 13:16:07 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87va0bb6ce.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBNYXIgMjIsIDIwMTkgYXQgMTE6MzQ6MjVBTSArMDIwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gVGh1LCAyMSBNYXIgMjAxOSwgTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJl QGludGVsLmNvbT4gd3JvdGU6Cj4gPiBJbiBjYXNlIG9mIHRpbGVkIGRpc3BsYXlzIHdoZXJlIGRp ZmZlcmVudCB0aWxlcyBhcmUgZGlzcGxheWVkIGFjcm9zcwo+ID4gZGlmZmVyZW50IHBvcnRzLCB3 ZSBuZWVkIHRvIHN5bmNocm9uaXplIHRoZSB0cmFuc2NvZGVycyBpbnZvbHZlZC4KPiA+IFRoaXMg cGF0Y2ggaW1wbGVtZW50cyB0aGUgdHJhbnNjb2RlciBwb3J0IHN5bmMgZmVhdHVyZSBmb3IKPiA+ IHN5bmNocm9uaXppbmcgb25lIG1hc3RlciB0cmFuc2NvZGVyIHdpdGggb25lIG9yIG1vcmUgc2xh dmUKPiA+IHRyYW5zY29kZXJzLiBUaGlzIGlzIG9ubHkgZW5iYWxlZCBpbiBzbGF2ZSB0cmFuc2Nv ZGVyCj4gPiBhbmQgdGhlIG1hc3RlciB0cmFuc2NvZGVyIGlzIHVuYXdhcmUgdGhhdCBpdCBpcyBv cGVyYXRpbmcKPiA+IGluIHRoaXMgbW9kZS4KPiA+IFRoaXMgaGFzIGJlZW4gdGVzdGVkIHdpdGgg dGlsZWQgZGlzcGxheSBjb25uZWN0ZWQgdG8gSUNMLgo+ID4KPiA+IENjOiBEYW5pZWwgVmV0dGVy IDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KPiA+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gQ2M6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFy dGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPiBDYzogTWF0dCBSb3BlciA8bWF0dGhl dy5kLnJvcGVyQGludGVsLmNvbT4KPiA+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50 ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJl QGludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYyB8IDU5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiA+ICAxIGZpbGUgY2hhbmdl ZCwgNTkgaW5zZXJ0aW9ucygrKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMKPiA+IGluZGV4IDk5ODBhNGVkOGM5Yy4uMTZiNDZhM2NiM2JkIDEwMDY0NAo+ID4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IEBAIC00MDA5LDYgKzQwMDksNjIgQEAgc3Rh dGljIHZvaWQgaWNsX3NldF9waXBlX2NoaWNrZW4oc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4g PiAgCUk5MTVfV1JJVEUoUElQRV9DSElDS0VOKHBpcGUpLCB0bXApOwo+ID4gIH0KPiA+ICAKPiA+ ICtzdGF0aWMgdm9pZCBpY2xfc2V0X3RyYW5zY29kZXJfcG9ydF9zeW5jKHN0cnVjdCBpbnRlbF9h dG9taWNfc3RhdGUgKm9sZF9pbnRlbF9zdGF0ZSwKPiA+ICsJCQkJCSBjb25zdCBzdHJ1Y3QgaW50 ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiA+ICt7Cj4gPiArCXN0cnVjdCBpbnRlbF9jcnRj ICpjcnRjID0gdG9faW50ZWxfY3J0YyhjcnRjX3N0YXRlLT5iYXNlLmNydGMpOwo+ID4gKwlzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGNydGMtPmJhc2UuZGV2KTsK PiA+ICsJc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmdlbmxvY2tfY3J0Y19zdGF0ZSA9IE5VTEw7 Cj4gPiArCWVudW0gdHJhbnNjb2RlciBnZW5sb2NrX3RyYW5zY29kZXI7Cj4gPiArCXUzMiB0cmFu c19kZGlfZnVuY19jdGwyX3ZhbDsKPiA+ICsJdTggbWFzdGVyX3NlbGVjdDsKPiA+ICsKPiA+ICsJ LyoKPiA+ICsJICogUG9ydCBTeW5jIE1vZGUgY2Fubm90IGJlIGVuYWJsZWQgZm9yIERQIE1TVAo+ ID4gKwkgKi8KPiA+ICsJaWYgKGludGVsX2NydGNfaGFzX3R5cGUoY3J0Y19zdGF0ZSwgSU5URUxf T1VUUFVUX0RQX01TVCkpCj4gPiArCQlyZXR1cm47Cj4gPiArCj4gPiArCS8qCj4gPiArCSAqIENv bmZpZ3VyZSB0aGUgbWFzdGVyIHNlbGVjdCBhbmQgZW5hYmxlIFRyYW5zY29kZXIgUG9ydCBTeW5j IGZvcgo+ID4gKwkgKiBTbGF2ZSBDUlRDcyB0cmFuc2NvZGVyLgo+ID4gKwkgKi8KPiA+ICsJaWYg KCFjcnRjX3N0YXRlLT5nZW5sb2NrX2NydGMpCj4gPiArCQlyZXR1cm47Cj4gPiArCj4gPiArCWdl bmxvY2tfY3J0Y19zdGF0ZSA9IGludGVsX2F0b21pY19nZXRfbmV3X2NydGNfc3RhdGUob2xkX2lu dGVsX3N0YXRlLAo+ID4gKwkJCQkJCQkgICAgIGNydGNfc3RhdGUtPmdlbmxvY2tfY3J0Yyk7Cj4g PiArCWlmIChXQVJOX09OKCFnZW5sb2NrX2NydGNfc3RhdGUpKQo+ID4gKwkJcmV0dXJuOwo+ID4g Kwo+ID4gKwlnZW5sb2NrX3RyYW5zY29kZXIgPSBnZW5sb2NrX2NydGNfc3RhdGUtPmNwdV90cmFu c2NvZGVyOwo+ID4gKwlzd2l0Y2ggKGdlbmxvY2tfdHJhbnNjb2Rlcikgewo+ID4gKwljYXNlIFRS QU5TQ09ERVJfQToKPiA+ICsJCW1hc3Rlcl9zZWxlY3QgPSAxOwo+ID4gKwkJYnJlYWs7Cj4gPiAr CWNhc2UgVFJBTlNDT0RFUl9COgo+ID4gKwkJbWFzdGVyX3NlbGVjdCA9IDI7Cj4gPiArCQlicmVh azsKPiA+ICsJY2FzZSBUUkFOU0NPREVSX0M6Cj4gPiArCQltYXN0ZXJfc2VsZWN0ID0gMzsKPiA+ ICsJCWJyZWFrOwo+ID4gKwljYXNlIFRSQU5TQ09ERVJfRURQOgo+ID4gKwlkZWZhdWx0Ogo+ID4g KwkJbWFzdGVyX3NlbGVjdCA9IDA7Cj4gPiArCQlicmVhazsKPiA+ICsJfQo+ID4gKwkvKiBTZXQg dGhlIG1hc3RlciBzZWxlY3QgYml0cyBmb3IgVHJhbmFzY29kZXIgUG9ydCBTeW5jICovCj4gPiAr CXRyYW5zX2RkaV9mdW5jX2N0bDJfdmFsID0gSTkxNV9SRUFEKFRSQU5TX0RESV9GVU5DX0NUTDIo Y3J0Y19zdGF0ZS0+Y3B1X3RyYW5zY29kZXIpKTsKPiA+ICsJdHJhbnNfZGRpX2Z1bmNfY3RsMl92 YWwgfD0gKFBPUlRfU1lOQ19NT0RFX01BU1RFUl9TRUxFQ1QobWFzdGVyX3NlbGVjdCkgJgo+ID4g KwkJCQkgICAgUE9SVF9TWU5DX01PREVfTUFTVEVSX1NFTEVDVF9NQVNLKSA8PAo+ID4gKwkJUE9S VF9TWU5DX01PREVfTUFTVEVSX1NFTEVDVF9TSElGVDsKPiAKPiBUaGlzIGRvZXNuJ3QgZG8gd2hh dCB5b3UgdGhpbmsgaXQgZG9lcy4gSVRZTSwKPiAKPiAJdmFsID0gSTkxNV9SRUFEKCk7Cj4gICAg ICAgICB2YWwgJj0gfkZPT19NQVNLOwo+ICAgICAgICAgdmFsIHw9IEZPT19CQVI7CgpBbHNvIHdl IGFscmVheWQgaGF2ZSBhIHBsYWNlIHdoZXJlIHdlIHdyaXRlIHRoaXMgcmVnaXN0ZXJzLiBJcyB0 aGVyZQpzb21lIG1hZ2ljIHJlcXVpcmVtZW50IHdoeSB0aGVzZSBiaXRzIGNhbid0IGJlIHNldCB0 aGVyZSBhbG9uZyB3aXRoCmV2ZXlydGhpbmcgZWxzZT8KCj4gCj4gUGxlYXNlIGFjdHVhbGx5IHVz ZSBqdXN0ICJ2YWwiIGZvciB0aGUgdmFyaWFibGUsIHRoZSBsb25nIG5hbWUganVzdAo+IG1ha2Vz IHRoaXMgYWxsIGhhcmRlciB0byByZWFkLgo+IAo+IEJSLAo+IEphbmkuCj4gCj4gCj4gPiArCS8q IEVuYWJsZSBUcmFuc2NvZGVyIFBvcnQgU3luYyAqLwo+ID4gKwl0cmFuc19kZGlfZnVuY19jdGwy X3ZhbCB8PSBQT1JUX1NZTkNfTU9ERV9FTkFCTEU7Cj4gPiArCj4gPiArCUk5MTVfV1JJVEUoVFJB TlNfRERJX0ZVTkNfQ1RMMihjcnRjX3N0YXRlLT5jcHVfdHJhbnNjb2RlciksCj4gPiArCQkgICB0 cmFuc19kZGlfZnVuY19jdGwyX3ZhbCk7Cj4gPiArfQo+ID4gKwo+ID4gIHN0YXRpYyB2b2lkIGlu dGVsX3VwZGF0ZV9waXBlX2NvbmZpZyhjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqb2xk X2NydGNfc3RhdGUsCj4gPiAgCQkJCSAgICAgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUg Km5ld19jcnRjX3N0YXRlKQo+ID4gIHsKPiA+IEBAIC01OTYwLDYgKzYwMTYsOSBAQCBzdGF0aWMg dm9pZCBoYXN3ZWxsX2NydGNfZW5hYmxlKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2Nv bmZpZywKPiA+ICAJaWYgKCF0cmFuc2NvZGVyX2lzX2RzaShjcHVfdHJhbnNjb2RlcikpCj4gPiAg CQlpbnRlbF9zZXRfcGlwZV90aW1pbmdzKHBpcGVfY29uZmlnKTsKPiA+ICAKPiA+ICsJaWYgKElO VEVMX0dFTihkZXZfcHJpdikgPj0gMTEpCj4gPiArCQlpY2xfc2V0X3RyYW5zY29kZXJfcG9ydF9z eW5jKG9sZF9pbnRlbF9zdGF0ZSwgcGlwZV9jb25maWcpOwo+ID4gKwo+ID4gIAlpbnRlbF9zZXRf cGlwZV9zcmNfc2l6ZShwaXBlX2NvbmZpZyk7Cj4gPiAgCj4gPiAgCWlmIChjcHVfdHJhbnNjb2Rl ciAhPSBUUkFOU0NPREVSX0VEUCAmJgo+IAo+IC0tIAo+IEphbmkgTmlrdWxhLCBJbnRlbCBPcGVu IFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4