From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BAB0C43381 for ; Fri, 22 Mar 2019 13:42:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5B9720835 for ; Fri, 22 Mar 2019 13:41:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="epaMR4BB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5B9720835 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I01hIlkFiiQ/qN7SPYlGWB+DWEDuGghhei2SSCkVQFM=; b=epaMR4BB0Jqm9N I3CaL/wUrtWN70rGeBcDlzjpNbJVHUoq8GotFojWqnhauHOSNEKGYfr90PVxzxvizpHDtlKuFfKvk FVNb+uhNnynhnqK8Xe30rBCnOTeZG4wL0B7KK4dnSEGkNKBvcV9GqZrBva4+OuAnT2IXXTxVUN9Qc LIR50QOFUeJbYtYm8ejXdnUhLvVugNblKrr+gEQBnG3yYurEoSRyfKw6cP5yDhmveVT+5ycx0TpcK W4B+9HJSMawmjxdfhI+PaQkEJKlZLelSz9osQ8Gnv0Wov9QckFCvwyHO5tlS6TpWSFYpci6Y1G9As +fBOXTC/oAnDLjIawPlQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h7KQl-0008CW-JK; Fri, 22 Mar 2019 13:41:55 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1h7KPb-0006fp-Kq; Fri, 22 Mar 2019 13:40:43 +0000 Date: Fri, 22 Mar 2019 06:40:43 -0700 From: Christoph Hellwig To: Anup Patel Subject: Re: 32bit kernel is broken for Linux-5.1-rc1 due to GCC cmodel=medlow Message-ID: <20190322134043.GA18818@infradead.org> References: <20190322104209.GB24367@rapoport-lnx> <20190322132556.GB19263@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Le Moal , Anup Patel , Palmer Dabbelt , Mike Rapoport , Christoph Hellwig , Atish Patra , linux-riscv@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Mar 22, 2019 at 07:07:29PM +0530, Anup Patel wrote: > I think reverting is not right way to go here because there is deeper issue > in using GCC cmodel=medlow with setup_vm() which is called from assembly > with MMU off. > > Even if we keep setup_vm() in kernel/setup.c then still in-future it can break > for 32bit system as more code gets added to kernel/setup.c. > > The setup_vm() should not be sensitive to which source file it is placed in. > The patch which breaks 32bit kernel just moves setup_vm() from > kernel/setup.c to mm/init.c. I am not saying the revert is the final solution. I'm just saying that 5.1-rc is not the place we should be doing the major surgery. Revert fox 5.1, fix for real for 5.2+. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv