From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5662C43381 for ; Fri, 22 Mar 2019 16:56:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 74BC22190A for ; Fri, 22 Mar 2019 16:56:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="pYj1gf7i" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728707AbfCVQ46 (ORCPT ); Fri, 22 Mar 2019 12:56:58 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:51753 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728202AbfCVQ45 (ORCPT ); Fri, 22 Mar 2019 12:56:57 -0400 Received: by mail-wm1-f66.google.com with SMTP id 4so2854379wmf.1 for ; Fri, 22 Mar 2019 09:56:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PLIaCdgvtoARdK9t4Za2afcQhi8E2HIleH7X+XtASVk=; b=pYj1gf7i1VS/SdH3MT72ne5bE0gt2vGm4NJsLbqUBd84OZS1EoNSe05fvyVkzjx+V9 XnpkutInpXy5NsxqnCZUHsihDCUUsFRrQ9P8+DiOCPHk/mi4zfkq3zGg2abt/D8ztB9Z HEEPWX8/glzu7hQY5STycwWw+vAoUZjYf0GNB7baJcabg6xSvBPFCHeqqliP2dsvNKlq h7KQ/eXSvPb2KPhf4M/RPF1EgHjcbdGLWT7IBWyE6jyogvBFR2X0sQJFVrv9A1I7z57U o9XrPT1HRaI/GF1XuTxC43h/vHn2PfqMhzMidDjynB572gwCHuu8/Od4h+4EDnpksrMP ZbZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PLIaCdgvtoARdK9t4Za2afcQhi8E2HIleH7X+XtASVk=; b=hTxwYfHy8mq+6HRrpaVdhvfehpwyJD3z73dPQljk3KMqNJY9scfsBiTRmS4J1bmgJS iZvggJJzv1PuvcshpMQcxbxwgALP2YMJsgle3H2Fr7t1AiSMWGGutOu2Yaxexhpbd4Oe WaA6ytJ8Kt8y68SEMRONyd3J1jm4OVIR8Qqk+iYYIFstqgvol4Fuonpmc9K0kTPFkr85 nHzfaTorzQniy5oidavOCcNxPoXSCKjHt3dYIpbKbdeEQ/CGHdle0bXg6pF/Bo8G0nt+ UNsH9LAOZR8xerb4R5nZcjfXtFw2GtF4RcVHRYVNuTjRBOIyCMcKO4d5Irmu6s6aI1xA o5/g== X-Gm-Message-State: APjAAAVgpWjimscTFZxRd3BaTm44x35ShDRpa6Al26nF7c5zEZhzimSw i2jXnkKeOv6kYYMYrL+1I2fMslN7ztk= X-Google-Smtp-Source: APXvYqzNVfmDWWC4XhsGSYlcJay+G1uiCujnvMmO24r8P9BVfg99ParmqbPHI5uRpJHVkOuIqs4qJg== X-Received: by 2002:a1c:988d:: with SMTP id a135mr2371318wme.24.1553273815385; Fri, 22 Mar 2019 09:56:55 -0700 (PDT) Received: from localhost ([195.39.71.253]) by smtp.gmail.com with ESMTPSA id i28sm2009552wrc.32.2019.03.22.09.56.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Mar 2019 09:56:54 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: [patch net-next v2 10/15] net: devlink: disallow port_attrs_set() to be called before register Date: Fri, 22 Mar 2019 17:56:31 +0100 Message-Id: <20190322165636.1725-11-jiri@resnulli.us> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190322165636.1725-1-jiri@resnulli.us> References: <20190322165636.1725-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Since the port attributes are static and cannot change during the port lifetime, WARN_ON if some driver calls it after registration. Also, no need to call notifications as it is noop anyway due to check of devlink_port->registered there. Signed-off-by: Jiri Pirko --- net/core/devlink.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index 98ca788ffd97..f77a68f72d14 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -5425,12 +5425,13 @@ void devlink_port_attrs_set(struct devlink_port *devlink_port, { struct devlink_port_attrs *attrs = &devlink_port->attrs; + if (WARN_ON(devlink_port->registered)) + return; attrs->set = true; attrs->flavour = flavour; attrs->port_number = port_number; attrs->split = split; attrs->split_subport_number = split_subport_number; - devlink_port_notify(devlink_port, DEVLINK_CMD_PORT_NEW); } EXPORT_SYMBOL_GPL(devlink_port_attrs_set); -- 2.17.2