From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82B50C43381 for ; Fri, 22 Mar 2019 16:57:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 507A02190A for ; Fri, 22 Mar 2019 16:57:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="vmfD1+ZM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728783AbfCVQ5C (ORCPT ); Fri, 22 Mar 2019 12:57:02 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:37558 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728706AbfCVQ5B (ORCPT ); Fri, 22 Mar 2019 12:57:01 -0400 Received: by mail-wm1-f68.google.com with SMTP id v14so2874239wmf.2 for ; Fri, 22 Mar 2019 09:57:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8E/rKiGf6yFnTmukOisCgun28JW5DC++XRKHwuO/RUI=; b=vmfD1+ZMFq9VeMybi8jZn9at8asEV6/EZPQkIuBr6/U+ObQztWSwToeeANRHD/nYZN pK+MCIymmek18+PZXKsQiQMJ8d1iHyCyf2udQY+YI16wAzQIGJ9SUvXN0vxY9+FGQ6/V mgDSfmsKwGWhUD6U2VH4w+exvlahmOClZdTuBuVVQoxFek+vFyFcYtNjYIO0G0XZG2Fs ZQaIO+oMbLk4tPKsj+MAQH6RPtGtzCIIKe3qZgg3qEtzPAKSto0weAeDoRSBDxxbZL/q O4eGDpDqe+PcH6mMGccNfUiEQ07Vw1jFwVLEk5jujiDZlB52wTWlrQxN/FCINL2ZgntR Ll4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8E/rKiGf6yFnTmukOisCgun28JW5DC++XRKHwuO/RUI=; b=QBj//GtOG/ZR0+h3Ce5rjhwLT1t3Fy1rN3U5XhwRq77sxY/XNaQJ8fOPUVV3q096WY wsdu/ef95Oj24JG+5jGbM5PRkj4Zh32a5v7+vfMHb1c950+m/p3ST7R9olWB0MzIxfGu BKFz+IXThiag1Z4zcIj7/SiKjx1dbouMPETuRpgQ/x4tGe8FCBkLwAOyib4pblSvkJUS pjUQ1nyJPGH6029txbZBq6WG1uWSQpdfLQYtzT1h4UUNq3z5OscMo9eZ3zZuwMJclUU8 rdJZE5nDJORF/7WYLy40n7++PLWNCzNZJrnZ2HvUU8UhBl29k2/0Ns/Tf+dnVwmAfxcK A5Qg== X-Gm-Message-State: APjAAAWR/RjXQFwaSWtV9gqGNM9g7e/LIqAdzUDqZ7UaOS2MJvhkFxzv f1VHrnkIhzPspnT8LvlaYeV69x/4/DE= X-Google-Smtp-Source: APXvYqxF6oawIylm7DpaCmNN4C7s6PUF38Zz9ubjt2WyAnDcJ2BN0VSkq3504UDV5bubf8pOMHWjjA== X-Received: by 2002:a1c:d04a:: with SMTP id h71mr3637273wmg.120.1553273819625; Fri, 22 Mar 2019 09:56:59 -0700 (PDT) Received: from localhost ([195.39.71.253]) by smtp.gmail.com with ESMTPSA id a2sm7886021wrr.60.2019.03.22.09.56.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Mar 2019 09:56:58 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: [patch net-next v2 12/15] bnxt: set devlink port type after registration Date: Fri, 22 Mar 2019 17:56:33 +0100 Message-Id: <20190322165636.1725-13-jiri@resnulli.us> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190322165636.1725-1-jiri@resnulli.us> References: <20190322165636.1725-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Move the type set of devlink port after it is registered. Signed-off-by: Jiri Pirko --- v1->v2: - new patch --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c index a266bff559dc..ab6fd05c462b 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c @@ -229,7 +229,6 @@ int bnxt_dl_register(struct bnxt *bp) goto err_dl_unreg; } - devlink_port_type_eth_set(&bp->dl_port, bp->dev); devlink_port_attrs_set(&bp->dl_port, DEVLINK_PORT_FLAVOUR_PHYSICAL, bp->pf.port_id, false, 0); rc = devlink_port_register(dl, &bp->dl_port, bp->pf.port_id); @@ -237,6 +236,7 @@ int bnxt_dl_register(struct bnxt *bp) netdev_err(bp->dev, "devlink_port_register failed"); goto err_dl_param_unreg; } + devlink_port_type_eth_set(&bp->dl_port, bp->dev); rc = devlink_port_params_register(&bp->dl_port, bnxt_dl_port_params, ARRAY_SIZE(bnxt_dl_port_params)); -- 2.17.2