From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4F7AC4360F for ; Fri, 22 Mar 2019 16:57:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF45C21916 for ; Fri, 22 Mar 2019 16:57:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="Sge21z8a" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728818AbfCVQ5E (ORCPT ); Fri, 22 Mar 2019 12:57:04 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:37558 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728756AbfCVQ5C (ORCPT ); Fri, 22 Mar 2019 12:57:02 -0400 Received: by mail-wm1-f65.google.com with SMTP id v14so2874291wmf.2 for ; Fri, 22 Mar 2019 09:57:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NczgQSDFhcv/vkUXKsZ5SvCYJNjz1+BHLMc/Zol+rPE=; b=Sge21z8aRABK0doFLCZ1jZJVBWWcWyFSWdKuGjOqPn5frWgAiRn4p6RUjsrTAzeW4e o/giKOgLx9RqfIGvgUJf6zA26ngL98FE1iliRHO99yK0mRWF+yc78X9Tyto4qHKzXBfh 5ocl8DlTcn9H4ijdOiRYlyY9fGtmA1iNAiOYpMSgbwVqL34mWTNIbQKTk3enn7IxbK8I fbskakU5i252Hbffk+j3lbEaZZBMSi8cgEDjpEJClfSdXLVPbCm41tgOYLD3tx3jOAov XSjhp/4oahyr6uokSq/ajhuoSM41v1fXd0B5xhQw8Mglsbi69YtB2XAHQJGVptrQ+vVh LydA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NczgQSDFhcv/vkUXKsZ5SvCYJNjz1+BHLMc/Zol+rPE=; b=X2eoYlFdggM7XO+f+ToCta2UnPNffVj4qXTKSrYCxBKD8ZF5vXhlQT63/ngQT8XPuc aazERScbnjt/14vq7GoCW0qjfYMtfwPRnk56ablqMQlMUg/X1qw9HhTN/EFhnvYvUcCG /aTrS145keEauXvkTRU+tRmr2diwdqqOe1oKs6OFCq5aMXwsViGj7nf8fGyNYLVZSpFE snlZe7aMXA3L2C9yeSrW5o1HX27vzLzmS16JrZKHlKWN5sXTrViJJbZyDc87nxJXs1eY XWTsRwJGVmXWA6Z2I7PT201f9DR45KcvtWb5/94nK31NsGT0TdROnDeB1UEK7ye8D+8C 313A== X-Gm-Message-State: APjAAAUT/P+McQhs50Pz3L0G9ca3dl73oDGjjKzgN3/wBAz6VGEkSjVo 2ldc9cO2KZzJWVqU1ErGtXlCABBj0Qw= X-Google-Smtp-Source: APXvYqyS9qw4AluYSFRVeMtHIsPra1B/G4OBYFRRKHj6FzBqJ2mVmodNBk4kVyJQa7c+CsW9TtVqVg== X-Received: by 2002:a1c:701a:: with SMTP id l26mr3404568wmc.27.1553273820810; Fri, 22 Mar 2019 09:57:00 -0700 (PDT) Received: from localhost ([195.39.71.253]) by smtp.gmail.com with ESMTPSA id j13sm10038616wrx.74.2019.03.22.09.57.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Mar 2019 09:57:00 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: [patch net-next v2 13/15] net: devlink: warn on setting type on unregistered port Date: Fri, 22 Mar 2019 17:56:34 +0100 Message-Id: <20190322165636.1725-14-jiri@resnulli.us> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190322165636.1725-1-jiri@resnulli.us> References: <20190322165636.1725-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Port needs to be registered first before the type is set. Warn and bail-out in case it is not. Signed-off-by: Jiri Pirko --- v1->v2: - new patch --- net/core/devlink.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/devlink.c b/net/core/devlink.c index f77a68f72d14..ff3e31010954 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -5365,6 +5365,8 @@ static void __devlink_port_type_set(struct devlink_port *devlink_port, enum devlink_port_type type, void *type_dev) { + if (WARN_ON(!devlink_port->registered)) + return; devlink_port->type = type; devlink_port->type_dev = type_dev; devlink_port_notify(devlink_port, DEVLINK_CMD_PORT_NEW); -- 2.17.2