From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8245CC10F03 for ; Fri, 22 Mar 2019 16:56:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51D562190A for ; Fri, 22 Mar 2019 16:56:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="eRSdbd5w" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728564AbfCVQ4t (ORCPT ); Fri, 22 Mar 2019 12:56:49 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:35391 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728515AbfCVQ4s (ORCPT ); Fri, 22 Mar 2019 12:56:48 -0400 Received: by mail-wr1-f66.google.com with SMTP id w1so3147559wrp.2 for ; Fri, 22 Mar 2019 09:56:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=wTzRy17GQ9eTfGlBmCL83qdRwlpf9GPWkB6XRQuibUQ=; b=eRSdbd5wChPwHkC8HQH04xIRZ5WjaEhRadkYV5XMMfyjHLsCRT23u6hzfb+2e9/A2W VioTHICas2AkEPqOjZLjTj+ec/cXJ6l3VuzQOwVV3H0WUwHNoLNQesyc8IUv/9gxiKuN T2ntojGudIViJA/NwnllyGRMuMMw3wSx0LjcjlSZybWLgKPIpJzdw5FNnaYwjP5+KyD1 YrswNlF4X6wGUrjoEJOES6L0Rs9nJp/v9jCM8/ccVYyHauouOFN099W1nQ8u68mFB0tW KPTwlTLgivaLt140C7E+MHeR1hB0Ijtbi061Mkvhll+YDa96bmUWs7Pk8oN7ziPewhSh 6VrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wTzRy17GQ9eTfGlBmCL83qdRwlpf9GPWkB6XRQuibUQ=; b=AcFGEr7lf5jMC3frh7Ln49QFxsf/Vdqw1HIPFnCzXo/aF33fNmMzGcvamo+2eVH5aN Fs1bQ6PioKTtZvCFsaJLcJJ4dGMQPFb7YuJhcOH05GzevxW43IY6kocyWuBqCPWdodrn h7q9QTBWV5/9ftuvm5Y+fg2kx/k9ZpUOKBwnPTps8rc1AfXassB8MO9/guD+PrfwDKOh OvePW+YBUVaRvFHMqSDdDZNxjMtLFzPQV1IW/tSr+bscvltxbyWJ6LQv9vL5+//Oyy5q krAoGkRyZ9RoIS8YuYxfyA6VRre4l+3BlkWfOsFrp+tXmS687PGupVpmIfyKp4ZIVTq/ LJfg== X-Gm-Message-State: APjAAAVDPjp1aia6YpEafqElPWq8ySCYLW7Sonuxqd+a3OJFzuHGQClH FXDQ6lFS3ygzWuwW/Qc5lQEu8amNj2s= X-Google-Smtp-Source: APXvYqwQv4TYnwg4ojTvOlcA2Nb9yHD04N+aHh+hKevJUbrEfWeRF6JMX7rvk/BvI0rYmscfeCNobA== X-Received: by 2002:a5d:660c:: with SMTP id n12mr6989840wru.160.1553273806712; Fri, 22 Mar 2019 09:56:46 -0700 (PDT) Received: from localhost ([195.39.71.253]) by smtp.gmail.com with ESMTPSA id f4sm5735456wmj.34.2019.03.22.09.56.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Mar 2019 09:56:46 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: [patch net-next v2 05/15] bnxt: call devlink_port_type_eth_set() before port register Date: Fri, 22 Mar 2019 17:56:26 +0100 Message-Id: <20190322165636.1725-6-jiri@resnulli.us> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190322165636.1725-1-jiri@resnulli.us> References: <20190322165636.1725-1-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Call devlink_port_type_eth_set() before devlink_port_register(). Bnxt instances won't change type during lifetime. This avoids one extra userspace devlink notification. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c index ab6fd05c462b..a266bff559dc 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c @@ -229,6 +229,7 @@ int bnxt_dl_register(struct bnxt *bp) goto err_dl_unreg; } + devlink_port_type_eth_set(&bp->dl_port, bp->dev); devlink_port_attrs_set(&bp->dl_port, DEVLINK_PORT_FLAVOUR_PHYSICAL, bp->pf.port_id, false, 0); rc = devlink_port_register(dl, &bp->dl_port, bp->pf.port_id); @@ -236,7 +237,6 @@ int bnxt_dl_register(struct bnxt *bp) netdev_err(bp->dev, "devlink_port_register failed"); goto err_dl_param_unreg; } - devlink_port_type_eth_set(&bp->dl_port, bp->dev); rc = devlink_port_params_register(&bp->dl_port, bnxt_dl_port_params, ARRAY_SIZE(bnxt_dl_port_params)); -- 2.17.2