All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: David Ahern <dsahern@gmail.com>
Cc: David Ahern <dsahern@kernel.org>,
	davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ipv6: Move ipv6 stubs to a separate header file
Date: Fri, 22 Mar 2019 10:04:37 -0700	[thread overview]
Message-ID: <20190322170435.abiwibew67527lde@ast-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <57a656dc-5be4-830a-2a54-550d0a62a475@gmail.com>

On Fri, Mar 22, 2019 at 05:17:52PM +0100, David Ahern wrote:
> On 3/22/19 5:14 PM, Alexei Starovoitov wrote:
> > On Fri, Mar 22, 2019 at 06:06:09AM -0700, David Ahern wrote:
> >> From: David Ahern <dsahern@gmail.com>
> >>
> >> The number of stubs is growing and has nothing to do with addrconf.
> >> Move the definition of the stubs to a separate header file and update
> >> users. In the move, drop the vxlan specific comment before ipv6_stub.
> >>
> >> Code move only; no functional change intended.
> >>
> >> Signed-off-by: David Ahern <dsahern@gmail.com>
> > 
> > nack.
> > why this code churn?
> 
> This is a prep patch for nexthops as separate objects. I will be adding
> 4 more functions to the stubs, and I hit a bit of a header nightmare
> with it in addrconf.h.

please do not.
I see no value in splitting nexthops either.


  reply	other threads:[~2019-03-22 17:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-22 13:06 [PATCH net-next] ipv6: Move ipv6 stubs to a separate header file David Ahern
2019-03-22 16:14 ` Alexei Starovoitov
2019-03-22 16:17   ` David Ahern
2019-03-22 17:04     ` Alexei Starovoitov [this message]
2019-03-24  1:40 ` David Miller
2019-03-24  3:55   ` Alexei Starovoitov
2019-03-24 12:56     ` David Ahern
2019-03-25  3:26       ` Alexei Starovoitov
2019-03-25 15:39         ` Stephen Suryaputra
2019-03-25 17:02         ` David Ahern
2019-03-26  3:05           ` Alexei Starovoitov
2019-03-26 14:19             ` David Ahern
2019-03-26 15:11               ` Alexei Starovoitov
2019-03-26 15:29                 ` David Ahern
2019-03-26  2:22         ` David Ahern
2019-03-29 17:55 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190322170435.abiwibew67527lde@ast-mbp.dhcp.thefacebook.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.