All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>,
	netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
	Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>,
	Andrew Bowers <andrewx.bowers@intel.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 14/15] ice: Don't let VF know that it is untrusted
Date: Fri, 22 Mar 2019 10:33:27 -0700	[thread overview]
Message-ID: <20190322173328.2493-15-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20190322173328.2493-1-jeffrey.t.kirsher@intel.com>

From: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>

Don't let the VF know it's not trusted when it tries to add more than
permitted additional MAC addresses.

Signed-off-by: Akeem G Abodunrin <akeem.g.abodunrin@intel.com>
Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
index 6c0178b4b3ab..fe218e62e83e 100644
--- a/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
+++ b/drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c
@@ -1969,7 +1969,7 @@ ice_vc_handle_mac_addr_msg(struct ice_vf *vf, u8 *msg, bool set)
 	    (struct virtchnl_ether_addr_list *)msg;
 	struct ice_pf *pf = vf->pf;
 	enum virtchnl_ops vc_op;
-	enum ice_status ret;
+	enum ice_status ret = 0;
 	LIST_HEAD(mac_list);
 	struct ice_vsi *vsi;
 	int mac_count = 0;
@@ -1989,8 +1989,11 @@ ice_vc_handle_mac_addr_msg(struct ice_vf *vf, u8 *msg, bool set)
 	if (set && !ice_is_vf_trusted(vf) &&
 	    (vf->num_mac + al->num_elements) > ICE_MAX_MACADDR_PER_VF) {
 		dev_err(&pf->pdev->dev,
-			"Can't add more MAC addresses, because VF is not trusted, switch the VF to trusted mode in order to add more functionalities\n");
-		ret = ICE_ERR_PARAM;
+			"Can't add more MAC addresses, because VF-%d is not trusted, switch the VF to trusted mode in order to add more functionalities\n",
+			vf->vf_id);
+		/* There is no need to let VF know about not being trusted
+		 * to add more MAC addr, so we can just return success message.
+		 */
 		goto handle_mac_exit;
 	}
 
@@ -2270,7 +2273,8 @@ static int ice_vc_process_vlan_msg(struct ice_vf *vf, u8 *msg, bool add_v)
 	if (add_v && !ice_is_vf_trusted(vf) &&
 	    vf->num_vlan >= ICE_MAX_VLAN_PER_VF) {
 		dev_info(&pf->pdev->dev,
-			 "VF is not trusted, switch the VF to trusted mode, in order to add more VLAN addresses\n");
+			 "VF-%d is not trusted, switch the VF to trusted mode, in order to add more VLAN addresses\n",
+			 vf->vf_id);
 		/* There is no need to let VF know about being not trusted,
 		 * so we can just return success message here
 		 */
-- 
2.20.1


  parent reply	other threads:[~2019-03-22 17:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-22 17:33 [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2019-03-22 Jeff Kirsher
2019-03-22 17:33 ` [net-next 01/15] ice: Enable MAC anti-spoof by default Jeff Kirsher
2019-03-22 17:33 ` [net-next 02/15] ice: Fix issue reclaiming resources back to the pool after reset Jeff Kirsher
2019-03-22 17:33 ` [net-next 03/15] ice: fix static analysis warnings Jeff Kirsher
2019-03-22 17:33 ` [net-next 04/15] ice: Remove unused function prototype Jeff Kirsher
2019-03-22 17:33 ` [net-next 05/15] ice: Fix issue reconfiguring VF queues Jeff Kirsher
2019-03-22 17:33 ` [net-next 06/15] ice: fix the divide by zero issue Jeff Kirsher
2019-03-22 17:33 ` [net-next 07/15] ice: fix some function prototype and signature style issues Jeff Kirsher
2019-03-22 17:33 ` [net-next 08/15] ice: Remove unused vsi_id field Jeff Kirsher
2019-03-22 17:33 ` [net-next 09/15] ice: code cleanup in ice_sched.c Jeff Kirsher
2019-03-22 17:33 ` [net-next 10/15] ice: Add support for PF/VF promiscuous mode Jeff Kirsher
2019-03-22 17:33 ` [net-next 11/15] ice: Enable LAN_EN for the right recipes Jeff Kirsher
2019-03-22 17:33 ` [net-next 12/15] ice: Do not set LB_EN for prune switch rules Jeff Kirsher
2019-03-22 17:33 ` [net-next 13/15] ice: Set LAN_EN for all directional rules Jeff Kirsher
2019-03-22 17:33 ` Jeff Kirsher [this message]
2019-03-22 17:33 ` [net-next 15/15] ice: Get VF VSI instances directly via PF Jeff Kirsher
2019-03-24  2:03 ` [net-next 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2019-03-22 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190322173328.2493-15-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=akeem.g.abodunrin@intel.com \
    --cc=andrewx.bowers@intel.com \
    --cc=anirudh.venkataramanan@intel.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.