From: Yannick Lamarre <ylamarre@efficios.com>
To: lttng-dev@lists.lttng.org
Cc: jgalar@efficios.com
Subject: [PATCH lttng-tools v3 4/8] Adapt poll layer behaviour to match the epoll layer
Date: Fri, 22 Mar 2019 14:19:24 -0400 [thread overview]
Message-ID: <20190322181928.6186-4-ylamarre__38466.1849167728$1553278962$gmane$org@efficios.com> (raw)
In-Reply-To: <20190322181928.6186-1-ylamarre@efficios.com>
Signed-off-by: Yannick Lamarre <ylamarre@efficios.com>
---
src/common/compat/compat-poll.c | 30 ++++++++++++++++++++----------
1 file changed, 20 insertions(+), 10 deletions(-)
diff --git a/src/common/compat/compat-poll.c b/src/common/compat/compat-poll.c
index b45b39dc..be655728 100644
--- a/src/common/compat/compat-poll.c
+++ b/src/common/compat/compat-poll.c
@@ -1,5 +1,6 @@
/*
* Copyright (C) 2011 - David Goulet <david.goulet@polymtl.ca>
+ * Copyright (C) 2019 - Yannick Lamarre <ylamarre@efficios.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License, version 2 only,
@@ -204,10 +205,10 @@ int compat_poll_mod(struct lttng_poll_event *events, int fd,
uint32_t req_events)
{
int i;
- bool fd_found = false;
struct compat_poll_event_array *current;
- if (events == NULL || events->current.events == NULL || fd < 0) {
+ if (events == NULL || events->current.nb_fd == 0 ||
+ events->current.events == NULL || fd < 0) {
ERR("Bad compat poll mod arguments");
goto error;
}
@@ -216,16 +217,16 @@ int compat_poll_mod(struct lttng_poll_event *events, int fd,
for (i = 0; i < current->nb_fd; i++) {
if (current->events[i].fd == fd) {
- fd_found = true;
current->events[i].events = req_events;
events->need_update = 1;
break;
}
}
- if (!fd_found) {
- goto error;
- }
+ /*
+ * The epoll flavor doesn't flag modifying a non-included FD as an
+ * error.
+ */
return 0;
@@ -238,11 +239,12 @@ error:
*/
int compat_poll_del(struct lttng_poll_event *events, int fd)
{
- int new_size, i, count = 0, ret;
+ int i, count = 0, ret;
+ uint32_t new_size;
struct compat_poll_event_array *current;
- if (events == NULL || events->current.events == NULL || fd < 0) {
- ERR("Wrong arguments for poll del");
+ if (events == NULL || events->current.nb_fd == 0 ||
+ events->current.events == NULL || fd < 0) {
goto error;
}
@@ -257,13 +259,20 @@ int compat_poll_del(struct lttng_poll_event *events, int fd)
count++;
}
}
+
+ /* The fd was not in our set, return no error as with epoll. */
+ if (current->nb_fd == count) {
+ goto end;
+ }
+
/* No fd duplicate should be ever added into array. */
assert(current->nb_fd - 1 == count);
current->nb_fd = count;
/* Resize array if needed. */
new_size = 1U << utils_get_count_order_u32(current->nb_fd);
- if (new_size != current->alloc_size && new_size >= current->init_size) {
+ if (new_size != current->alloc_size && new_size >= current->init_size
+ && current->nb_fd != 0) {
ret = resize_poll_event(current, new_size);
if (ret < 0) {
goto error;
@@ -272,6 +281,7 @@ int compat_poll_del(struct lttng_poll_event *events, int fd)
events->need_update = 1;
+end:
return 0;
error:
--
2.11.0
next prev parent reply other threads:[~2019-03-22 18:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190322181928.6186-1-ylamarre@efficios.com>
2019-03-22 18:19 ` [PATCH lttng-tools v3 2/8] Add Unit test to poll compatibility layer Yannick Lamarre
2019-03-22 18:19 ` [PATCH lttng-tools v3 3/8] Change LTTNG_POLL_GETNB behaviour for poll flavor Yannick Lamarre
2019-03-22 18:19 ` Yannick Lamarre [this message]
2019-03-22 18:19 ` [PATCH lttng-tools v3 5/8] Fix hang in thread_rotation when using compat-poll Yannick Lamarre
2019-03-22 18:19 ` [PATCH lttng-tools v3 6/8] Change lttng_poll_wait behaviour of compat-poll to match compat-epoll Yannick Lamarre
2019-03-22 18:19 ` [PATCH lttng-tools v3 7/8] Clean code base from redundant verification Yannick Lamarre
2019-03-22 18:19 ` [PATCH lttng-tools v3 8/8] Fix typo Yannick Lamarre
2019-03-22 18:50 ` [PATCH lttng-tools v3 1/8] Fix: lttng_poll_mod calls compat_(e)poll_add Jonathan Rajotte-Julien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20190322181928.6186-4-ylamarre__38466.1849167728$1553278962$gmane$org@efficios.com' \
--to=ylamarre@efficios.com \
--cc=jgalar@efficios.com \
--cc=lttng-dev@lists.lttng.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.