From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 077DFC43381 for ; Fri, 22 Mar 2019 21:01:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C8F1F21925 for ; Fri, 22 Mar 2019 21:01:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lxO7/ClN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727502AbfCVVBN (ORCPT ); Fri, 22 Mar 2019 17:01:13 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:45931 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727442AbfCVVBN (ORCPT ); Fri, 22 Mar 2019 17:01:13 -0400 Received: by mail-pf1-f194.google.com with SMTP id e24so1463235pfi.12 for ; Fri, 22 Mar 2019 14:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RppXf40PP4DeyuhdITliU1/Y/nI5d6Nu3Uy95Mks4cM=; b=lxO7/ClNXPNUb9D3BQ9+uIVBwqG1Car4T9Ma9dugWafDqb9IRDIltIWTdbUYwbZv2a 12YrO4MJ9HHzoUf4tGDDMTjNThkIDwxqnBnh1UZcVe+aukXgLVxrx+DOgkJbjrp570pL 1/cPvPaKaNB7dis55XZCHwPFy2XOPzNHfhG2dSXMRN5TaVQT1r/62Fb9kb9Ra3rztmM/ fBx3W49zU7DXZmMR+56kXHSWgdSW+TYiWcBf1RhwkVQapt/b1+pZnLqzCHmxy0OXBQgo RzI+LYoxeuA+Ruaxkc9Mpl3/M5hQCJDI6nTW2iJYMRGnGaERtRymiRbDcPp/wZKTueTw ef4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RppXf40PP4DeyuhdITliU1/Y/nI5d6Nu3Uy95Mks4cM=; b=AIww+twz8zWwK+xnB3shbEvoQ/6QlxIdPcXmEbrVnRTVB+Nd9wvnN3OkX84Bn2x0Su gUYYMUFbTMeGclDTYcPoNBN3t3u0GTPB+OdLOVV5y+1rXid+oBN9iC+Mt7G6OgQMdIdL b3zBTby9Ff/jfBbA5InRtUFsDzWG9ZoWVyvMBQvAA9TfJYu2sSW8DDYtbNTtGwgev+6i Et2tYR0lNd9nqqtnMI9zfUPMRlh+g1Ac5oqavRQCr78INKXxdmCIjS0EirhgTPEtX1si CacubWX86brYx8wdIefGSG7aGBa2W2PEx50VswqCGIUIRPkeAo7cQxxjrFbNh8j6zes2 hEgQ== X-Gm-Message-State: APjAAAV8HBb1umeeGUiY6Dy1dSn/j5VR1B0jv2q3zc1/xw9qtcBM1Fxn nD47YHIK5cjEK8dkW//muUE= X-Google-Smtp-Source: APXvYqyv2UhJOdnRm4CWMXUuUX/nmoCXt0i6L0IqTtDFVTddZJyQCAsjNHdxOq8/WydPMWgOyOfbQw== X-Received: by 2002:a63:5541:: with SMTP id f1mr11061841pgm.38.1553288472008; Fri, 22 Mar 2019 14:01:12 -0700 (PDT) Received: from ast-mbp.dhcp.thefacebook.com ([2620:10d:c090:200::e4e7]) by smtp.gmail.com with ESMTPSA id b15sm13446125pgd.44.2019.03.22.14.01.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Mar 2019 14:01:11 -0700 (PDT) Date: Fri, 22 Mar 2019 14:01:10 -0700 From: Alexei Starovoitov To: Willem de Bruijn Cc: netdev@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, sdf@google.com, posk@google.com, Willem de Bruijn Subject: Re: [PATCH bpf-next v3 00/13] bpf tc tunneling Message-ID: <20190322210108.3jftrdhrictbdeu5@ast-mbp.dhcp.thefacebook.com> References: <20190322183300.196277-1-willemdebruijn.kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190322183300.196277-1-willemdebruijn.kernel@gmail.com> User-Agent: NeoMutt/20180223 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Mar 22, 2019 at 02:32:47PM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > BPF allows for dynamic tunneling, choosing the tunnel destination and > features on-demand. Extend bpf_skb_adjust_room to allow for efficient > tunneling at the TC hooks. > > Most features are required for large packets with GSO, as these will > be modified after this patch. > > Patch 1 > is a performance optimization, avoiding an unnecessary unclone > for the TCP hot path. > > Patches 2..6 > introduce a regression test. These can be squashed, but the code is > arguably more readable when gradually expanding the feature set. > > Patch 7 > is a performance optimization, avoid copying network headers > that are going to be overwritten. This also simplifies the bpf > program. > > Patch 8 > reenables bpf_skb_adjust_room for UDP packets. > > Patch 9 > configures skb tunneling metadata analogous to tunnel devices. > > Patches 10..13 > expand the regression test to make use of the new features and > enable the GSO testcases. > > Changes > v1->v2 > - move BPF_F_ADJ_ROOM_MASK out of uapi as it can be expanded > - document new flags > - in tests replace netcat -q flag with coreutils timeout: > the -q flag is not supported in all netcat versions > v2->v3 > - move BPF_F_ADJ_ROOM_ENCAP_L3_MASK out of uapi as it has no > use in userspace Applied, Thanks