From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: jon.maloy@ericsson.com, ying.xue@windriver.com,
clang-built-linux@googlegroups.com, ndesaulniers@google.com,
natechancellor@gmail.com, tuong.t.lien@dektech.com.au,
canh.d.luu@dektech.com.au, tung.q.nguyen@dektech.com.au,
mohan.krishna.ghanta.krishnamurthy@ericsson.com,
netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tipc: avoid a clang -Wuninitialized warning
Date: Sat, 23 Mar 2019 21:49:10 -0400 (EDT) [thread overview]
Message-ID: <20190323.214910.174783827736915395.davem@davemloft.net> (raw)
In-Reply-To: <20190322141819.641588-1-arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Fri, 22 Mar 2019 15:18:13 +0100
> clang notices that we pass 'maddr' into the tipc_bearer_xmit() function
> without having initialized it first:
...
> This is harmless because it won't use 'maddr' if the
> queue is empty, but it's better to make that explicit
> and not even call the function in that case.
>
> As clang is able to inline the check, it then notices that
> the code is safe.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
It looks like Jon's patch took care of this.
prev parent reply other threads:[~2019-03-24 1:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 14:18 [PATCH] tipc: avoid a clang -Wuninitialized warning Arnd Bergmann
2019-03-22 16:12 ` Nathan Chancellor
2019-03-24 1:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190323.214910.174783827736915395.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=canh.d.luu@dektech.com.au \
--cc=clang-built-linux@googlegroups.com \
--cc=jon.maloy@ericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mohan.krishna.ghanta.krishnamurthy@ericsson.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=tung.q.nguyen@dektech.com.au \
--cc=tuong.t.lien@dektech.com.au \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.