From: David Miller <davem@davemloft.net>
To: pabeni@redhat.com
Cc: netdev@vger.kernel.org, edumazet@google.com,
john.fastabend@gmail.com, ivecera@redhat.com
Subject: Re: [PATCH net-next v3 0/2] net: dev: BYPASS for lockless qdisc
Date: Sat, 23 Mar 2019 21:54:03 -0400 (EDT) [thread overview]
Message-ID: <20190323.215403.340785854005311185.davem@davemloft.net> (raw)
In-Reply-To: <cover.1553263445.git.pabeni@redhat.com>
From: Paolo Abeni <pabeni@redhat.com>
Date: Fri, 22 Mar 2019 16:01:54 +0100
> This patch series is aimed at improving xmit performances of lockless qdisc
> in the uncontended scenario.
>
> After the lockless refactor pfifo_fast can't leverage the BYPASS optimization.
> Due to retpolines the overhead for the avoidables enqueue and dequeue operations
> has increased and we see measurable regressions.
>
> The first patch introduces the BYPASS code path for lockless qdisc, and the
> second one optimizes such path further. Overall this avoids up to 3 indirect
> calls per xmit packet. Detailed performance figures are reported in the 2nd
> patch.
>
> v2 -> v3:
> - qdisc_is_empty() has a const argument (Eric)
>
> v1 -> v2:
> - use really an 'empty' flag instead of 'not_empty', as
> suggested by Eric
Looks great, series applied, thanks Paolo.
prev parent reply other threads:[~2019-03-24 1:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 15:01 [PATCH net-next v3 0/2] net: dev: BYPASS for lockless qdisc Paolo Abeni
2019-03-22 15:01 ` [PATCH net-next v3 1/2] net: sched: add empty status flag for NOLOCK qdisc Paolo Abeni
2019-03-22 15:18 ` Eric Dumazet
2019-03-22 15:24 ` Ivan Vecera
2019-03-22 15:01 ` [PATCH net-next v3 2/2] net: dev: introduce support for sch BYPASS for lockless qdisc Paolo Abeni
2019-03-24 1:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190323.215403.340785854005311185.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ivecera@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.